Reply to thread

Message

<blockquote data-quote="Lightning303" data-source="post: 1112313" data-attributes="member: 97876">I see <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite1" alt=":)" title="Smile&nbsp; &nbsp; :)" loading="lazy" data-shortname=":)" />Yeah that would be possible. I thought about it a bit and came up with 2 different approaches. Not sure which one is best though <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite7" alt=":p" title="Stick Out Tongue&nbsp; &nbsp; :p" loading="lazy" data-shortname=":p" />. I think approach 2, but lets see what [USER=17766]@Rick164[/USER] says.First approach:We would need to extend ITargets, added methods like GetContextMenuContent() and ExecuteCommand(string commands).And in every Target we would need to add a roadmap how to build the menu. E.g. for Hueitem=&quot;Use all Groups&quot;onPress=&quot;group:all&quot;item=&quot;Use group:&quot;onPress=&quot;group:[keyboard]&quot;where MP1 plugin would need to open the onscreen keyboard when it sees the [keyboard].Not sure which data format would be best for this, as we could also use submenus, so maybe json or something similar?In core we would have a method that collects all the menu infos (calling GetContextMenuContent() on every enabled target).And in MP1 we would call this method in core and then would need to parse all these information to then build a menu out of that.When an item is selected, we would call the core with the result, e.g. ExecuteCommand(Target.Hue, &quot;group:all&quot;), the core then sends it to hue handler with ExecuteCommand(&quot;group:all&quot;) and HueHandler would need to parse this and then set the group to all in this example.I reckon this would be quite some work. Also not sure if we would need the menu layout in the handler, as displaying and the way something is displayed is not the task of the handler or core.Second approach:In MP1 check if Hue is a target, and then get its instance.We would need this in core:[code]&nbsp; &nbsp; public ITargets GetTarget(Target target)&nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; lock (targetsLock)&nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; foreach (var t in targets)&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (t.Name == target)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return t;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; return null;&nbsp; &nbsp; }[/code]and in MP1 we could do:[code]var hueTarget = coreObject.GetTarget(Target.Hue) as AtmoLight.Targets.HueHandler;[/code]And now we could use hueTarget.ChangeGroup(&quot;all&quot;) fo example.Context Menu in general [USER=17766]@Rick164[/USER]:The context menu starts here: <a href="https://github.com/ambilight-4-mediaportal/AtmoLight/blob/master/AtmoLight.MediaPortal1/Plugin.cs#L644" target="_blank">https://github.com/ambilight-4-mediaportal/AtmoLight/blob/master/AtmoLight.MediaPortal1/Plugin.cs#L644</a>The general layout is:[code]&nbsp; &nbsp; &nbsp; GUIDialogMenu dlg = (GUIDialogMenu)GUIWindowManager.GetWindow((int)GUIWindow.Window.WINDOW_DIALOG_MENU);&nbsp; &nbsp; &nbsp; dlg.Reset();&nbsp; &nbsp; &nbsp; dlg.SetHeading(&quot;AtmoLight&quot;);&nbsp; &nbsp; &nbsp; dlg.Add(new GUIListItem(&quot;Item 1&quot;));&nbsp; &nbsp; &nbsp; dlg.Add(new GUIListItem(&quot;Item 2&quot;));&nbsp; &nbsp; &nbsp; dlg.Add(new GUIListItem(&quot;Item 3&quot;));&nbsp; &nbsp; &nbsp; dlg.SelectedLabel = 0;&nbsp; &nbsp; &nbsp; dlg.DoModal(GUIWindowManager.ActiveWindow);&nbsp; &nbsp; &nbsp; if (dlg.SelectedLabelText == &quot;Item 1&quot;)&nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; // do this&nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; ....[/code]So we would need to add a new Item to DialogContextMenu() and when that is selected we would need to make a new GUIDialogMenu that then has all the Hue stuff in it. Either having this generated dynamically with approach 1 or code it into MP1 plugin with approach 2, or you have some other ideas <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite1" alt=":)" title="Smile&nbsp; &nbsp; :)" loading="lazy" data-shortname=":)" />.</blockquote>

[QUOTE="Lightning303, post: 1112313, member: 97876"] I see :) Yeah that would be possible. I thought about it a bit and came up with 2 different approaches. Not sure which one is best though :P. I think approach 2, but lets see what [USER=17766]@Rick164[/USER] says. First approach: We would need to extend ITargets, added methods like GetContextMenuContent() and ExecuteCommand(string commands). And in every Target we would need to add a roadmap how to build the menu. E.g. for Hue item="Use all Groups" onPress="group:all" item="Use group:" onPress="group:[keyboard]" where MP1 plugin would need to open the onscreen keyboard when it sees the [keyboard]. Not sure which data format would be best for this, as we could also use submenus, so maybe json or something similar? In core we would have a method that collects all the menu infos (calling GetContextMenuContent() on every enabled target). And in MP1 we would call this method in core and then would need to parse all these information to then build a menu out of that. When an item is selected, we would call the core with the result, e.g. ExecuteCommand(Target.Hue, "group:all"), the core then sends it to hue handler with ExecuteCommand("group:all") and HueHandler would need to parse this and then set the group to all in this example. I reckon this would be quite some work. Also not sure if we would need the menu layout in the handler, as displaying and the way something is displayed is not the task of the handler or core. Second approach: In MP1 check if Hue is a target, and then get its instance. We would need this in core: [code] public ITargets GetTarget(Target target) { lock (targetsLock) { foreach (var t in targets) { if (t.Name == target) { return t; } } } return null; }[/code] and in MP1 we could do: [code]var hueTarget = coreObject.GetTarget(Target.Hue) as AtmoLight.Targets.HueHandler;[/code] And now we could use hueTarget.ChangeGroup("all") fo example. Context Menu in general [USER=17766]@Rick164[/USER]: The context menu starts here: [url]https://github.com/ambilight-4-mediaportal/AtmoLight/blob/master/AtmoLight.MediaPortal1/Plugin.cs#L644[/url] The general layout is: [code] GUIDialogMenu dlg = (GUIDialogMenu)GUIWindowManager.GetWindow((int)GUIWindow.Window.WINDOW_DIALOG_MENU); dlg.Reset(); dlg.SetHeading("AtmoLight"); dlg.Add(new GUIListItem("Item 1")); dlg.Add(new GUIListItem("Item 2")); dlg.Add(new GUIListItem("Item 3")); dlg.SelectedLabel = 0; dlg.DoModal(GUIWindowManager.ActiveWindow); if (dlg.SelectedLabelText == "Item 1") { // do this } ....[/code] So we would need to add a new Item to DialogContextMenu() and when that is selected we would need to make a new GUIDialogMenu that then has all the Hue stuff in it. Either having this generated dynamically with approach 1 or code it into MP1 plugin with approach 2, or you have some other ideas :). [/QUOTE]

Verification