Reply to thread

Message

<blockquote data-quote="Scythe42" data-source="post: 507658" data-attributes="member: 95833">Update:The quick fix seems to work for me. I tested it with a couple of different files. Audio is always perfectly in sync shortly after playback started and stays this way. How many frames are skipped depends on how far it was off in the first place when playback started. Of course you need to adjust for any general processing delay to get audio perfectly spot on. Because of the late frames some frames get dropped every now and then. The reason for the late frames is still unknown (machine is nearly idle). But at least I have an acceptable workaround for now and we can investigate the reason for the late frames in more detail. It's a crude patch but it does its job for now.I also tried it with 60Hz. Same happens. Late frames but because of the higher refresh rate they get presented anyway resulting in speed up segments instead of dropped frames and some judder when this happens. IMHO not better because playback is not smooth either way. The frames shouldn't be late in the first place (especially not at the beginning of playback).So it looks like a general bug, but this needs to be confirmed by others first.[PHP]Index: EVRCustomPresenter.cpp===================================================================--- EVRCustomPresenter.cpp&nbsp; &nbsp; (revision 23545)+++ EVRCustomPresenter.cpp&nbsp; &nbsp; (working copy)@@ -1347,8 +1347,13 @@&nbsp; &nbsp; &nbsp;&nbsp; else&nbsp; &nbsp; &nbsp;&nbsp; {&nbsp; &nbsp; &nbsp; &nbsp;&nbsp; //too late, but present anyway-&nbsp; &nbsp; &nbsp; &nbsp; Log(&quot;frame is too late for %I64d ms, last sleep time %d ms.&quot;, -*pNextSampleTime/10000, msLastSleepTime );-&nbsp; &nbsp; &nbsp; &nbsp; CHECK_HR(PresentSample(pSample), &quot;PresentSample failed&quot;);+&nbsp; &nbsp; &nbsp; &nbsp; //Log(&quot;frame is too late for %I64d ms, last sleep time %d ms.&quot;, -*pNextSampleTime/10000, msLastSleepTime );+&nbsp; &nbsp; &nbsp; &nbsp; //CHECK_HR(PresentSample(pSample), &quot;PresentSample failed&quot;);++&nbsp; &nbsp; &nbsp; &nbsp; //too late, don't present+&nbsp; &nbsp; &nbsp; &nbsp; m_iFramesDropped++;+&nbsp; &nbsp; &nbsp; &nbsp; m_didSkip = true;+&nbsp; &nbsp; &nbsp; &nbsp; Log( &quot;skipping frame, behind %I64d ms, last sleep time %d ms.&quot;, -*pNextSampleTime/10000, msLastSleepTime );&nbsp; &nbsp; &nbsp;&nbsp; }&nbsp; &nbsp;&nbsp; } &nbsp; &nbsp;&nbsp; else [/PHP]In case someone wants to try this, I attached the patched dshowhelper.dll I'm using under MP 1.0.10 Beta right now. If you try this let me know if it fixes similar problems on your end or if it breaks anything else. If you don't have similar problems I suggest you don't try the patched DLL.</blockquote>

[QUOTE="Scythe42, post: 507658, member: 95833"] [B]Update:[/B] The quick fix seems to work for me. I tested it with a couple of different files. Audio is always perfectly in sync shortly after playback started and stays this way. How many frames are skipped depends on how far it was off in the first place when playback started. Of course you need to adjust for any general processing delay to get audio perfectly spot on. Because of the late frames some frames get dropped every now and then. The reason for the late frames is still unknown (machine is nearly idle). But at least I have an acceptable workaround for now and we can investigate the reason for the late frames in more detail. It's a crude patch but it does its job for now. I also tried it with 60Hz. Same happens. Late frames but because of the higher refresh rate they get presented anyway resulting in speed up segments instead of dropped frames and some judder when this happens. IMHO not better because playback is not smooth either way. The frames shouldn't be late in the first place (especially not at the beginning of playback). So it looks like a general bug, but this needs to be confirmed by others first. [PHP]Index: EVRCustomPresenter.cpp =================================================================== --- EVRCustomPresenter.cpp (revision 23545) +++ EVRCustomPresenter.cpp (working copy) @@ -1347,8 +1347,13 @@ else { //too late, but present anyway - Log("frame is too late for %I64d ms, last sleep time %d ms.", -*pNextSampleTime/10000, msLastSleepTime ); - CHECK_HR(PresentSample(pSample), "PresentSample failed"); + //Log("frame is too late for %I64d ms, last sleep time %d ms.", -*pNextSampleTime/10000, msLastSleepTime ); + //CHECK_HR(PresentSample(pSample), "PresentSample failed"); + + //too late, don't present + m_iFramesDropped++; + m_didSkip = true; + Log( "skipping frame, behind %I64d ms, last sleep time %d ms.", -*pNextSampleTime/10000, msLastSleepTime ); } } else [/PHP] In case someone wants to try this, I attached the patched dshowhelper.dll I'm using under MP 1.0.10 Beta right now. If you try this let me know if it fixes similar problems on your end or if it breaks anything else. If you don't have similar problems I suggest you don't try the patched DLL. [/QUOTE]

Verification