AutoCropper plugin (4 Viewers)

[ziphnor]

I dont do left/right cropping. The only channels ive seen having left/right black bars are analogue channels, which can have small black bars, in which case you would just use the fixed cropping (already in MP) since they dont change over time.

I might add it later if there is any real need.

 

[chrholm]

Its looking damn nice. I'm a programmer myself, so if you need someone to help you troubleshoot on another system than your own, let me know.

 

[ziphnor]

That might become relevant in a weeks time, it would be nice to have someone perform the very preliminary tests where the filter is still spewing out MB by MB of log data

I now have the setup form, the filter(minus cleanup) and the necessary actions in MP. I still need to read add the filter if enabled ,pass it the settings, ensure that the reference i store for the filter is removed when the graph it is in is removed and add support for changing filter settings on the fly(so that it can be switched from manual mode to off mode and later also to auto mode).

 

[jawbroken]

You get left and right black bars on 16:9 channels broadcasting 4:3 material. It is the same problem as 4:3 channels broadcasting 16:9 material that you are detecting with the top and bottom testing.

I think left and right cropping would be helpful for people with 4:3 televisions that get 16:9 broadcasts, as 4:3 material could automatically size to their television.

It is up to you though.

 

[ziphnor]

Interesting, ive never seen any channels do that here in denmark,they just broadcast a 4:3 frame. You have many strange things in Australia (though its actually us that are being inconsisten) What happens if you use the zoom mode?

Anyway 4:3 televisions are dying out, especially when we are talking HTPC displays. Still, i have designed to the code to allow for this, the frame analyzer returns a content rectangle, not just top and bottom, and the cropper (frame copy method) also takes as input a rectangle(though it disregards left/right currently), so it wont be a biggie to add later on.

Could you perhaps e-mail me a few small example videos of this? Each only has to be say 10 seconds long. You can just email ziphnor@gmail.com(dont worry it is my spam address

 

[jawbroken]

Perhaps they do broadcast only a 4:3 frame. I don't have a 4:3 television personally, but I just thought if you were already doing top and bottom cropping then left and right wouldn't be too hard to implement and might help some people.

I will try to get some recordings to you tomorrow (nothing on TV at the moment is 4:3, unfortunately).

 

[ziphnor]

Status:
The filter is now added based on the configuration, and is properly cleaned up when no longer needed.

Now i just need to fix a small bug somewhere in my YV12 handling code, add support for changing autocrop settings after the graph starts running and cleanup my filter code(especially the logging). With a little luck ill start using this on my own HTPC some time next week. Shortly thereafter im probably going to get some people to test it with extensive logging enabled before i try to add it to SVN. Of course, no promises, but before christmas shouldnt be a problem

I also need to round this off and go look at teletext subtitle support(just discovered that almost all my channels without embedded subtitles use teletext subs and no DVB subs .

jawbroken:
It will be a bit hard to test if i cant even get a single sample

 

[jawbroken]

Haha, I know.

Sorry, I haven't been able to get around to it yet. Last week of university here in Australia and I have exams starting in a week or two and 5 assignments due this week (3 down, 2 to go). I will try to get something to you when I get the time.

 

[ziphnor]

No rush, i was just pointing out that i would need to see a sample video showing the black bars

 

[ziphnor]

Argh, now i think i know what the problem with YV12 was.

The format is defined as one N x M plane of Y samples, followed by a N/2 x M/2 U plane and ditto V plane. But what happens when N or M are not even?

For now ive decided to ensure that i always crop to even height, but if anyone knows better, please tell me....