Bug in BrowserHost (1 Viewer)

[belcom]

Hi there!

Took me a while to figure it out, but in the end I discovered that there is a bug in BrowserHost.
It only has impact if there is another program with the same bug running.

In my case it was RevitAccelerator.exe from AutoCAD Revit 2017.

Both programs try to listen on "net.pipe://localhost/" (Which to my understanding is quite useless... there should be something unique appended)

So if RevitAccelerator is already running and you try to open something which requires BroserHost, e.g. Netflix, you get a System Exception "Another process is already listening..."

Besides of this,
Thanks for this great plugin!

Best regards,
belcom.

 

[Ministerk]

Hi, I don't know if its a bug or not. I have not written the browser player, but I think OnlineVideos/MP and the BrowserHost process i talking with each other through named pipes (remote control commands and logging messages) hence listening to net.pipe://localhost/ is necessary (or?).

 

[belcom]

I don't know which communication is passed on this pipe, but it should be something like "net.pipe://localhost/mediaportal/BrowserHost/" to make it unique and not to interfere with other things.

 

[morpheus_xx]

I can confirm the usage of different pipes in OV code:

What makes me really wondering are the different URLs registered: while the implementations are using
net.pipe://localhost/
while the server part uses
net.pipe://localhost/WebBrowserPlayerCallbackService

@offbyone @Brownard @Ministerk any ideas?

 

[Ministerk]

I'm only guessing, and I haven't looket at the code and I haven't the possibility to look at it more than in a browser....
But net.pipe://localhost/WebBrowserPlayerCallbackService calls the WebBrowserPlayerCallbackService service endpoint at net.pipe://localhost/.

If we would to construct the Uri (at line 14 in the image above) like new Uri("net.pipe://localhost/BrowserHost/") then the service endpoint would be net.pipe://localhost/BrowserHost/WebBrowserPlayerCallbackService" and the application would listen to net.pipe://localhost/BrowserHost/

Then it should be something like:

new EndpointAddress("net.pipe://localhost/BrowserHost/WebBrowserPlayerCallbackService") //This is a service endpoint address
new EndpointAddress("net.pipe://localhost/BrowserHost/WebBrowserPlayerService")
new Uri("net.pipe://localhost/BrowserHost/") //This is the base Uri where you bind your service endpoint 
new Uri("net.pipe://localhost/BrowserHost/")

 

[belcom]

Sounds good to me

But I would prefer to make it even more unique and "speaking"...
like "net.pipe://localhost/MediaPortal/OnlineVideos/BrowserHost/"

Who is going to put it in Mantis?
I don't have access...

 

[morpheus_xx]

@belcom @Ministerk @Brownard @offbyone

I created a new branch for this change and pushed it to: Commits · offbyoneBB/mp-onlinevideos2 · GitHub

Can you check if this can cause any side effects? If the change is ok and working, I would include it in the MP2.1 final release. So please give it a try to confirm

 

[Ministerk]

Sorry, I cannot test at the moment I have no working dev environment.

 

[offbyone]

I haven't tested this, but it looks fine to me.
Since a 2.3.1 bugfix release is required anyway, I'll merge that one into master.

 

[morpheus_xx]

It's already part of MP2.1 final release, so it should work ok