[fixed] Bug in importing music (1 Viewer)

[mbuzina]

From my Configuration.log (scanned with that) (1.3 Beta):

2013-01-17 11:31:32.310561 [Info.][(7)]: SQLiteClient: MusicDatabaseV12.db3 cmd:sqlite3_prepare16:pvm=null err:ERROR detailed:unrecognized token: "'Blues From Laurel Canyon" query:insert into tracks (
							   strPath, strArtist, strAlbumArtist, strAlbum, strGenre, strComposer, strConductor, strTitle, 
							   iTrack, iNumTracks, iDuration, iYear, iTimesPlayed, iRating, iFavorite, 
							   iResumeAt, iDisc, iNumDisc, strLyrics, strComment, strFileType, strFullCodec, strBitRateMode, 
							   iBPM, iBitRate, iChannels, iSampleRate, dateLastPlayed, dateAdded) 
							   values ( 
							   'd:\Music\John Mayall - Blues From Laurel Canyon - 04 - 2401.flac', '| John Mayall |', '| John Mayall | ', 'Blues From Laurel Canyon ', '| Blues |', '|  | ', '', '2401',
							   4, 0, 227, 1968, 0, 0, 0, 
							   0, 0, 0, '', '',  'flac', 'Flac Audio',  '',  0, 1412, 2, 44100, '0001-01-01 00:00:00', '2013-01-17 11:31:32' )
2013-01-17 11:31:32.322566 [ERROR][(7)]: SQLiteClient: MusicDatabaseV12.db3 cmd:sqlite3_prepare16:pvm=null err:ERROR detailed:unrecognized token: "'Blues From Laurel Canyon" query:insert into tracks (
							   strPath, strArtist, strAlbumArtist, strAlbum, strGenre, strComposer, strConductor, strTitle, 
							   iTrack, iNumTracks, iDuration, iYear, iTimesPlayed, iRating, iFavorite, 
							   iResumeAt, iDisc, iNumDisc, strLyrics, strComment, strFileType, strFullCodec, strBitRateMode, 
							   iBPM, iBitRate, iChannels, iSampleRate, dateLastPlayed, dateAdded) 
							   values ( 
							   'd:\Music\John Mayall - Blues From Laurel Canyon - 04 - 2401.flac', '| John Mayall |', '| John Mayall | ', 'Blues From Laurel Canyon ', '| Blues |', '|  | ', '', '2401',
							   4, 0, 227, 1968, 0, 0, 0, 
							   0, 0, 0, '', '',  'flac', 'Flac Audio',  '',  0, 1412, 2, 44100, '0001-01-01 00:00:00', '2013-01-17 11:31:32' )
2013-01-17 11:31:32.335578 [Info.][(7)]: Insert of song d:\Music\John Mayall - Blues From Laurel Canyon - 04 - 2401.flac failed
2013-01-17 11:31:32.347583 [ERROR][(7)]: Insert of song d:\Music\John Mayall - Blues From Laurel Canyon - 04 - 2401.flac failed

Seems like an issue to me, not sure what is wrong or where the unrecognized token Comes from (maybe the blank after Canyon in the string is not just a blank?).

 

[HomeY]

Just added the file to my music share, scanned dB and got the same error. Then i checked that data for the file, and since i have this single file in a folder, i changed the track # from 4 to 1 and import ran fine on 1.3Beta.


Weird, changed 1 back to 4, renamed, etc. with the file and can't seem to reproduce the error anymore. Deleted the dB several times.

 

[hwahrmann]

At the end of every string, there is a Null character. This is causing the troubles on the insert to the database.
So the tags have been read correctly, it is just that the sql was failing on the insert into the database.
What Tag Editor did you use for tagging your files?

 

[HomeY]

At the end of every string, there is a Null character. This is causing the troubles on the insert to the database.
So the tags have been read correctly, it is just that the sql was failing on the insert into the database.
What Tag Editor did you use for tagging your files?

I used MPTagThat. Does that remove those NULL Characters?
If @Developer58 uses another Tag Editor, that might explain things.

 

[hwahrmann]

Yes MPTagThat removes those Null chars.

 

[Developer58]

I tag my songs with J.River Media Center, for several years now.

I never had any problem with other programs but MePo.

Is the SQL going to be fixed so it strips nulls?
Please keep me posted.

 

[hwahrmann]

Fact is, you've got wrongly formatted tag values.

I'll see what i can do, but can't promise anything, as i'm quite busy at the moment.

 

[Developer58]

I would appreciate that ver much

 

[kiwijunglist]

If appropriate can someone add this to the issue tracker, thanks. @Dadeo

[Music] If metadata tags within flac files contains a null character it causes the import fail.

 

[Dadeo]

Ok added to Mantis - issue 4185 - assigned to hwahrmann - but not set to a Target Release yet. I'll let hwahrmann do that if he gets time to fix it for 1.3.0.