Changed settings do not take effect until MP2-Client is stopped and restarted.

Discussion in 'Submit: Bug Reports' started by Nikki Locke, February 13, 2019.

  1. Nikki Locke
    • Team MediaPortal

    Nikki Locke Development Group

    Joined:
    February 2, 2019
    Messages:
    457
    Likes Received:
    32
    Gender:
    Male
    Ratings:
    +59 / 0
    Home Country:
    United Kingdom United Kingdom
    MediaPortal 2 Version: 2.2

    Description
    I was very confused by this.



    Steps to Reproduce:
    Try changing the

    Settings/Players/General/Player skip steps.

    When you go back to playing a recorded video, the changes have not taken effect.

    Stop the client and restart, and they now work.
     
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. HTPCSourcer
    • Team MediaPortal
    • Administrator

    HTPCSourcer MP2 Product Manager

    Joined:
    May 16, 2008
    Messages:
    10,699
    Likes Received:
    1,118
    Gender:
    Male
    Ratings:
    +2,400 / 22
    Home Country:
    Germany Germany
    Show System Specs
    Indeed, also the video codec changes won't take effect before one restarts the client. A fix for this would be much appreciated. :)
     
  4. morpheus_xx
    • Team MediaPortal

    morpheus_xx Lead Dev MP2

    Joined:
    March 24, 2007
    Messages:
    11,017
    Likes Received:
    4,750
    Ratings:
    +6,796 / 11
    Home Country:
    Germany Germany
    Show System Specs
    There are different things to check:
    • Always to get a new Settings instance from SettingsManager. This is done in ExtendedVideoSkip already for percentage steps. The list of fixed steps is read in constructor of this model
    • Settings are cached, but saving changes updates this cache as well.
    • So the key is the life time of the model, which is created when screen demands it. When new constructed, the new setting is read.
    • An alternative would be a SettingsChangeWatcher that notifies about changes, but IMO it's not worth the overhead of the creation of an MessageQueue (thread!) for this seldom changed option.
     
  5. HTPCSourcer
    • Team MediaPortal
    • Administrator

    HTPCSourcer MP2 Product Manager

    Joined:
    May 16, 2008
    Messages:
    10,699
    Likes Received:
    1,118
    Gender:
    Male
    Ratings:
    +2,400 / 22
    Home Country:
    Germany Germany
    Show System Specs
    I agree and this applies to all settings whose change is not available before the client is restarted. Howeveer, the average user doesn't know which settings are affected, so we would need to add a note in the helper line that changes don't take effect before a restart or even display a pop-up.
     
  6. HTPCSourcer
    • Team MediaPortal
    • Administrator

    HTPCSourcer MP2 Product Manager

    Joined:
    May 16, 2008
    Messages:
    10,699
    Likes Received:
    1,118
    Gender:
    Male
    Ratings:
    +2,400 / 22
    Home Country:
    Germany Germany
    Show System Specs
    It appears that the only place where settings don't take an immediate effect is the "Player" section with the "General" and "Codecs" part.
     
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!