[will not fix] Changed settings do not take effect until MP2-Client is stopped and restarted.

Nikki Locke

Development Group
  • Team MediaPortal
  • February 2, 2019
    457
    28
    68
    Country flag


    MediaPortal 2 Version: 2.2

    Description
    I was very confused by this.

    Steps to Reproduce:
    Try changing the

    Settings/Players/General/Player skip steps.

    When you go back to playing a recorded video, the changes have not taken effect.

    Stop the client and restart, and they now work.
     

    HTPCSourcer

    MP2 Product Manager
  • Team MediaPortal
  • Administrator
  • May 16, 2008
    11,265
    113
    Country flag
    Indeed, also the video codec changes won't take effect before one restarts the client. A fix for this would be much appreciated. :)
     

    morpheus_xx

    Lead Dev MP2
  • Team MediaPortal
  • March 24, 2007
    11,180
    113
    Country flag
    There are different things to check:
    • Always to get a new Settings instance from SettingsManager. This is done in ExtendedVideoSkip already for percentage steps. The list of fixed steps is read in constructor of this model
    • Settings are cached, but saving changes updates this cache as well.
    • So the key is the life time of the model, which is created when screen demands it. When new constructed, the new setting is read.
    • An alternative would be a SettingsChangeWatcher that notifies about changes, but IMO it's not worth the overhead of the creation of an MessageQueue (thread!) for this seldom changed option.
     

    HTPCSourcer

    MP2 Product Manager
  • Team MediaPortal
  • Administrator
  • May 16, 2008
    11,265
    113
    Country flag
    IMO it's not worth the overhead
    I agree and this applies to all settings whose change is not available before the client is restarted. Howeveer, the average user doesn't know which settings are affected, so we would need to add a note in the helper line that changes don't take effect before a restart or even display a pop-up.
     

    HTPCSourcer

    MP2 Product Manager
  • Team MediaPortal
  • Administrator
  • May 16, 2008
    11,265
    113
    Country flag
    It appears that the only place where settings don't take an immediate effect is the "Player" section with the "General" and "Codecs" part.
     
    Top Bottom