[will not fix] Changed settings do not take effect until MP2-Client is stopped and restarted. (1 Viewer)

Nikki Locke

Portal Pro
February 2, 2019
459
59
68
United Kingdom United Kingdom
Country flag
MediaPortal 2 Version: 2.2

Description
I was very confused by this.

Steps to Reproduce:
Try changing the

Settings/Players/General/Player skip steps.

When you go back to playing a recorded video, the changes have not taken effect.

Stop the client and restart, and they now work.
 

HTPCSourcer

Retired Team Member
  • Premium Supporter
  • May 16, 2008
    11,431
    2,334
    Germany Germany
    Country flag
    Indeed, also the video codec changes won't take effect before one restarts the client. A fix for this would be much appreciated. :)
     

    morpheus_xx

    Lead Dev MP2
  • Team MediaPortal
  • March 24, 2007
    11,602
    7,060
    Germany Germany
    Country flag
    There are different things to check:
    • Always to get a new Settings instance from SettingsManager. This is done in ExtendedVideoSkip already for percentage steps. The list of fixed steps is read in constructor of this model
    • Settings are cached, but saving changes updates this cache as well.
    • So the key is the life time of the model, which is created when screen demands it. When new constructed, the new setting is read.
    • An alternative would be a SettingsChangeWatcher that notifies about changes, but IMO it's not worth the overhead of the creation of an MessageQueue (thread!) for this seldom changed option.
     

    HTPCSourcer

    Retired Team Member
  • Premium Supporter
  • May 16, 2008
    11,431
    2,334
    Germany Germany
    Country flag
    IMO it's not worth the overhead
    I agree and this applies to all settings whose change is not available before the client is restarted. Howeveer, the average user doesn't know which settings are affected, so we would need to add a note in the helper line that changes don't take effect before a restart or even display a pop-up.
     

    HTPCSourcer

    Retired Team Member
  • Premium Supporter
  • May 16, 2008
    11,431
    2,334
    Germany Germany
    Country flag
    It appears that the only place where settings don't take an immediate effect is the "Player" section with the "General" and "Codecs" part.
     

    Users who are viewing this thread

    Similar threads
    OP Title Forum Replies Date
    T Change tv subtitle in MediaPortal 1.26 Newcomers Forum 8
    T Change tv subtitle in MediaPortal 1.26 MediaPortal 1 Talk 0
    G Changing from MySQL to MariaDB MediaPortal 1 Talk 38
    Lehmden TVDB will change into a payed service in 2021 OffTopic 2
    toricred MP2 - V2.3 Client Dying When Changing Channels ATSC Submit: Bug Reports 1
    E 1.25.0 Change AVC / AAC Codec for Analog card captured videos Codecs, External Players 0
    C 1.25.0 mini Splashscreen - how can i change it MediaPortal 1 Skins 9
    toricred Recordings Change : to _ in Series Name General 0
    A UK Freeview channel changes Installation, configuration support 14
    T Client / Server slow channel-to-channel change (zapping) General Support 1
    framug [solved] Some changes/fix in MP1 configuration client and server Submit: code patches (MediaPortal/TV-Server/etc.) 14
    catavolt [WiP] When changing theme in my skins, I always get this error message in logs MediaPortal 1 9
    azzuro [WiP] MP1-4999 - Big changes with many related change at once by Sebastiii MediaPortal 1 22
    J How to change y position of subtitles General 3
    D [solved] Changed username in Win10, now TV Server config crashes on fresh install Installation, configuration support 1
    M Change size of the splash screen Skins and Plugins Installer (MPEI) 2
    S Remote button to change audio and subtitle on / off General 10
    BenGonGon chaine qui change aléatoirement Support Général 2
    R [solved] Command / Shortcut for changing subtitles or audio Archive 5
    ge2301 New forum design together with change to XF2.x Online Facilities 4
    doskabouter [Evaluate] Changing SecurityProtocol Developer Discussions 1
    O [Help Me!] How to change 'release' status in Jira? Developer Discussions 9
    cbr954rr [fixed] Movie db refresh on changes of nfo and correct spelling of words in titles 2.2 Archive 33
    KlausWirn Music crash Bass crash no change to play music Installation, configuration support 2
    F Somethings changed - mce remote General Support 9

    Similar threads

    Top Bottom