Changing Themes Can Cause Mediaportal to black out 2/3rd's of screen (1 Viewer)

kiwijunglist

Super Moderator
  • Team MediaPortal
  • June 10, 2008
    6,746
    1,751
    New Zealand
    Home Country
    New Zealand New Zealand
    haha, but we are talking about a theme :)
     

    elliottmc

    Retired Team Member
  • Premium Supporter
  • August 7, 2005
    14,927
    6,061
    Cardiff, UK
    Home Country
    United Kingdom United Kingdom
    haha, but we are talking about a theme :)

    Yes, but the skin overall cannot work with 1.3 and 1.4, so the theme cannot.

    In principle, if the theme only changes a few things, and doesn't include any files with toggleButton/checkButton then it could work with both. I guess in that case you could distribute different versions of the skin theme.

    However, looking at your theme, I think the chance of a single installer working for 1.3 and 1.4 is very remote.
     

    kiwijunglist

    Super Moderator
  • Team MediaPortal
  • June 10, 2008
    6,746
    1,751
    New Zealand
    Home Country
    New Zealand New Zealand
    Offtopic: I see what you mean, however I don't create any new code that uses toggle or checkbutton so my theme installs correctly for both versions of MP...
    if you have 1.3 it uses togglebutton if you have 1.4 it uses checkbutton :)

    Still I don't know what has causes this halfscreen problem, however I have been able to modify my theme so it doesn't trigger the issue anymore.
     

    elliottmc

    Retired Team Member
  • Premium Supporter
  • August 7, 2005
    14,927
    6,061
    Cardiff, UK
    Home Country
    United Kingdom United Kingdom
    Offtopic: I see what you mean, however I don't create any new code that uses toggle or checkbutton so my theme installs correctly for both versions of MP...
    if you have 1.3 it uses togglebutton if you have 1.4 it uses checkbutton :)

    Still I don't know what has causes this halfscreen problem, however I have been able to modify my theme so it doesn't trigger the issue anymore.


    But you have copies of the existing skin files with the colours changed. If you have ones that are compatible with 1.3.0, they will have togglebutton in them, so they won't work with 1.4.0. If you have the ones with toggleButton removed, then some buttons where the code in 1.3.0 explicitly expects a toggleButton, then it won't work with 1.3.0.
     

    kiwijunglist

    Super Moderator
  • Team MediaPortal
  • June 10, 2008
    6,746
    1,751
    New Zealand
    Home Country
    New Zealand New Zealand
    I don't have any copies,

    I just use what ever already exists in the user's Titan folder, which is already appropriate for the MP version that they are running[DOUBLEPOST=1370167148][/DOUBLEPOST]Advantage is that I don't have to update my theme if Titan get's updated, and if the user has any of their own tweaks in the titan main folder they get incorporated into my theme :)
     

    elliottmc

    Retired Team Member
  • Premium Supporter
  • August 7, 2005
    14,927
    6,061
    Cardiff, UK
    Home Country
    United Kingdom United Kingdom
    I don't have any copies,

    I just use what ever already exists in the user's Titan folder, which is already appropriate for the MP version that they are running[DOUBLEPOST=1370167148][/DOUBLEPOST]Advantage is that I don't have to update my theme if Titan get's updated, and if the user has any of their own tweaks in the titan main folder they get incorporated into my theme :)

    So you mean your installer makes copies/changes to the files from what is already on the user's system?
     

    kiwijunglist

    Super Moderator
  • Team MediaPortal
  • June 10, 2008
    6,746
    1,751
    New Zealand
    Home Country
    New Zealand New Zealand
    My installer copies all the titan's xml files to a temp location
    then changes the colour codes in all the files
    discards any xml files that don't have colour codes *
    creates a new theme folder
    copies the modified xml files into the theme folder
    copies my own images into the theme folder
    copies a couple of additional xml files that i made into the theme folder
    deletes skin cache

    ---

    * new installer only, which fixes the half screen bug.
     

    elliottmc

    Retired Team Member
  • Premium Supporter
  • August 7, 2005
    14,927
    6,061
    Cardiff, UK
    Home Country
    United Kingdom United Kingdom
    so yeah that's why it's compatible with 1.3 AND 1.4

    Yeah, obviously something is triggering the problem, since I cannot reproduce it unless I have installed your theme.
     

    kiwijunglist

    Super Moderator
  • Team MediaPortal
  • June 10, 2008
    6,746
    1,751
    New Zealand
    Home Country
    New Zealand New Zealand
    Yeah and using install buggy theme.bat (attached on first page) you can show it can be trigged by the original titan xml files merely existing in the theme folder, I just don't know which one(s).
     
    Last edited:

    Users who are viewing this thread

    Top Bottom