[Pending] - Comskip Live Support

Discussion in 'Submit: code patches (MediaPortal/TV-Server/etc.)' started by twemperor, April 11, 2011.

  1. twemperor
    • Premium Supporter

    twemperor MP Donator

    Joined:
    March 10, 2010
    Messages:
    103
    Likes Received:
    22
    Ratings:
    +31 / 0
    Home Country:
    United States of America United States of America
    Show System Specs
    The existing Comskip support is great- except that there is no support for recordings that are still in progress. The attached patch fixes this by identifying when Comskip is still in the process of identifying chapters. Until Comskip is finished, the progress is checked and newly identified chapters are added to the list.


     

    Attached Files:

    • Like Like x 6
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. disaster123
    • Premium Supporter

    disaster123 MP Donator

    Joined:
    May 14, 2008
    Messages:
    3,546
    Likes Received:
    417
    Ratings:
    +431 / 2
    Home Country:
    Germany Germany
    AW: Comskip Live Support

    that's cool thanks!
     
  4. tourettes
    • Premium Supporter

    tourettes Retired Team Member

    Joined:
    January 7, 2005
    Messages:
    17,301
    Likes Received:
    4,595
    Ratings:
    +4,810 / 3
    Please provide a patch that can be used on top of the current SVN revision. Patch was based on 27641 and the current one is 27787. Seems that the patch is not compatible anymore with the latest changes in SVN.

    I did have a quick look (althou it was hard since I couldn't patch the local MP copy) - looks like you are using file read & access operations inside Process()? This should be avoided at any cost since it could cause severe video playback quality issues. It would be advisable to do the file operations (and as much other operations as possible) in a low priority worker thread. Process() gets called in MP main thread which is used for the video and GUI rendering.
     
  5. twemperor
    • Premium Supporter

    twemperor MP Donator

    Joined:
    March 10, 2010
    Messages:
    103
    Likes Received:
    22
    Ratings:
    +31 / 0
    Home Country:
    United States of America United States of America
    Show System Specs
    I wasn't sure about the protocol for creating a patch- I will work on submitting a patch to a later SVN.

    I've been running with this for a while, as I was similarly concerned about any file access during video processing, and I haven't noticed any issues on my system. That being said, I appreciate your suggestion. Is there already a low priority worker thread that can be reused? I don't see one, but there's a lot of code in the core.
     
  6. tourettes
    • Premium Supporter

    tourettes Retired Team Member

    Joined:
    January 7, 2005
    Messages:
    17,301
    Likes Received:
    4,595
    Ratings:
    +4,810 / 3
    Here's a quick check list that can be used: Patch Policy - MediaPortal Wiki

    I don't there is currently any suitable worker thread for such job existing (currently existing ones are much likely pretty specific ones like last.fm submit thread etc.). It is fairly trivial to create a new thread, just remember to put the actual thread method inside try & catch so it wont be crashing MP directly to the desktop if something throws an exception in the worker code (file not found for example).
     
  7. arion_p
    • Premium Supporter

    arion_p Retired Team Member

    Joined:
    February 7, 2007
    Messages:
    3,352
    Likes Received:
    1,447
    Occupation:
    Developer
    Location:
    Athens
    Ratings:
    +1,522 / 0
    Home Country:
    Greece Greece
    Show System Specs
    It seems to me that this only works for single-seat. There is no provision for multi-seat.
     
  8. twemperor
    • Premium Supporter

    twemperor MP Donator

    Joined:
    March 10, 2010
    Messages:
    103
    Likes Received:
    22
    Ratings:
    +31 / 0
    Home Country:
    United States of America United States of America
    Show System Specs
    In general, the support for reading ComSkip generated chapter files was limited to single-seat, or multi-seat if RTSP is not used. Personally, I have this patch working multi-seat with normal network shared files, not RTSP.
     
  9. arion_p
    • Premium Supporter

    arion_p Retired Team Member

    Joined:
    February 7, 2007
    Messages:
    3,352
    Likes Received:
    1,447
    Occupation:
    Developer
    Location:
    Athens
    Ratings:
    +1,522 / 0
    Home Country:
    Greece Greece
    Show System Specs
  10. twemperor
    • Premium Supporter

    twemperor MP Donator

    Joined:
    March 10, 2010
    Messages:
    103
    Likes Received:
    22
    Ratings:
    +31 / 0
    Home Country:
    United States of America United States of America
    Show System Specs
    That's great! I had originally worked against 1.1.2, but there are a lot of changes in 1.2 so far in chapter handling. I started merging last night, and I'll work in the other feedback from this thread.
     
    • Like Like x 2
  11. disaster123
    • Premium Supporter

    disaster123 MP Donator

    Joined:
    May 14, 2008
    Messages:
    3,546
    Likes Received:
    417
    Ratings:
    +431 / 2
    Home Country:
    Germany Germany
    AW: Comskip Live Support

    Any news on this?
     
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!