home
products
contribute
download
documentation
forum
Home
Forums
New posts
Search forums
What's new
New posts
All posts
Latest activity
Members
Registered members
Current visitors
Donate
Log in
Register
What's new
Search
Search
Search titles only
By:
New posts
Search forums
Search titles only
By:
Menu
Log in
Register
Navigation
Install the app
Install
More options
Contact us
Close Menu
Forums
MediaPortal 1
MediaPortal 1 Plugins
Popular Plugins
OnlineVideos
Das Erste: Livestream not working
Contact us
RSS
JavaScript is disabled. For a better experience, please enable JavaScript in your browser before proceeding.
You are using an out of date browser. It may not display this or other websites correctly.
You should upgrade or use an
alternative browser
.
Reply to thread
Message
<blockquote data-quote="doskabouter" data-source="post: 1245442" data-attributes="member: 98267"><p>Ok, it seems I have a lot to learn to review a pull request. (Couldn't get it to merge in my local source using tortoisegit to get a bit of an overview)</p><p></p><p>3 remarks/questions:</p><p>- May I point you to the HlsPlaylistParser class? That may save you a lot of code (or maybe not, didn't do an in-depth analysis)</p><p>- That change in onlinevideos, couldn't that throw unwanted exceptions?</p><p>- Either way, until a new version of onlinevideos is released, I think it's better to put that part in the util itself, so everyone can benefit without having to manually copy files and such</p></blockquote><p></p>
[QUOTE="doskabouter, post: 1245442, member: 98267"] Ok, it seems I have a lot to learn to review a pull request. (Couldn't get it to merge in my local source using tortoisegit to get a bit of an overview) 3 remarks/questions: - May I point you to the HlsPlaylistParser class? That may save you a lot of code (or maybe not, didn't do an in-depth analysis) - That change in onlinevideos, couldn't that throw unwanted exceptions? - Either way, until a new version of onlinevideos is released, I think it's better to put that part in the util itself, so everyone can benefit without having to manually copy files and such [/QUOTE]
Insert quotes…
Verification
Post reply
Forums
MediaPortal 1
MediaPortal 1 Plugins
Popular Plugins
OnlineVideos
Das Erste: Livestream not working
Contact us
RSS
Top
Bottom