Reply to thread

Message

<blockquote data-quote="SilentBob" data-source="post: 1245492" data-attributes="member: 109674">That's a good hint, i just wanted to fix the mediathek streams and did not look larger around. so my first intention was to quick fix it, and most of the code was already there from offbyone. In a next step i would have provided such a playlist parser as well, but good to see there is already one. Just a question: Is it by intention that only one stream is returned per streamname (e.g. if there are Urls for same size and bitrate, only one is returned)&nbsp;You asked me to provide the code as fast as possible <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite2" alt=";)" title="Wink&nbsp; &nbsp; ;)" loading="lazy" data-shortname=";)" /> I can update the pull request or create another one, as i would like to do some clenaups as well.not more than already in. i changed the last fallback which already today returns default(T), default(T) means in most cases: nullThese are the default values for the more important types inside of CLR,<ul>
<li data-xf-list-type="ul">Classes - null</li>
<li data-xf-list-type="ul">Nullable&lt;T&gt; - null</li>
<li data-xf-list-type="ul">Numerics structs (int, double, decimal, etc) - 0</li>
<li data-xf-list-type="ul">DateTime structs - 01/01/0001.</li>
<li data-xf-list-type="ul">Char structs&nbsp; &nbsp; - empty char.</li>
<li data-xf-list-type="ul">Bool structs - false</li>
</ul>The Convert call does not throw an exception it tries to convert, if possible you get your type if not null... so similar to todays implementationI did not got this point, maybe you could give an example, or mark the code in pullrequest comment.For me this pull request is just one fix of the mediathek(s) as I saw other issues as well. I would like to refactor some code and consolidate some communalties of the ard, zdf and wdr mediathek code</blockquote>

[QUOTE="SilentBob, post: 1245492, member: 109674"] That's a good hint, i just wanted to fix the mediathek streams and did not look larger around. so my first intention was to quick fix it, and most of the code was already there from offbyone. In a next step i would have provided such a playlist parser as well, but good to see there is already one. Just a question: Is it by intention that only one stream is returned per streamname (e.g. if there are Urls for same size and bitrate, only one is returned) You asked me to provide the code as fast as possible ;) I can update the pull request or create another one, as i would like to do some clenaups as well. not more than already in. i changed the last fallback which already today returns default(T), default(T) means in most cases: null These are the default values for the more important types inside of [I]CLR,[/I] [LIST] [*]Classes - null [*]Nullable<T> - null [*]Numerics structs (int, double, decimal, etc) - 0 [*]DateTime structs - 01/01/0001. [*]Char structs - empty char. [*]Bool structs - false [/LIST] The Convert call does not throw an exception it tries to convert, if possible you get your type if not null... so similar to todays implementation I did not got this point, maybe you could give an example, or mark the code in pullrequest comment. For me this pull request is just one fix of the mediathek(s) as I saw other issues as well. I would like to refactor some code and consolidate some communalties of the ard, zdf and wdr mediathek code [/QUOTE]

Verification