Reply to thread

Message

<blockquote data-quote="offbyone" data-source="post: 1111643" data-attributes="member: 73415">Hadn't pushed my local branch yet, as it still needs some changes (the question of how to configure).Here is the wip now:<a href="https://github.com/MediaPortal/MediaPortal-2/tree/FEAT_Subtitles_in_VideoPlayer" target="_blank">https://github.com/MediaPortal/MediaPortal-2/tree/FEAT_Subtitles_in_VideoPlayer</a>I am not sure about the generic autoload filter. Subtitles is a unique topic and I'd like to have it explicitly handled UI and implementation wise. With my branch we would supply a specific subtitle filter with MP2 and use it by default. We can still make a config option to not use it <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite2" alt=";)" title="Wink&nbsp; &nbsp; ;)" loading="lazy" data-shortname=";)" /> but there will be more config options once we decide to include it <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite2" alt=";)" title="Wink&nbsp; &nbsp; ;)" loading="lazy" data-shortname=";)" />One open thing is the problem of loading external subtitle files names like the playing file. Since the only thing the player gets is one MediaItem, I guess we would need a way to find files next to it or import them to start with as subtitle aspect?</blockquote>

[QUOTE="offbyone, post: 1111643, member: 73415"] Hadn't pushed my local branch yet, as it still needs some changes (the question of how to configure). Here is the wip now: [url]https://github.com/MediaPortal/MediaPortal-2/tree/FEAT_Subtitles_in_VideoPlayer[/url] I am not sure about the generic autoload filter. Subtitles is a unique topic and I'd like to have it explicitly handled UI and implementation wise. With my branch we would supply a specific subtitle filter with MP2 and use it by default. We can still make a config option to not use it ;) but there will be more config options once we decide to include it ;) One open thing is the problem of loading external subtitle files names like the playing file. Since the only thing the player gets is one MediaItem, I guess we would need a way to find files next to it or import them to start with as subtitle aspect? [/QUOTE]

Verification