Discussion: Find and Download Subtitles (1 Viewer)

offbyone

Development Group
  • Team MediaPortal
  • April 26, 2008
    3,981
    3,703
    Stuttgart
    Germany Germany
    Country flag
    • Thread starter
    • Moderator
    • #1
    I'm missing the functionality to search subtitles for a movie or tv series in MP2.

    In MP1 there is SubCentral which uses the SubtitleDownloader library. When you select a menu entry "subtitles", a new window shows where subs for the previously selected item are searched. You can then select a result and save it next to the file, so when playing it now shows those subs.

    How can we easily incorporate this in MP2?
    As a start I suggest we make a NuGet package for the SubtitleDownloader dll.
    Then we need to be able to invoke a search from within the GUI and select a result. How could we best solve this for MP2? Do we include this functionality into the core or make a plugin for it? Can the plugin extend the menu for specific MediaItems (Tv Serie Episode, Movie)?

    There's not much to code, because most is already solved with the SubtitleDownloader (thx to @seco), all we need to make it work in MP2 are a few configuration options, new menu entries, and a new dialog to select results. But the added benefit would be great imho. I am willing to do the coding, if we can agree on the best course to take ;)
     

    MJGraf

    Retired Team Member
  • Premium Supporter
  • January 13, 2006
    2,475
    1,385
    Country flag
    I don't use any subtitles - but I'm a big fan of the plugin solution. That's what our plugin system is for :D
     

    morpheus_xx

    Lead Dev MP2
  • Team MediaPortal
  • March 24, 2007
    11,400
    6,972
    Germany Germany
    Country flag
    I think we should add an extension interface for player menu (like we did for program actions in tv).
    There we could place into all actions, downloading subtitles could be one of them. But it's only one part. The other would be to extend video player with proper support for subtitles and we probably even need to rebuild graph once subs get available.
     

    offbyone

    Development Group
  • Team MediaPortal
  • April 26, 2008
    3,981
    3,703
    Stuttgart
    Germany Germany
    Country flag
    • Thread starter
    • Moderator
    • #4
    Whoops, I didn't even realize MP2 does not support subtitles yet :( This mean we have to take on step back and start with support for displaying subtitles! I think many people use or are forced to use subtitles because their countries do not synchronize (or do it badly).
    (e.g. I watch all English movies in English with english subs to read the words when I don't understand their slang)

    @morpheus_xx : Is there any code in MP2 already present that concerns subtitles or are we at step 0?
    @Sebastiii : IIRC you worked on subtitles in MP1. Can you summarize for me what MP1 does to display subtitles? What dshow filters are involved? How and What displays (or mixes?) the subs into the players image?
     

    morpheus_xx

    Lead Dev MP2
  • Team MediaPortal
  • March 24, 2007
    11,400
    6,972
    Germany Germany
    Country flag
    We already support subtitles for different sources:
    • DirectShow decoder filters that support subtitles (ffdshow), using the IAMStreamSelect interface
    • DVD subtitles
    • DVB subtitles for TV/Recordings
    • Auto-loading DirectShow filters that provide IAMStreamSelect interface (like DirectVobSub)
    What we don't support is manuall adding of DirectShow filters into graph or manual rendering of subtitles into video frame (except the list above)
     

    offbyone

    Development Group
  • Team MediaPortal
  • April 26, 2008
    3,981
    3,703
    Stuttgart
    Germany Germany
    Country flag
    • Thread starter
    • Moderator
    • #6
    DirectShow decoder filters that support subtitles (ffdshow), using the IAMStreamSelect interface
    Am I right in the assumption that this only works because ffdshow filter itself will render the subs into the picture?
    Because I just tried a mkv with embedded subtitles (splitter is LAV) and I can select the subtitle streams, but see nothing in the picture.
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,434
    10,256
    France
    France France
    Country flag
    Whoops, I didn't even realize MP2 does not support subtitles yet :( This mean we have to take on step back and start with support for displaying subtitles! I think many people use or are forced to use subtitles because their countries do not synchronize (or do it badly).
    (e.g. I watch all English movies in English with english subs to read the words when I don't understand their slang)

    @morpheus_xx : Is there any code in MP2 already present that concerns subtitles or are we at step 0?
    @Sebastiii : IIRC you worked on subtitles in MP1. Can you summarize for me what MP1 does to display subtitles? What dshow filters are involved? How and What displays (or mixes?) the subs into the players image?
    Hi :)

    Yep MP1 handle ffdshow / directvobsub and mpc-hc engine but it could be nice if MP2 can use light and better version 'xy-VSFilter Project (High Performance VSFilter Compatible Subtitle Filters)' :
    http://forum.doom9.org/showthread.php?t=168282

    The most of the work for mpc-hc engine sub was done from @cpp2005 :) I only update source against recent version but it seems that subtitle are added over the EVR renderer or over the video decoder. In fact i'm not really an expert lol
     

    morpheus_xx

    Lead Dev MP2
  • Team MediaPortal
  • March 24, 2007
    11,400
    6,972
    Germany Germany
    Country flag
    Good idea. I don't want to include foreign source codes into MP2 repository, so NuGet is preferred
     

    offbyone

    Development Group
  • Team MediaPortal
  • April 26, 2008
    3,981
    3,703
    Stuttgart
    Germany Germany
    Country flag
    • Thread starter
    • Moderator
    • #10
    Alright:
    NuGet Package created and added to our feed.
    Now simply loading the filter from dll and adding it to the graph before rendering all pins already shows subtitles embedded in mkv in MP2 :)

    I guess now we have to find a good place where to add the code that adds the subtitle filter.
    Currently I chose: to override AddSourceFilter in theVideoPlayer and first add the subtitle filter then call the base implementation.
     

    Users Who Are Viewing This Thread (Users: 0, Guests: 1)

    OP Similar threads Forum Replies Date
    M General TVE 3.5 VS2019 - build discussion TV Engine 50
    ge2301 Discussion Thread Nereus 11
    ge2301 MP2.2 Pre-Release Discussions General 28
    C Telenet analog-to-digital switch -- manually finding and inputting DVB-C channels in Mediaportal2 General 0
    W Not finding/matching new series - thetvdb issue? My TVSeries 3
    morpheus_xx [Help Me!] Where can I find source code for MPUrlSourceSplitter? Developer Discussions 3
    F [solved] Could not find the MediaPortal.Common.Logging.ILogger service after upgrading from 2.2.2 to 2.2.3 General 2
    joecrow [solved] Can't find Series (Animals with Cameras) My TVSeries 4
    Jean-Christophe MP 2.2 - Where can I find Movies NOT imported (and why??) ? General 13
    Terra [solved] MP TV Server cannot find any channels anymore, DVB viewer works Installation, configuration support 8
    N [fixed] Where do I find radio programmes I have recorded MediaPortal 2 1
    P Mediaportal 2 client can't find TV server General 3
    O [solved] Cannot find TV DVB-T2 channels (TBS-6281SE) Newcomers Forum 7
    D Downloading EPG XML file: Installation, configuration support 0
    vuego themoviedb.org - Covers downloaded in the wrong language Moving Pictures 8
    horned_reaper [solved] When playing music Fanart does not appear immediately after downloading Fanart Handler 272
    caveman [solved] Cannot download new version My TVSeries 5
    D [solved] Movie artwork download stopped working Submit: Bug Reports 9
    S myemulators kein download mehr Plugins & Erweiterungen 0
    Mainhattan Olli [solved] Download MP 2.2.3 Allgemeines Support- und Diskussionsforum 3
    F EPG Buddy download Plugins & Erweiterungen 1
    high [Evaluate] MP Extension Manager can't download HTTPS links MediaPortal 1 38
    S Tote Download Links bei den Plugins Plugins & Erweiterungen 3
    N Skins to download separately MediaPortal 1 Talk 5
    G Splash screen option pack does not download. StreamedMP 8
    Similar threads

























    Top Bottom