Reply to thread

Message

<blockquote data-quote="offbyone" data-source="post: 1152918" data-attributes="member: 73415">(Currently on vacation, so a short answer must suffice).The DotNetStreamSource filter was build to take a single stream as source without knowing where this comes from (file, network, i-net, .iso, chained resource provider,...). In result this means external subtitle files are not seen by it - it gets a System.IO.Stream.What do subtitle filters with the ability for external files in the graph do? They ask the source filter for the full file path and then use their pattern to check for .sub or .srt or so. This is done then with direct file system access by the subtitle filter. When our filter is asked for the source file path - I can't remember what is returned, but most likely null <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite2" alt=";)" title="Wink&nbsp; &nbsp; ;)" loading="lazy" data-shortname=";)" /> If you check page 3 of this thread - you can see that this problem is already &quot;known&quot; - MP2 does not support external subs yet - and we need to think about how to support external files. The xySubFilters interfaces are also on that page - IIRC it has an interface to manually load a subtitle file - this also means we need a way inside MP2 to find those files when something is played, e.g. a C# implementation to request related files for a resource, merge those with the list of embedded subtitle streams and present to the user, so when you select one, we can manually load the file (might need to be mounted via Dokan - but better if we could use a stream here as well to keep away from the Dokan dependency).I can't remember if we concluded that this filter breaks dxva. But if we plan to use it, it also has interfaces to get the rendered sub as image so we can mix it in the mp2 UI as overlay? But that's already a new topic.</blockquote>

[QUOTE="offbyone, post: 1152918, member: 73415"] (Currently on vacation, so a short answer must suffice). The DotNetStreamSource filter was build to take a [B]single[/B] stream as source without knowing where this comes from (file, network, i-net, .iso, chained resource provider,...). In result this means external subtitle files are not seen by it - it gets a System.IO.Stream. What do subtitle filters with the ability for external files in the graph do? They ask the source filter for the full file path and then use their pattern to check for .sub or .srt or so. This is done then with direct file system access by the subtitle filter. When our filter is asked for the source file path - I can't remember what is returned, but most likely null ;) If you check page 3 of this thread - you can see that this problem is already "known" - MP2 does not support external subs yet - and we need to think about how to support external files. The xySubFilters interfaces are also on that page - IIRC it has an interface to manually load a subtitle file - this also means we need a way inside MP2 to find those files when something is played, e.g. a C# implementation to request related files for a resource, merge those with the list of embedded subtitle streams and present to the user, so when you select one, we can manually load the file (might need to be mounted via Dokan - but better if we could use a stream here as well to keep away from the Dokan dependency). I can't remember if we concluded that this filter breaks dxva. But if we plan to use it, it also has interfaces to get the rendered sub as image so we can mix it in the mp2 UI as overlay? But that's already a new topic. [/QUOTE]

Verification