Reply to thread

Message

<blockquote data-quote="Vasilich" data-source="post: 1038809" data-attributes="member: 97516">i can say how it works in stock MP:&nbsp; 1. in one place, TvCardDvbBase, czech language will be checked and forced to use ISO 6937, ignoring encoding flags:[CODE=c#]if (language.ToUpperInvariant() == &quot;CZE&quot; || language.ToUpperInvariant() == &quot;CES&quot;)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; title = Iso6937ToUnicode.Convert(ptrTitle);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; description = Iso6937ToUnicode.Convert(ptrDesc);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }[/CODE]2. at another place, in DvbTextConverter, current locale will be checked for czech (again!) and russian/belorussian/ukrainian, for both cases forcing predefined encoding if no encoding flag found in text (and, thus, ISO 6937 should be used):[CODE=c#]&nbsp; &nbsp; &nbsp; &nbsp; lang = lang.ToLowerInvariant();&nbsp; &nbsp; &nbsp; &nbsp; if (lang == &quot;cze&quot; || lang == &quot;ces&quot;)&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; encoding = 20269; //ISO-6937&nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; else if (lang == &quot;ukr&quot; || lang == &quot;bel&quot; || lang == &quot;rus&quot;)&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; encoding = 28595; //ISO-8859-5&nbsp; &nbsp; &nbsp; &nbsp; }[/CODE]What currently absents in stock MP is the proper (i.e. according to specs) handling of empty encoding flags. &nbsp; Specs tell that if no encoding byte specified - then use superset of ISO 6937.&nbsp; MP, if encoding byte isn't there, takes default for TVService user ANSI codepage : [CODE=c#]encoding = CultureInfo.CurrentCulture.TextInfo.ANSICodePage;[/CODE]MP approach can work better for providers that don't follow DVB specs, and can result in wrong encoding for those broadcasters that use correct default encoding ISO 6937 (e.g. UPC Direct).I have one idea: when no encoding specified, i can first check if given string has 6937 encoding. I will check if there are any non-specified in 6937&nbsp; symbols or symbol combinations present in given string, and if yes - then we have bad provider, and try to take second option - convert it according to current ANSI codepage. Seems correct?</blockquote>

[QUOTE="Vasilich, post: 1038809, member: 97516"] i can say how it works in stock MP: 1. in one place, TvCardDvbBase, czech language will be checked and forced to use ISO 6937, ignoring encoding flags: [CODE=c#]if (language.ToUpperInvariant() == "CZE" || language.ToUpperInvariant() == "CES") { title = Iso6937ToUnicode.Convert(ptrTitle); description = Iso6937ToUnicode.Convert(ptrDesc); }[/CODE] 2. at another place, in DvbTextConverter, current locale will be checked for czech (again!) and russian/belorussian/ukrainian, for both cases forcing predefined encoding if no encoding flag found in text (and, thus, ISO 6937 should be used): [CODE=c#] lang = lang.ToLowerInvariant(); if (lang == "cze" || lang == "ces") { encoding = 20269; //ISO-6937 } else if (lang == "ukr" || lang == "bel" || lang == "rus") { encoding = 28595; //ISO-8859-5 }[/CODE] What currently absents in stock MP is the proper (i.e. according to specs) handling of empty encoding flags. Specs tell that if no encoding byte specified - then use superset of ISO 6937. MP, if encoding byte isn't there, takes default for TVService user ANSI codepage : [CODE=c#]encoding = CultureInfo.CurrentCulture.TextInfo.ANSICodePage;[/CODE] MP approach can work better for providers that don't follow DVB specs, and can result in wrong encoding for those broadcasters that use correct default encoding ISO 6937 (e.g. UPC Direct). I have one idea: when no encoding specified, i can first check if given string has 6937 encoding. I will check if there are any non-specified in 6937 symbols or symbol combinations present in given string, and if yes - then we have bad provider, and try to take second option - convert it according to current ANSI codepage. Seems correct? [/QUOTE]

Verification