EXP-4067 Cleanup usage of TvLibrary.Epg.Languages (1 Viewer)

[Sebastiii]

Hi,

The patch will do this :
Languages now as singleton
Added Languages.GetLanguagePairs
Removed GetLanguages from TvServerRemote

2012.12.17 :

Testing Required:

• Try EPG

Attached installer (based on 1.3.0Beta)

I also add an link to the branch on GitHub so that devs can get the code and try to help me directly.

.:: Public Download Link generated by our bot ::.

@doskabouter can explain more than me on his patch

 

[doskabouter]

Well, other than a bit of code-cleanup there's really not much to say about it...

 

[MrCrabs]

So we are supposed to test EPG, but what might be possible issues?

 

[doskabouter]

The main thing I did, was streamline the code for fetching the list of possible languages to choose from.

This affected
- setuptv dvb epg: tv epg grabber and radio epg grabber screens
- MpConfiguration: Tv, Tv Client, Audio settings and Subtitle settings.

So, if I did my work correctly, you should see that those screens are still working, and reflect the state of the configuration settings correctly

 

[Sebastiii]

Bumping this
We need result of testing

 

[jehe]

Hi Sebastiii,
If I find some time this week I will test your patch.

 

[jehe]

Hi,

It is thus the intention that I choose some channels to retrieve the EPG information.
And in the right table I choose some languages.
And then in the TV Guide only the EPG information from the selected languages may appear ?

So selecting the language works for me, both in the tvserver conf. as in the mediaportal conf..
And the EPG information is displayed in the TV Guide.

Do you need some logs or some screenshots?

 

[doskabouter]

Well, I think that was a different mantis. This was a refactoring which made the lot a bit easier to understand/maintain

 

[elliottmc]

Merged to master Merge remote-tracking branch 'remotes/origin/EXP-4067-Cleanup_usage_o…