[Approved] Fix for search returning programs not available in guide (1 Viewer)

kkendall

Portal Pro
April 24, 2007
864
16
45
Gouda
Home Country
Netherlands Netherlands
MY opinion is that if someone searches, it intends to search through the channels of the selected group.
The search option should only return results from the selected group.

You don't want your kids to search for something and they get all kinds of porn movies in return! :D Even though the porn channels are not selected in the group.
 

elliottmc

Retired Team Member
  • Premium Supporter
  • August 7, 2005
    14,927
    6,061
    Cardiff, UK
    Home Country
    United Kingdom United Kingdom
    Hi,

    But you go into search from the main TV screen, not from the TV guide where you might have a group selected. So I would expect a search to search the entire TV guide, not a subset of it. Otherwise you have to check your group before searching.

    Mark
     

    kkendall

    Portal Pro
    April 24, 2007
    864
    16
    45
    Gouda
    Home Country
    Netherlands Netherlands
    I too expect to search the entire tv guide, that's what everybody wants, but only from the selected group!
    It's just that nobody wants to be forced to search the all channels group(including porn channels, violence channels, horror channels, etc) when children are using search.
    It would be a great option to select the group to search when using the search option!
    Otherwise, if this is too hard to program, just search only channels of the selected group, not ALL channels, and clearly show somewhere which group is being searched.
     

    morpheus_xx

    Retired Team Member
  • Team MediaPortal
  • March 24, 2007
    12,070
    7,459
    Home Country
    Germany Germany
    dsnaith: I was busy meanwhile and could not test your patch myself.

    one more question: does your patch also works for the programming of recording schedule? i.e. you want to records something, you will get a list of others programs with same/similiar title.
    --> in this place, does your filter also apply? would be needed also...
     

    dsnaith

    Portal Member
    April 16, 2006
    9
    0
    Yes, the patch does also filter the program in the list of same/similar programs so that on programs that are visible in the guide are displayed.
     

    elliottmc

    Retired Team Member
  • Premium Supporter
  • August 7, 2005
    14,927
    6,061
    Cardiff, UK
    Home Country
    United Kingdom United Kingdom
    Hi,

    If we are going to filter searches by channel group, there needs to be a way of selecting the group to search within the search screen.

    Anything else is not intuitive.

    Channel groups are mainly for convenience within the TV guide, for example if you have lots of channels.

    At the very least, if this patch is to be included, there needs to be a check box added to config to decide whether you search the current channel group, or all channels for which there is data.

    Best wishes,

    Mark
     

    morpheus_xx

    Retired Team Member
  • Team MediaPortal
  • March 24, 2007
    12,070
    7,459
    Home Country
    Germany Germany
    no, this patch does not cares about channel groups at all. this is good this way.

    we won't have an option to limit for groups, as every user can switch between them. this wouldn't be useful
     

    morpheus_xx

    Retired Team Member
  • Team MediaPortal
  • March 24, 2007
    12,070
    7,459
    Home Country
    Germany Germany
    hi dsnaith,

    you are the author of the patch, so now you are asked to check if my modification still do work for all szenarios you tested before :p

    so please test and I'll commit once you confirmed :D

    morpheus
     

    Attachments

    • SearchOnlyVisibleInGuide_v2.patch
      30.7 KB

    dsnaith

    Portal Member
    April 16, 2006
    9
    0
    Morpheus_xx

    The patched worked but I noticed two things. First my patch was slower than the original code and I missed one function (GetPrograms). I've corrected both of these things and here's a new patch file.
     

    Attachments

    • SearchOnlyVisibleInGuide-3 (using SVN23143).patch
      30.8 KB

    Users who are viewing this thread

    Top Bottom