Reply to thread

Message

<blockquote data-quote="DragonQ" data-source="post: 1010746" data-attributes="member: 115209">There are plenty of albums where one track continues to the next without any gap (even if it's just a cross-fade) and for those you need gapless playback. If you only ever play shuffled tracks then it probably wouldn't matter to you but that doesn't change the fact that it's a vital feature of any half-respectable music player.&nbsp;It's hard to tell if there is actually a gap being created or if it's just the fade out and fade in that causes the lack of continuity. Disabling this unnecessary fading might be enough to fix it (again, the &quot;Fade-in on start / fade-out on stop&quot; tickbox seems just as useless as the &quot;gapless playback&quot; one - even with this unticked, there is a fade at the start of every track, which is horrible when tracks start immediately).&nbsp;&nbsp;EDIT: I was right, for some reason cross-fading is set to 200 ms when gapless is chosen. This is incorrect as there should be no cross-fading at all:&nbsp;[code]case (int)PlayBackType.GAPLESS:&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Config.CrossFadeIntervalMs = 200;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; type = &quot;Gapless&quot;;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; break;[/code]&nbsp;[code]&nbsp; &nbsp; public void SwitchToGaplessPlaybackMode()&nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; if (_playBackType == (int)PlayBackType.CROSSFADE)&nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; // Store the current settings, so that when the album playback is completed, we can switch back to the default&nbsp; &nbsp; &nbsp; &nbsp; if (_savedPlayBackType == -1)&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; _savedPlayBackType = _playBackType;&nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; Log.Info(&quot;BASS: Playback of complete Album starting. Switching playbacktype from {0} to {1}&quot;,&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; Enum.GetName(typeof(PlayBackType), _playBackType),&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; Enum.GetName(typeof(PlayBackType), (int)PlayBackType.GAPLESS));&nbsp; &nbsp; &nbsp; &nbsp; _playBackType = (int)PlayBackType.GAPLESS;&nbsp; &nbsp; &nbsp; &nbsp; Config.CrossFadeIntervalMs = 200;&nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; }[/code]&nbsp;Change Config.CrossFadeIntervalMs to 0 and it'll probably be fixed.</blockquote>

[QUOTE="DragonQ, post: 1010746, member: 115209"] There are plenty of albums where one track continues to the next without any gap (even if it's just a cross-fade) and for those you need gapless playback. If you only ever play shuffled tracks then it probably wouldn't matter to you but that doesn't change the fact that it's a vital feature of any half-respectable music player. It's hard to tell if there is actually a gap being created or if it's just the fade out and fade in that causes the lack of continuity. Disabling this unnecessary fading might be enough to fix it (again, the "Fade-in on start / fade-out on stop" tickbox seems just as useless as the "gapless playback" one - even with this unticked, there is a fade at the start of every track, which is horrible when tracks start immediately). EDIT: I was right, for some reason cross-fading is set to 200 ms when gapless is chosen. This is incorrect as there should be no cross-fading at all: [code]case (int)PlayBackType.GAPLESS: Config.CrossFadeIntervalMs = 200; type = "Gapless"; break;[/code] [code] public void SwitchToGaplessPlaybackMode() { if (_playBackType == (int)PlayBackType.CROSSFADE) { // Store the current settings, so that when the album playback is completed, we can switch back to the default if (_savedPlayBackType == -1) { _savedPlayBackType = _playBackType; } Log.Info("BASS: Playback of complete Album starting. Switching playbacktype from {0} to {1}", Enum.GetName(typeof(PlayBackType), _playBackType), Enum.GetName(typeof(PlayBackType), (int)PlayBackType.GAPLESS)); _playBackType = (int)PlayBackType.GAPLESS; Config.CrossFadeIntervalMs = 200; } }[/code] Change [i]Config.CrossFadeIntervalMs[/i] to 0 and it'll probably be fixed. [/QUOTE]

Verification