Reply to thread

Message

<blockquote data-quote="mm1352000" data-source="post: 1171178" data-attributes="member: 82144">Argh, the code seems to be very messy. I don't like code like this. <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite3" alt=":(" title="Frown&nbsp; &nbsp; :(" loading="lazy" data-shortname=":(" />[USER=60104]@Sebastiii[/USER]Why do we have the &quot;if (GUIGraphicsContext.DeviceAudioConnected &gt; 0)&quot; checks?Is it to avoid initialising/using the &quot;_mixer&quot; object, or...?Why is the code sometimes checking whether the volume is 19660500 instead of checking DeviceAudioConnected?<a href="https://github.com/MediaPortal/MediaPortal-1/blob/master/mediaportal/Core/DShowNET/Helper/DirectShowUtil.cs#L945" target="_blank">https://github.com/MediaPortal/MediaPortal-1/blob/master/mediaportal/Core/DShowNET/Helper/DirectShowUtil.cs#L945</a>In general it seems like the Mixer and MasterVolumeHandler classes were designed to handle the situation when no audio end-point is available, so I don't understand why the &quot;wrapping checks&quot; - &quot;if (...)&quot; - are needed.&lt;sigh&gt;</blockquote>

[QUOTE="mm1352000, post: 1171178, member: 82144"] Argh, the code seems to be very messy. I don't like code like this. :( [USER=60104]@Sebastiii[/USER] Why do we have the "if (GUIGraphicsContext.DeviceAudioConnected > 0)" checks? Is it to avoid initialising/using the "_mixer" object, or...? Why is the code sometimes checking whether the volume is 19660500 instead of checking DeviceAudioConnected? [URL]https://github.com/MediaPortal/MediaPortal-1/blob/master/mediaportal/Core/DShowNET/Helper/DirectShowUtil.cs#L945[/URL] In general it seems like the Mixer and MasterVolumeHandler classes were designed to handle the situation when no audio end-point is available, so I don't understand why the "wrapping checks" - "if (...)" - are needed. <sigh> [/QUOTE]

Verification