[Approved] Improve movie name and year parsing (1 Viewer)

Brownard

Development Group
  • Team MediaPortal
  • March 21, 2007
    1,953
    1,307
    United Kingdom United Kingdom
    Country flag
    • Thread starter
    • Moderator
    • #1
    I've changed the name parsing for movies so that '.' and '_' are replaced with spaces (same as already happens for series parsing) and changed the year regex so that years don't have to be surrounded by parenthesis. It gives much better results for me.
     

    Attachments

    morpheus_xx

    Lead Dev MP2
  • Team MediaPortal
  • March 24, 2007
    11,400
    6,971
    Germany Germany
    Country flag
    We have some unit tests for Movie/Series matching here:
    Could you add some example name patterns to TheMovieDb test class? Currently there are only "clean" names included, but for testing the changed regexps it would be good to consider more file names (like in SeriesNameMatcher).

    Can you create a branch for this change (including Test project), please?
     

    Brownard

    Development Group
  • Team MediaPortal
  • March 21, 2007
    1,953
    1,307
    United Kingdom United Kingdom
    Country flag
    • Thread starter
    • Moderator
    • #4
    We have some unit tests for Movie/Series matching here:
    Could you add some example name patterns to TheMovieDb test class? Currently there are only "clean" names included, but for testing the changed regexps it would be good to consider more file names (like in SeriesNameMatcher).

    Can you create a branch for this change (including Test project), please?
    Will do...though my broadband has completely died on me today so could be a while :-(
     

    Brownard

    Development Group
  • Team MediaPortal
  • March 21, 2007
    1,953
    1,307
    United Kingdom United Kingdom
    Country flag
    • Thread starter
    • Moderator
    • #5
    The MovieMatchesAreCorrect unit test is failing for me, even before my modifications. Can you confirm whether its working for you?
    I modified the NoLocalization class to force the German CultureInfo which fixed some of the matches but these titles are still failing:

    "Unbeugsam - Defiance"
    "The Artist"
    "Quarantäne"
    "Oben"
    "Iron Sky"
    "Hangover"

    "Unbeugsam - Defiance" fails the Levenshtein check, the rest fail because there are multiple exact matches.

    Thanks
     

    morpheus_xx

    Lead Dev MP2
  • Team MediaPortal
  • March 24, 2007
    11,400
    6,971
    Germany Germany
    Country flag
    I have to admit that I didn't run them recently, so they could fail already :oops:
    The problem with this "test" is the dynamic nature of online databases, changed data cause different results (this is what happened to "Unbeugsam - Defiance" it was changed online to "Defiance - Unbeugsam").

    Not sure how we should handle this...
     

    Users Who Are Viewing This Thread (Users: 0, Guests: 1)

    OP Similar threads Forum Replies Date
    horned_reaper [solved] Improved MBID Search for Artist and Album Fanart Handler 106
    ajs [fixed] 5022: Improving the MPE Installer, providing nicer GUI :) MediaPortal 1 42
    doskabouter Small code improvements MediaPortal 1 8
    ajs [fixed] 5015: Improving the MP1 installer, providing nicer GUI :) MediaPortal 1 138
    doskabouter Exceptions found due to improved logging General Support 11
    CyberSimian [fixed] MP1-4990 : Improve horizontal scrolling in the EPG MediaPortal 1 10
    ge2301 Bugs and Improvements Nereus 0
    N [Proposal] How to improve series scheduling MediaPortal 2 72
    ge2301 [Finished] [MP2-776] Improve busy screen appearance MediaPortal 2 14
    B [MP2-772-773] improve busy cursor and settings loading Testing Area 10
    azzuro [Help Me!] Improve duration times of GUI List items MediaPortal 2 37
    Alberto83 [Finished] [MP2-752] Improve recording handling MediaPortal 2 34
    B [MP2-744] WMC home content focus improvements Archive 55
    toricred Using TMM, How to Stop Importer From Going to The Movie Database for Data General 1
    DHosein 1.25 Upgrade and movie covers/backdrops General Support 9
    doskabouter [Help Me!] Playback of iTunes Movie Trailers Developer Discussions 0
    D [solved] Movie artwork download stopped working Submit: Bug Reports 9
    G Movie release date in guide Electronic Program Guide 2
    J [fixed] Import issue with alternate movie title matching the name of another movie Submit: Bug Reports 7
    tano_grasa Movie cover not showing when starting a movie aMPed 0
    R [further infos missing] some movies freezing evry seconds Submit: Bug Reports 9
    J [fixed] Importer confused on specific movies with the same title, different years and different NFO's Submit: Bug Reports 3
    B How to Search MP2 for Movies only in 7 day EPG that comes from the Antenna General 3
    A MP2.2.2, understanding movies/videos/tv and WTV recordings. General 16
    N [solved] Movies starten nicht Allgemeines Support- und Diskussionsforum 16
    Similar threads

























    Top Bottom