[fixed] [JIRA MP1-2469] - DetectDrive method obsolete ? (2 Viewers)

[Sebastiii]

Branch Created
Hope it's ok i have to manually apply the patch lol

 

[azzuro]

Hi, sebastiii, the branch seems can't be merged with Combined fix take 3 of elliotmc

 

[Sebastiii]

Ah maybe but should be ok on master, can you confirm ?

 

[azzuro]

Now, no, i'm at work ... ( every day, except week-ends)
Branch missing 23 Send from master ...

 

[azzuro]

maybe @Scythe42 : can you include the patch/branch to your work as it's an improvement of MP system/core and manage conflicts ...
but is not urgent ! i know your are overcharged ...

 

[Scythe42]

Sure, can include it and resolve the conflicts or merge it afterwards. @elliottmc?

 

[elliottmc]

Sure, can include it and resolve the conflicts or merge it afterwards. @elliottmc?

It wouldn't merge with all of the other stuff, and I am not an expert in resolving GIT conflicts. Hopefully once we get your branch merged to master we can then fix the conflicts and include in the next build. I am happy for you to schedule this for 1.4.0 so we don't forget about it.

 

[elliottmc]

maybe @Scythe42 : can you include the patch/branch to your work as it's an improvement of MP system/core and manage conflicts ...
but is not urgent ! i know your are overcharged ...

We should not add it to Scythe's branch. It is a totally unrelated fix, and should be treated as such. Let's get one branch merged, resolve the conflicts and then get the next one in.

 

[azzuro]

We should not add it to Scythe's branch. It is a totally unrelated fix, and should be treated as such. Let's get one branch merged, resolve the conflicts and then get the next one in.

Was my goal, it's only for solve conflict, because i fear with all changes made by scythe, the patch (branch) would be totally broken.
Thx Elliottmc
PS : @Deda is missing since few days, no ?

 

[azzuro]

I have tested on Workstation with 2 USB HDD + 1 USB key.

* All are detected fine, Error in log when enter & exit Device in Myvideo
* device (USB HDD) disappear from Gui list when removed
- Missing Icon for removable drive (DefautWide skin @catavolt )


If we can enhance this code :

+ Add "Eject removable Media" for USB HDD because is detected as local Hdd
+ icon for USB Hdd