[fixed] [JIRA MP1-2469] - DetectDrive method obsolete ? (1 Viewer)

[elliottmc]

I have tested on Workstation with 2 USB HDD + 1 USB key.

* All are detected fine, Error in log when enter & exit Device in Myvideo
* device (USB HDD) disappear from Gui list when removed
- Missing Icon for removable drive (DefautWide skin @catavolt )
View attachment 126409

If we can enhance this code :

+ Add "Eject removable Media" for USB HDD because is detected as local Hdd
+ icon for USB Hdd

Bump. What needs doing? If we want to 'add' something, this can be done as a separate issues.

Basic question - does this do what it is supposed to do ? Does it work ? Are there any bugs (not missing features!).

If all is fine, we should merge to master, then move on. @catavolt - can you please sort the USB HDD icon? I guess we also need one for Titan @ncoH

 

[catavolt]

If I knew how the GFX must be named I´ll add it here
We already have a "defaultRemovable.png" in Default skins, but obviously this is not the correct name or this name is not correct referenced in the code

 

[Deda]

Yes, it's correct, no USB (something) special, just all are removable so no skin changes or icons

 

[elliottmc]

Yes, it's correct, no USB (something) special, just all are removable

So in Azzuro's report, his J: drive doesn't have a thumbnail. I can't work out from the logs what might be wrong.

I assume this is the issue he is reporting. @azzuro

 

[azzuro]

If all is fine, we should merge to master, then move on. @catavolt - can you please sort the USB HDD icon? I guess we also need one for Titan @ncoH

Yes, it's correct, no USB (something) special, just all are removable

On the screenshot, i have 2 External Drive USB (name is : 160GB & Externe ) appears as Local Disk ! not removable ( not possible to have "Eject" function similar at Removable USB dongle memory )

 

[Deda]

defaultRemovable.png
defaultRemovableBig.png

are set in VDirectory for removable drives (USB thumbs) for small/big icons.

USB HDD are set as fixed disk (Windows reports them like that so they have HDD icon)

 

[elliottmc]

If all is fine, we should merge to master, then move on. @catavolt - can you please sort the USB HDD icon? I guess we also need one for Titan @ncoH

Yes, it's correct, no USB (something) special, just all are removable

On the screenshot, i have 2 External Drive USB (name is : 160GB & Externe ) appears as Local Disk ! not removable ( not possible to have "Eject" function similar at Removable USB dongle memory )

Right so they have a thumbnail, but you think they should have a different one?

What about J: ? That has no thumb. What sort of drive is that?

 

[azzuro]

Bump. What needs doing? If we want to 'add' something, this can be done as a separate issues.

We need doing (original thread):
* Plug USB HDD, should appears in Share Root List : OK
* USB HDD is removed when unplugged : OK
(E-SATA not tested)

Add something :
Small "issue" but not showstopers :
- Add "Eject Function" to USB HDD because is detected as local (fixed) HDD

For enhancement ONLY :
+ custom icon for HDD removable (USB / ESATA)

For icon USB removable in Default skin, i don't remember if it was displayed in Titan

 

[catavolt]

Well then - the icons shown for the removable drives are definitely not the defaultRemovable.png/defaultRemovableBig.png - so something not correct here @Deda

 

[azzuro]

What about J: ? That has no thumb. What sort of drive is that?

is Dongle USB (memory flash)