[fixed] Movie was not detected properly, even if nfo/txt file with imdb exists (1 Viewer)

[chefkoch]

I didn't renamed all my movies properly, but kept either the nfo-file or added a txt file manually, containing only the the imdb-id or I have the nfo file and the txt.

This bug / request is slightly different from a general nfo-file support. The general nfo file support does require a new metadataextractor.

The suggested solution to improve movie matching is only about extracting the imdbid from text files next to the movie-file similar to MovingPictures' NfoBuilder.

 

[morpheus_xx]

I've implement a nfo reader, maybe you can try this version?
[14:14] <MP2-GitBot> [MediaPortal-2] morpheusxx pushed 2 new commits to FEAT_ImproveOnlinelookup: http://git.io/xRjz2A

 

[morpheus_xx]

Thanks to the testing of @AlexanderIanHall, with his help we could improved the movie matching very much. Reading the nfo out of additional files works fine, also for special cases when we access movies inside .zip or .iso images!

Set to fixed

 

[chefkoch]

I tested the new branch and it is much better now. Thanks for that.

Nevertheless, I still have a few case where it does not seem to work.
I collected the details of a few examples and put them together in the attached zip file.

There were 2 wrong matches to the same online movie, even if there was an imdbid available for both local movies.
A few time the imdb id was when having video files.
Once I am having a DVD folder structure and there the imdb id was also not used

 

[morpheus_xx]

Thanks for testing. I will extent the text file lookup after vacation. Remember me, if I forget it

 

[chefkoch]

Thanks for testing. I will extent the text file lookup after vacation. Remember me, if I forget it

Maybe we could implement kind of plugin or feature which generates those reports automatically in a seperate file (not the log file), for example:

• if no match, collect the file/folder structure, and all files which are smaller than 50KB
• if user (not implemented yet ) re-assign a movie to another one via gui, do same as above and add info about the previous match.

These reports could help us and the user ins future to increase the matching quality or point the user easily to the reason why it is not being matched / incorrect matched and maybe the reason, if we no additional code will be added to support this case.

 

[morpheus_xx]

Ok, next round: I now also check sibling files for IMDB ids in filename. This solves all the missed matches, where a tt...txt file exists (Pushed to https://github.com/MediaPortal/MediaPortal-2/commit/f665c9d9c6f36fc63eae90feebbac17def2c3101)

This will not solve:

• "Soweit die Füße tragen" --> no IMDB match returned from TheMovieDB. IMDB directly would know it (http://www.imdb.com/title/tt0277327/), but we don't check this source yet
• "Total Recall" returns 2 matches with exact title (1990 - correct, and 2012). It would be detected fine already, if you would name the folder "Total Recall (1990)"

So for now I would say this issue is solved (as long as an IMDB ID is available).

For the management of non-unique, missing, and wrong matches we need to implement more logic and plugins. The matching is done on server, so we need server+client plugins and UPnP communication between them...

So this will stay on the "TODO" list for a while