Movies - enhanced details + cover retrieval + auto matching (3 Viewers)

roopert

Portal Pro
June 3, 2008
80
4
Home Country
Belgium Belgium
I don't get it. I've always had the dash problem. I don't really care, aslong the text is readable...

I saw another problem with the layout of the imdb screen. Switching from 'play' to 'plot' changed the background color of the focus bar. Sambal, maybe something you can fix?
 

Attachments

  • imdb_screen_problem.jpg
    imdb_screen_problem.jpg
    233.4 KB
  • imdb_screen_problem2.jpg
    imdb_screen_problem2.jpg
    235.7 KB

gamejester

Retired Team Member
  • Premium Supporter
  • May 13, 2007
    418
    37
    Home Country
    United Kingdom United Kingdom
    You can see that the rating for 'There will be Blood' is displayed as PG-13 when it should be 'R'. It has taken the rating from my first movie in the DB '10,000 B.C.' as the rating for all my movies.

    Knowing how the code works this can't have anything to do with a sepecfic csscript as they are out of the equation here, it is just doing a DB retrival and spitting out the info to the screen, so I assume this bug has always been there but it has just gone un-noticed, good spot. I will add it to the bug list, a step through should shed light on the problem.

    I don't get it. I've always had the dash problem. I don't really care, aslong the text is readable...

    Don't give up, if there is still a problem there I want to fix it. The dash issue was introdcued about 6 months ago but was fixed about 3 weeks ago. Lets check you have the correct csscript file.

    Find this file moviexml.csscript
    you can find it here
    "%ProgramFiles%\Team MediaPortal\MediaPortal\scripts\imdb\"

    open it in notepad.
    If it is the correct version you will have a line the same as this at the top

    void MediaPortal.Video.Database.IIMDBScriptGrabber.FindFilm(string strSearch, string strYear, int iLimit, ArrayList elements)

    The year in bold, if that is missing you have the old version.

    Also towards the bottom of the script the old version you had this section to get the cover:

    XmlNodeList xmldatat = Generic("http://www.movie-xml.com/interfaces/getmoviecovers.php?id=" + movieXMLID);

    foreach (XmlNode itemNode in xmldatat)
    {

    foreach (XmlNode propertyNode in itemNode.ChildNodes)
    {
    if (propertyNode.Name.ToString() == "filename")
    movieDetails.ThumbURL = "http://www.movie-xml.com/banners/" + propertyNode.InnerText;
    }
    }


    This should now NOT be in the script to allow the user to specify which search engines they want to use.
     

    ltfearme

    Community Plugin Dev
  • Premium Supporter
  • June 10, 2007
    6,755
    7,200
    Sydney
    Home Country
    Australia Australia
    Hey gamejester, do you think you could make the search withing MyVideos use the improved algorithm for searching e.g. Use YEAR in filename if available.

    Cheers,
    Damien
     

    roopert

    Portal Pro
    June 3, 2008
    80
    4
    Home Country
    Belgium Belgium
    Don't give up, if there is still a problem there I want to fix it. The dash issue was introdcued about 6 months ago but was fixed about 3 weeks ago. Lets check you have the correct csscript file.

    Find this file moviexml.csscript
    you can find it here
    "%ProgramFiles%\Team MediaPortal\MediaPortal\scripts\imdb\"

    open it in notepad.
    If it is the correct version you will have a line the same as this at the top

    void MediaPortal.Video.Database.IIMDBScriptGrabber.FindFilm(string strSearch, string strYear, int iLimit, ArrayList elements)

    The year in bold, if that is missing you have the old version.

    Also towards the bottom of the script the old version you had this section to get the cover:

    XmlNodeList xmldatat = Generic("http://www.movie-xml.com/interfaces/getmoviecovers.php?id=" + movieXMLID);

    foreach (XmlNode itemNode in xmldatat)
    {

    foreach (XmlNode propertyNode in itemNode.ChildNodes)
    {
    if (propertyNode.Name.ToString() == "filename")
    movieDetails.ThumbURL = "http://www.movie-xml.com/banners/" + propertyNode.InnerText;
    }
    }


    This should now NOT be in the script to allow the user to specify which search engines they want to use.

    Checked all what you said and the script seems fine.

    I deleted all scripts, movie database, cleared cache and started the configuration. I made sure that all settings were deleted. Copied the scripts from your bin-v4 file back in the imdb folder and adjusted the settings in configuration. Next step, opened MP->movies->88 minutes ->F9 ->imdb -> refresh.... Didn't do the trick, dash problem still there.

    I've got the latest svn for MP 1.0 RC2. What to do now? :(
     

    gamejester

    Retired Team Member
  • Premium Supporter
  • May 13, 2007
    418
    37
    Home Country
    United Kingdom United Kingdom
    Hey gamejester, do you think you could make the search withing MyVideos use the improved algorithm for searching e.g. Use YEAR in filename if available.

    Was thinking of getting rid of the internal ones and just having all csscripts as they are more upto date and anyone can maintain them. The inbuilt IMDB one now is a lot worse then the updated csscript by s7oneyuk.Will look to make all csscript accept year if available.

    Slash problem - I can confirm it IS still an issue. Looks like it was only partially fixed. Some movies (like 88 minutes) still have the slash issue with quotes; but not all. Will let movie-xml know and see if they can fix it. In the mean time I will re-instate my workaround which looks for escape chars and replaces them.

    Local Directory cover art - I can confirm that this solution works with the latest movie-xml script, I searched for 88 minutes (which has a cover of movie-xml) with only localDirectory selected and it returned a local file I had for batman in the same folder instead.
     

    piranha

    MP Donator
  • Premium Supporter
  • September 17, 2005
    370
    10
    Could you please get rid of "unknown" as a field value entirely? It doesn't look nice on the screen when it displays "plot: unknown".
    It's much better to replace it with empty string.
     

    gamejester

    Retired Team Member
  • Premium Supporter
  • May 13, 2007
    418
    37
    Home Country
    United Kingdom United Kingdom
    Could you please get rid of "unknown" as a field value entirely? It doesn't look nice on the screen when it displays "plot: unknown".
    It's much better to replace it with empty string.

    Will do, added to list.
     

    Spaldo

    MP Donator
  • Premium Supporter
  • May 7, 2008
    495
    12
    FlashFXP Development Team
    Home Country
    I am getting a problem where it wont play any of my files, in Vista that have the user/group ownership.

    it is only playing files with security ID ownership (ie. files that still have ownership/permission that have been copied from another pc.)

    They are playing fine in Vista, just not this build of MP..

    If that doesnt make sense, ill try to explain better...
     

    gamejester

    Retired Team Member
  • Premium Supporter
  • May 13, 2007
    418
    37
    Home Country
    United Kingdom United Kingdom
    think I understand.

    I cannot see how this problem can have anything to do with the covers patch as i have not touched that section of the code. Can you confirm if the problem exists on MP 1.0 RC2 without this patch, as if it does it needs logging in the bugs section for the core guys to fix.

    Also can you give a full explanation of your issue using examples and reporducable steps.
     

    Users who are viewing this thread

    Top Bottom