[confirm] MP crash and infinite loop by using skinsettings entry as hyperlink target (1 Viewer)

[Lehmden]

Hi.
Woking on a new skin with inbuild BasicHome Menu Editor I discovered one bug after another... This one is really annoying as it leads to an infinite loop that let Log Files grow until eternity and to a crash (MediaPortal.exe stopped working) on exit... After some minutes the error log has more than 2 GB size...

If I store values in skinsettings.xml they are usable inside all skin files. This is the theory. In practise if I use it as e.G. hyperlink target (or other tags needing numbers as argument) this leads to an infinite loop. Exiting MP in this situation shows the well known Stopped working Windows dialogue...

Beschreibung:
Stopped working

Problemsignatur:
Problemereignisname: CLR20r3
Problemsignatur 01: mediaportal.exe
Problemsignatur 02: 1.2.200.0
Problemsignatur 03: 50f50d63
Problemsignatur 04: Core
Problemsignatur 05: 1.2.200.0
Problemsignatur 06: 50f50d3b
Problemsignatur 07: 9df
Problemsignatur 08: 6
Problemsignatur 09: System.NullReferenceException
Betriebsystemversion: 6.1.7601.2.1.0.256.1
Gebietsschema-ID: 1031

Lesen Sie unsere Datenschutzbestimmungen online:
http://go.microsoft.com/fwlink/?linkid=104288&clcid=0x0407

Wenn die Onlinedatenschutzbestimmungen nicht verfügbar sind, lesen Sie unsere Datenschutzbestimmungen offline:
C:\Windows\system32\de-DE\erofflps.txt

CLR20r3 indicates a file is in use and can not be accesses as needed.. I think this is due the loop... I can not upload complete Log files as of enormous size, but the entries are always the same repeating every 1/100 second... Here is one of those entries:

2013-01-16 16:12:08.907460 [ERROR][MPMain(1)]: render exceptionystem.NullReferenceException: Der Objektverweis wurde nicht auf eine Objektinstanz festgelegt.
bei MediaPortal.GUI.Library.GUIButtonControl.Update()
bei MediaPortal.GUI.Library.GUIControl.DoUpdate()
bei MediaPortal.GUI.Library.GUIControl.Animate(Single timePassed, Animator animator)
bei MediaPortal.GUI.Library.GUIGroup.Render(Single timePassed)
bei MediaPortal.GUI.Library.GUIControl.DoRender(Single timePassed, UInt32 currentTime)
bei MediaPortal.GUI.Library.GUIWindow.Render(Single timePassed)

The next, identical entry starts at 2013-01-16 16:12:08.922461
What I have done to create this is:
I have set this entries

<section name="stringsettings">
<entry name="#skin.menu0.back">Animations\BasicHome\mytv.jpg</entry>
<entry name="#skin.menu0.label">Fernsehen</entry>
<entry name="#skin.menu0.headerlabel">TV : Fernsehen</entry>
<entry name="#skin.menu0.link">1</entry>
<entry name="#skin.menu0.linkpar">
</entry>
<entry name="#skin.menu0.onup">202</entry>
<entry name="#skin.menu0.posy">811</entry>
</section>

in SkinSettings.xml under "stringsettings" section.
Just a sidemark, here you can see another issue. After changing something "regular" e.g changing the Theme, all empty properties got an CRLF inside (see #skin.menu0.linkpar should be: <entry name="#skin.menu0.linkpar"></entry> ) The main problem appears also I correct this manually so this is not the reason for it.

Than I've tried to use it as target in a button control:

<control>
<description>Menu 0 button</description>
<type>button</type>
<id>200</id>
<font>font12</font>
<textXOff>0</textXOff>
<textYOff>0</textYOff>
<width>230</width>
<textalign>center</textalign>
<hyperlink>#skin.menu0.link</hyperlink>
<hyperlinkParameter>#skin.menu0.linkpar</hyperlinkParameter>
<textureNoFocus></textureNoFocus>
<textureFocus>empty.png</textureFocus>
<label>#skin.menu0.label</label>
<onleft>270</onleft>
<onright>210</onright>
<onup>#skin.menu0.onup</onup>
<ondown>1111</ondown>
<textcolorNoFocus>FFE9967A</textcolorNoFocus>
</control>

I can use the "Label" tag this way but any other tag leads to this loop and crash. I've tried to cint the property but this did not change anything... If I use any of the other properties as Label all shown as expected so the content of the properties seems to be correct...
If I use those properties declared by define tags they worked as expected. But defines can not have ":" as value (it's a bug too imho) what is needed in various cases and I can not set define values from inside the GUI...

IMHO nothing, really nothing on a skin should be able to produce an infinite loop at all so for me this is a big one, a showstopper...

This happened in 1.3 Beta and now in 1.3 RC...

 

[Zoidberg77]

Hi,
I did some testings and see the same error with MP1.3beta

[...]2013-01-17 21:01:06.529245 [ERROR][MPMain(1)]: render exception:System.NullReferenceException: Der Objektverweis wurde nicht auf eine Objektinstanz festgelegt.
  bei MediaPortal.GUI.Library.GUIButtonControl.Render(Single timePassed)
  bei MediaPortal.GUI.Library.GUIControl.DoRender(Single timePassed, UInt32 currentTime)
  bei MediaPortal.GUI.Library.GUIWindow.Render(Single timePassed)
2013-01-17 21:01:06.568116 [ERROR][MPMain(1)]: render exception:System.NullReferenceException: Der Objektverweis wurde nicht auf eine Objektinstanz festgelegt.
  bei MediaPortal.GUI.Library.GUIButtonControl.Render(Single timePassed)
  bei MediaPortal.GUI.Library.GUIControl.DoRender(Single timePassed, UInt32 currentTime)
  bei MediaPortal.GUI.Library.GUIWindow.Render(Single timePassed)
2013-01-17 21:01:06.601781 [ERROR][MPMain(1)]: render exception:System.NullReferenceException: Der Objektverweis wurde nicht auf eine Objektinstanz festgelegt.
  bei MediaPortal.GUI.Library.GUIButtonControl.Render(Single timePassed)
  bei MediaPortal.GUI.Library.GUIControl.DoRender(Single timePassed, UInt32 currentTime)
  bei MediaPortal.GUI.Library.GUIWindow.Render(Single timePassed)
[...]