home
products
contribute
download
documentation
forum
Home
Forums
New posts
Search forums
What's new
New posts
All posts
Latest activity
Members
Registered members
Current visitors
Donate
Log in
Register
What's new
Search
Search
Search titles only
By:
New posts
Search forums
Search titles only
By:
Menu
Log in
Register
Navigation
Install the app
Install
More options
Contact us
Close Menu
Forums
MediaPortal 1
MediaPortal 1 Plugins
Popular Plugins
My TVSeries
MP-TVSeries v4.3.6 Release [2020-01-24]
Contact us
RSS
JavaScript is disabled. For a better experience, please enable JavaScript in your browser before proceeding.
You are using an out of date browser. It may not display this or other websites correctly.
You should upgrade or use an
alternative browser
.
Reply to thread
Message
<blockquote data-quote="Edalex" data-source="post: 1286508" data-attributes="member: 63839"><p>It's soooo true <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite8" alt=":D" title="Big Grin :D" loading="lazy" data-shortname=":D" /></p><p>I have so many bug reports mostly about swagger and actual code mismatch.</p><p>I've autogenerated my C# code with swagger and only half of methods worked from the box.</p><p>The biggest problem for me are nullable types in C#. Integer in C# couldn't be null but no integer was tagged as nullable in swagger but several ones turned into null in fact. So I need to decide if I should make all integers as nullable in code or I should wait if you tag some of them as nullable in swagger or maybe you will use 0 instead of null everywhere for non-nullable types in C#. <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite10" alt=":oops:" title="Oops! :oops:" loading="lazy" data-shortname=":oops:" /></p><p></p><ul> <li data-xf-list-type="ul">class ArtworkExtendedRecord - nullable integer properties EpisodeId, MovieId,NetworkId,PeopleId,SeasonId,SeriesId,SeriesPeopleId and unlisted status property</li> <li data-xf-list-type="ul">class Character - nullable integer properties EpisodeId, MovieId,PeopleId,SeriesId and unlisted PeopleType property</li> <li data-xf-list-type="ul">class Company - problem with CompanyType property</li> <li data-xf-list-type="ul"><s>class CompanyType - actual properties are companyTypeId and companyTypeName and not ID and Name like in swagger</s></li> <li data-xf-list-type="ul">class ContentRating - unlisted property Description</li> <li data-xf-list-type="ul">class Entity - nullable MovieId,SeriesId is fact</li> <li data-xf-list-type="ul">class EpisodeBaseRecord - nullable ImageType, Runtime and ulisted properties Overview, LastUpdated, FinaleType</li> <li data-xf-list-type="ul">class EpisodeExtendedRecord - nullable AirsAfterSeason, AirsBeforeEpisode, AirsBeforeSeason and unlisted properties Overview, LastUpdated, FinaleType, Nominations, Networks, Studios</li> <li data-xf-list-type="ul">class MovieBaseRecord - nullable Score, Runtime and unlisted LastUpdated</li> <li data-xf-list-type="ul">class MovieExtendedRecord - nullable Score, Runtime and unlisted LastUpdated, several problems with underscores, problem with Companies</li> <li data-xf-list-type="ul">class PeopleExtendedRecord - unlisted NameTranslations, OverviewTranslations, Translations</li> <li data-xf-list-type="ul">class SearchResult - tranlation and overviews properties have another structure, unlisted objectID, some properties has underscores. The most bugged class <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite1" alt=":)" title="Smile :)" loading="lazy" data-shortname=":)" /></li> <li data-xf-list-type="ul">class SeasonBaseRecord - nullable ImageType <s>and problem with Companies property <a href="https://github.com/thetvdb/v4-api/issues/113" target="_blank">GetAllSeasons has unlisted properties · Issue #113 · thetvdb/v4-api</a>.</s></li> <li data-xf-list-type="ul">class SeasonExtendedRecord - nullable ImageType, wrong Type for Type, unlisted Companies and problem with TagOptions</li> <li data-xf-list-type="ul"><s>class SeasonType - Type has wrong type </s><a href="https://github.com/thetvdb/v4-api/issues/112" target="_blank"><s>SeasonType type property is string · Issue #112 · thetvdb/v4-api</s></a></li> <li data-xf-list-type="ul">class SeriesBaseRecord - unlisted LastUpdated and averageRuntime</li> <li data-xf-list-type="ul">class SeriesExtendedRecord - unlisted Episodes, LastUpdated and averageRuntime, Translations</li> <li data-xf-list-type="ul">class Companies - looks differently in methods I think</li> <li data-xf-list-type="ul">class Translation - nullable IsAlias</li> <li data-xf-list-type="ul"><s>method GetListTranslation has array inside "data" property while othe similar methods have single object inside "data" </s><a href="https://github.com/thetvdb/v4-api/issues/120" target="_blank"><s>GetListTranslation array instead of object · Issue #120 · thetvdb/v4-api</s></a></li> <li data-xf-list-type="ul"><s>method getSeasonTypes should have SeasonType array in swagger </s><a href="https://github.com/thetvdb/v4-api/issues/116" target="_blank"><s>getSeasonTypes wrong attribute · Issue #116 · thetvdb/v4-api</s></a> Also it has altdvd type which is not listed in seasontype enumerations in other methods</li> <li data-xf-list-type="ul">method GetSeriesSeasonEpisodesTranslated has Series object in swagger but it has Series properties without object</li> <li data-xf-list-type="ul">method GetSeriesExtended with meta=translation reffers to SeriesExtendedRecord object but it doesn't have "translation" object insid</li> </ul><p>Not a bug: enumerations are case-sensitive and should be lowercase. First, I thought all meta methods are broken but I found that my generator capitalized first letter.</p><p>I'll try to make issues for all of them but it will take some time. <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite8" alt=":D" title="Big Grin :D" loading="lazy" data-shortname=":D" /></p></blockquote><p></p>
[QUOTE="Edalex, post: 1286508, member: 63839"] It's soooo true :D I have so many bug reports mostly about swagger and actual code mismatch. I've autogenerated my C# code with swagger and only half of methods worked from the box. The biggest problem for me are nullable types in C#. Integer in C# couldn't be null but no integer was tagged as nullable in swagger but several ones turned into null in fact. So I need to decide if I should make all integers as nullable in code or I should wait if you tag some of them as nullable in swagger or maybe you will use 0 instead of null everywhere for non-nullable types in C#. :oops: [LIST] [*]class ArtworkExtendedRecord - nullable integer properties EpisodeId, MovieId,NetworkId,PeopleId,SeasonId,SeriesId,SeriesPeopleId and unlisted status property [*]class Character - nullable integer properties EpisodeId, MovieId,PeopleId,SeriesId and unlisted PeopleType property [*]class Company - problem with CompanyType property [*][S]class CompanyType - actual properties are companyTypeId and companyTypeName and not ID and Name like in swagger[/S] [*]class ContentRating - unlisted property Description [*]class Entity - nullable MovieId,SeriesId is fact [*]class EpisodeBaseRecord - nullable ImageType, Runtime and ulisted properties Overview, LastUpdated, FinaleType [*]class EpisodeExtendedRecord - nullable AirsAfterSeason, AirsBeforeEpisode, AirsBeforeSeason and unlisted properties Overview, LastUpdated, FinaleType, Nominations, Networks, Studios [*]class MovieBaseRecord - nullable Score, Runtime and unlisted LastUpdated [*]class MovieExtendedRecord - nullable Score, Runtime and unlisted LastUpdated, several problems with underscores, problem with Companies [*]class PeopleExtendedRecord - unlisted NameTranslations, OverviewTranslations, Translations [*]class SearchResult - tranlation and overviews properties have another structure, unlisted objectID, some properties has underscores. The most bugged class :) [*]class SeasonBaseRecord - nullable ImageType [S]and problem with Companies property [URL='https://github.com/thetvdb/v4-api/issues/113']GetAllSeasons has unlisted properties · Issue #113 · thetvdb/v4-api[/URL].[/S] [*]class SeasonExtendedRecord - nullable ImageType, wrong Type for Type, unlisted Companies and problem with TagOptions [*][S]class SeasonType - Type has wrong type [/S][URL='https://github.com/thetvdb/v4-api/issues/112'][S]SeasonType type property is string · Issue #112 · thetvdb/v4-api[/S][/URL] [*]class SeriesBaseRecord - unlisted LastUpdated and averageRuntime [*]class SeriesExtendedRecord - unlisted Episodes, LastUpdated and averageRuntime, Translations [*]class Companies - looks differently in methods I think [*]class Translation - nullable IsAlias [*][S]method GetListTranslation has array inside "data" property while othe similar methods have single object inside "data" [/S][URL='https://github.com/thetvdb/v4-api/issues/120'][S]GetListTranslation array instead of object · Issue #120 · thetvdb/v4-api[/S][/URL] [*][S]method getSeasonTypes should have SeasonType array in swagger [/S][URL='https://github.com/thetvdb/v4-api/issues/116'][S]getSeasonTypes wrong attribute · Issue #116 · thetvdb/v4-api[/S][/URL] Also it has altdvd type which is not listed in seasontype enumerations in other methods [*]method GetSeriesSeasonEpisodesTranslated has Series object in swagger but it has Series properties without object [*]method GetSeriesExtended with meta=translation reffers to SeriesExtendedRecord object but it doesn't have "translation" object insid [/LIST] Not a bug: enumerations are case-sensitive and should be lowercase. First, I thought all meta methods are broken but I found that my generator capitalized first letter. I'll try to make issues for all of them but it will take some time. :D [/QUOTE]
Insert quotes…
Verification
Post reply
Forums
MediaPortal 1
MediaPortal 1 Plugins
Popular Plugins
My TVSeries
MP-TVSeries v4.3.6 Release [2020-01-24]
Contact us
RSS
Top
Bottom