MP1-4357 Improve Deploy Tool detection for LAVFilters / TitanExtended

Sebastiii

Development Group
Joined
November 12, 2007
Messages
16,331
Points
113
Location
France
Country flag


Description of Change
When we use the DeployTool to install/upgrade MediaPortal, the checkboxes for LAVFilters & TitanExtended are always checked, even when they are already installed.

This branch should fix the detection of the installation and set the checkboxes according to the install status.

Tickets : https://issues.team-mediaportal.com/browse/MP1-4357

Steps to install and test
Installation
Download the -->> installer <<-- and execute it.

Testing
Upgrade your current 1.6.0 Final installation
Look if checked value are OK
Please do not forget to give some feedback (also if there is no bug). Thank you!

Sebastiii

Changelog

Version 1.6.0 v1
Build Based on MP 1.6.0 + master
 

vuego

Documentation Group
Joined
August 5, 2006
Messages
1,574
Points
113
Location
Göteborg
Country flag
There is a problem when Titan Extended is unchecked during an upgrade of MediaPortal

First of all, the skinsettings.xml containing the users customizations is overwritten.

Then settings_GUI_Skin.xml from MediaPortal will overwrite Titan Extended's which means that the More button is missing in MediaPortal - Settings - GUI - Skin so it is impossible for the user to manually reset the settings that was removed by the installer :oops:
 

HomeY

Test Group
Joined
February 23, 2008
Messages
6,460
Points
113
Age
44
Location
::1
Country flag
Yeah, i noticed the same.
The Skinsettings.xml is always overwritten, and we've had discussions about it in the past.
But the fact that Titan Extended needs to be re-installed to make the 'More Settings' button visible again after an upgrade, that is something that shouldn't happen.

These settings apply to MovingPictures & TV Series plugins, so the button should only show up when Titan Extended is installed. But if the default files doesn't contain this button, i think the XML file should be saved in the appropriate Extended One or Two folder?

@ncoH can you comment on this please?
 

elliottmc

Retired Team Member
Joined
August 7, 2005
Messages
14,927
Points
113
Location
Cardiff, UK
Country flag
@joostzilla may be able to comment. Nico hasn't been around for a while.

Fundamentally, we should try to avoid having different versions of the same file in Titan and in TitanExtended.
 
Top