Reply to thread

Message: <blockquote data-quote="Stéphane Lenclud" data-source="post: 1117964" data-attributes="member: 140174">I still need to work on that, just didn't want to start too early so as not to have to update the docs too often.I didn't know I could do things like that. I certainly don't know how.Now we' talking <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite1" alt=":)" title="Smile    :)" loading="lazy" data-shortname=":)" />Unless I missed something the former 'General HID' is just handling <a href="http://msdn.microsoft.com/en-us/library/windows/desktop/ms646275%28v=vs.85%29.aspx" target="_blank">WM_APPCOMMAND</a>. It has been left mostly unchanged, people who relied on that implementation before can still do so. However it has been renamed to 'Media' as it seems to be the most user friendly way to describe it. It is often refered too in such a way by hardware manufacturer which are selling Media Keyboards for instance. Though it does a little more than just Media the core of its functionality is about Media control and selection. I also needed to distinguish this implementation from the new generic HID which is actually HID this time.I'm not sure why one would do that but it should work in exactly the same way as before if they use 'Microsoft MCE' and 'Media'.However I vaguely remember seeing some WM_APPCOMMAND handling in the MCE implementation so I'm really unsure how those two behave when used together.Earlier version of my new implementation did replace the WM_APPCOMMAND by the WM_INPUT stuff. Now that works just fine when using an actually HID device however testing this against an iMON system in MCE compatibility mode I quickly realized that iMON fabricated WM_APPCOMMAND messages bypassing the HID stack. Since quite a few other hackish software out there could be doing the same I had to put back the WM_APPCOMMAND handling as 'Media' to keep everyone happy.I think it will very much depend on the adoption rate and user satisfaction concerning the new implementation. I don't have anything against the legacy implementations and we may as well keep on using them indefinitely or until there is a strong case for removing some of them. Having said that and unless I missed something the 'Microsoft MCE' implementation should not be needed anymore once the generic HID has matured. The generic HID implementation should provide access to the full set of functionality offered by eHome devices.We could also consolidate our input system and use a proper modular plugin framework for it but that's another topic altogether.I'll take a look but I'm not aiming at cleaning our whole code base with that one change. Though I did try to straighten it up a bit <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite1" alt=":)" title="Smile    :)" loading="lazy" data-shortname=":)" />Thanks for the feedback mate, it's much appreciated.</blockquote>

Verification