MP1-4720 Public method to try to fix some loadSkin error from plugin side (1 Viewer)

[Sebastiii]

Hi,

I have opened a Jira to try to do something to let plugin to be in sync when working with GUI :
https://issues.team-mediaportal.com/browse/MP1-4720

Trying to add a public method that plugin dev can use to loadskin in main thread.

public static readonly SynchronizationContext _mainThreadContext = SynchronizationContext.Current;

_mainThreadContext will be init on MP main thread, like this plugin can use it to be in sync for ex :

if (!_playbackStopped)
{
_mainThreadContext.Send(delegate
{
g_Player.ShowFullScreenWindow();
}, null);
}

Like this g_Player.ShowFullScreenWindow(); will be executed in sync with MP main thread.

Plugin dev need to ref to core.dll and in plugin when thing need to be sync with MP main thread, it should use like this :

GUIWindow._mainThreadContext.Send(delegate {
// code
// code
// etc;
}, null);

 

[Sebastiii]

In fact, when we run into a loadskin error, we should try to fix it one by one.

 

[regeszter]

Is it possible to change the core to be sync all public GUI methods?

For examlpe: // try TV

    public static bool ShowFullScreenWindow()
    {
      Log.Debug("g_Player: ShowFullScreenWindow");

      if (RefreshRateChanger.RefreshRateChangePending)
      {
        RefreshRateChanger.RefreshRateChangeFullscreenVideo = true;
        return true;
      }
      // does window allow switch to fullscreen?
      GUIWindow win = GUIWindowManager.GetWindow(GUIWindowManager.ActiveWindow);
      if (!win.FullScreenVideoAllowed)
      {
        Log.Error("g_Player: ShowFullScreenWindow not allowed by current window");
        return false;
      }
      // try TV
      if (_showFullScreenWindowTV != null)
      {
        _mainThreadContext.Send(delegate
        {
          if (_showFullScreenWindowTV())
          {
            return true;
          }
        }, null);      
      }
      // try Video
      if (_showFullScreenWindowVideo != null && _showFullScreenWindowVideo())
      {
        return true;
      }
      // try Other
      if (_showFullScreenWindowOther != null && _showFullScreenWindowOther())
      {
        return true;
      }

      Log.Debug("g_Player: ShowFullScreenWindow cannot switch to fullscreen");
      return false;
    }

I did not check this. It was created by notepad.

 

[Sebastiii]

We/I try do try to do the sync in loadskin method with no luck lol.
Seems above code looks ok, i didn't test it in VS but that the idea
Thanks for it

 

[ajs]

GUIWindow win = GUIWindowManager.GetWindow(GUIWindowManager.ActiveWindow);

The error can occur here ...

 

[Sebastiii]

Updated installer to Jira

 

[Sebastiii]

It's better but i just get one LoadSkin error : (from logomanager, so it must also be fixed on plugin side) @Edalex

 

[Edalex]

And @Vasilich!

 

[Sebastiii]

Yeahhhh

 

[azzuro]

Hey, Seb if this thread is related to our discussion on LMH thread, it work fine for me. no more issu;e and i use Logomanager too.