MP1_4137 and MP1-4171 - TsReader.ax AC3 improvements (1 Viewer)

[Owlsroost]

https://issues.team-mediaportal.com/browse/MP1-4137
https://issues.team-mediaportal.com/browse/MP1-4171
​

MP1-4137 is a bug fix for a language parsing issue with some AC3 audio streams, which can result in an 'unknown' language being assigned (which then can confuse the MP language selection logic) - see https://forum.team-mediaportal.com/...for-the-visually-impaired-incorrectly.120281/ for more info.

MP1-4171 is a small rework to add recognition of ATSC E-AC3 (DD+) streams to TsReader.ax, plus modfications to the log file formatting so that it is a better match with the MP log file formatting.

These modifications need testing for both the bug fix (4137), and to check that the modifications do not cause any regressions - so the more people who test the better

The binary files attached below include both sets of fixes and updates.

The combined Git branch is here - https://github.com/MediaPortal/MediaPortal-1/tree/MP1-EXP_TsReader_Area51_AC3_mods

The individual branches are here - https://github.com/MediaPortal/MediaPortal-1/tree/MP1-4137_TsReader_AC3_language_parsing_bug_v2 and https://github.com/MediaPortal/MediaPortal-1/tree/MP1-4171_TsReader_add_ATSC_E-AC3_stream_type​

 

[Owlsroost]

Second test binary attached - version 3.0.74.0b (very minor log message 'banner' change)

 

[Vasilich]

will try to test at least logging tonight, as i haven't had problems with tsreader before.
Only thought is - if you already started to modify log output format for TsReader - wouldn't it be better to set same log format for all DS filters?
And as i understood from diff view - there is no log level (debug/info/warn/error) in DS filters?

 

[Owlsroost]

as i haven't had problems with tsreader before.

That's fine - the mods are 'minority interest', it's mostly the regression testing that I'm interested in.

Only thought is - if you already started to modify log output format for TsReader - wouldn't it be better to set same log format for all DS filters?

That is the plan - I've already got new/test versions of dshowhelper and TsWriter in the pipeline/locally, so they will get the updated log formatting. The other filters should be be changeable fairly quickly.

And as i understood from diff view - there is no log level (debug/info/warn/error) in DS filters?

Correct (they've never had any concept of log levels, AFAIK....)

The new TsReader logging should look like this:

[2013-08-26 13:14:58,412] [	  0] [ 4e8] - 
[2013-08-26 13:14:58,413] [	  0] [ 4e8] - =================== New filter instance =========================
[2013-08-26 13:14:58,413] [	  0] [ 4e8] -  Logging format: Date Time [InstanceID] [ThreadID] Message.... 
[2013-08-26 13:14:58,413] [	  0] [ 4e8] - =================================================================
[2013-08-26 13:14:58,413] [	  0] [ 4e8] - demux: Start file read thread
[2013-08-26 13:14:58,413] [	  0] [ 4e8] - CRTSPClient::CRTSPClient()
[2013-08-26 13:14:58,413] [	  0] [ 4e8] - CMemoryBuffer::ctor
[2013-08-26 13:14:58,413] [ 2bcea88] [ 4e8] - ------------- v3.0.74.0 -------------
[2013-08-26 13:14:58,413] [ 2bcea88] [ 4e8] - CTsReaderFilter::ctor
[2013-08-26 13:14:58,413] [ 2bcea88] [ 4e8] - CRTSPClient::Initialize()
[2013-08-26 13:14:58,416] [ 2bcea88] [1350] - CDeMultiplexer::ThreadProc start(), threadID:0x1350
[2013-08-26 13:14:58,417] [ 2bcea88] [ 4e8] - CRTSPClient::createClient()
[2013-08-26 13:14:58,417] [ 2bcea88] [ 4e8] - ----- UseFPSfromDTSPTS -----
[2013-08-26 13:14:58,417] [ 2bcea88] [ 4e8] - --- Buffering delay = 0 ms
[2013-08-26 13:14:58,417] [ 2bcea88] [ 4e8] - ----- EnableBufferLogging -----
[2013-08-26 13:14:58,417] [ 2bcea88] [ 4e8] - Slow motion video allowed during zapping
[2013-08-26 13:14:58,417] [ 2bcea88] [ 4e8] - Wait for seeking to eof - false - constructor
[2013-08-26 13:14:58,417] [ 2bcea88] [ 4e8] - CTsReaderFilter::Start duration thread
[2013-08-26 13:14:58,417] [ 2bcea88] [ 4e8] - CTsReaderFilter::timeGetTime():0x105d6332, m_tGTStartTime:0xd05d632d, GET_TIME_NOW:0x40000005
[2013-08-26 13:14:58,419] [ 2bcea88] [1fb0] - CTsReaderFilter::ThreadProc start(), threadID:0x1fb0
[2013-08-26 13:14:58,419] [ 2bcea88] [1528] - CTsReaderFilter::Load()

 

[Vasilich]

[2013-08-26 13:14:58,413] [ 0] [ 4e8] - Logging format: Date Time [InstanceID] [ThreadID] Message....

then this line should also be corrected

 

[Owlsroost]

[2013-08-26 13:14:58,413] [ 0] [ 4e8] - Logging format: Date Time [InstanceID] [ThreadID] Message....

then this line should also be corrected

Done - new binary above

 

[Vasilich]

Fine.
btw, do we have any place (file) that is accessible from all DS filters, so we need to define (as string or DEFINE) formatted string only once, and all filters can use it? if we'll change formatting later, then it also would be easier to search for all the places where it is in use...

 

[Vasilich]

tested, no regression found.

 

[HomeY]

No playback issues found so far.