Music Player issues (1 Viewer)

Pablik

Development Group
  • Team MediaPortal
  • August 19, 2010
    700
    1,125
    Home Country
    Czech Republic Czech Republic
    Version: MediaPortal 1.30

    Issue 1:
    At the end of a playback (when the last item of playlist ends), the player is not properly stopped. If you try to play another item the MP freezes completly.

    Condition:
    - minidisplay is rendering EQ

    Source of the issue:
    • Core\MusicPlayer\BASS\BassAudioEngine.cs
    • public int GetChannelData(int handle, float[] buffer, int lenght)

    Description:
    The problem is that method Bass.BASS_ChannelGetData is executed under lock _syncRoot. For some reason the call of Bass.BASS_ChannelGetData is not beeing returned when the playlist ends. This causes not to release _syncRoot lock and blocks execution of Stop() method which is under the same lock (called from OnMusicStreamMessage).
    Removing the lock syntax fixes the issue. I'm not sure if the lock is actually needed for this method.


    Issue 2:
    If the playlist includes playlist file(like m3u) then start of the playback is made from wrong facade item.

    Condition:
    -playlist includes m3u file

    Source of the issue:
    • WindowPlugins\Common.GUIPlugins\Music\GUIMusicBaseWindow.cs
    • protected void AddItemsToCurrentPlaylist(List<PlayListItem> pItems, bool clearPlaylist, bool addAllTracks)

    Description:
    The problem is if the m3u playlist item is actually behind selected facade item in the list. In this case the var playlistcount shall not to be incremented.
     

    Users who are viewing this thread

    Top Bottom