Denmark
- Thread starter
- #11
Yes, that's right. I'm developing against the SVN's so the uploaded files won't run against a clean 0.2.2.0 install. However just replace all instances of "Configuration.Config" with "Util.Config" and it applies to 0.2.2.0.
My Lyrics 0.18 - Comments and bug reporting (1 Viewer)
- Thread starter mackey
- Start date
Pfff, I'm sure getting tired of this.
I tried to do what you said and the dll's compiled succesfully. I placed them in the mediaportal folder, overwriting the ones from the binary release.
It doesn't do anything.
It just shows the lyrics screen with nothing on it, not even a message that it's looking for lyrics or something.
So I tried to download a SVN version of MP.
But it freezes as soon as I try to play something.
Then I tried another SVN version (from yesterday), but that one also freezes.
What's the point of compiling against unstable development snapshots anyway?
Do you have the sourcecode for a working 0.2.2.0 version OR can you give me the revision number of the SVN version that works with this one?
I tried to do what you said and the dll's compiled succesfully. I placed them in the mediaportal folder, overwriting the ones from the binary release.
It doesn't do anything.
It just shows the lyrics screen with nothing on it, not even a message that it's looking for lyrics or something.
So I tried to download a SVN version of MP.
But it freezes as soon as I try to play something.
Then I tried another SVN version (from yesterday), but that one also freezes.
What's the point of compiling against unstable development snapshots anyway?
Do you have the sourcecode for a working 0.2.2.0 version OR can you give me the revision number of the SVN version that works with this one?
- Thread starter
- #13
I'm compiling against the snapshots because a lot of users uses the daily SVN's in favour of the stable 0.2.2.0, and I'm just happen to be one of those. 
However there is no difference in compiling against a SVN and the 0.2.2.0 release than the location of the config class as stated above.
If the code can compile with the reference to a 0.2.2.0, then it should have no problem running within the very same version of MP. You should be aware that you get a snapshot of my current working-files, which for instance means that the MyLyrics project is set up as a windows application, which you natural will have to change to a class library. Also there has been added a couple of extra options in the configuration since the latest release that you will have to deal with.
I cannot say why it won't work for you and not send you some modified version specialized for 0.2.2.0 since it is the very same code as you get when downloaded the source with your svn client.
However there is no difference in compiling against a SVN and the 0.2.2.0 release than the location of the config class as stated above.
If the code can compile with the reference to a 0.2.2.0, then it should have no problem running within the very same version of MP. You should be aware that you get a snapshot of my current working-files, which for instance means that the MyLyrics project is set up as a windows application, which you natural will have to change to a class library. Also there has been added a couple of extra options in the configuration since the latest release that you will have to deal with.
I cannot say why it won't work for you and not send you some modified version specialized for 0.2.2.0 since it is the very same code as you get when downloaded the source with your svn client.
Thnx.
My version now works with every audio source.
I added an event driven track change detection function, that uses track information from GUIPropertyManager instead of using the tagreader.
I had to make it event driven, because when I tried to read info from the GUIPropertyManager in the Process function, it often would contain the info of the previous track.
I wasn't able to commit to svn, so here's a link to the adjusted MyLyrics.cs
http://wwws.xs4all.nl/MyLyrics.cs
I hope it will be helpful.
I tested it briefly and it seems to work just fine now.
The only thing is... when I put in an audio CD,
it doesn't immediately display the artist & track names.
I have to go to My Music, the cd drive, and select a track from there.
But I guess this is a MP bug.
My version now works with every audio source.
I added an event driven track change detection function, that uses track information from GUIPropertyManager instead of using the tagreader.
I had to make it event driven, because when I tried to read info from the GUIPropertyManager in the Process function, it often would contain the info of the previous track.
I wasn't able to commit to svn, so here's a link to the adjusted MyLyrics.cs
http://wwws.xs4all.nl/MyLyrics.cs
I hope it will be helpful.
I tested it briefly and it seems to work just fine now.
The only thing is... when I put in an audio CD,
it doesn't immediately display the artist & track names.
I have to go to My Music, the cd drive, and select a track from there.
But I guess this is a MP bug.
- Thread starter
- #15
Cool! Thanks a lot, WouterW. I really appreciate your effort and contribution.
I've taken your code in use and it seems to work flawlessly. Not just for audio cds but for all other audio source. Thanks again.
This is a great plugin, and the recent changes make it even easier to use ....
A couple of things (bugs?) that I have noticed when I am in the "Marked database" and I use the Find button:-
1. If I find a lyric, pressing the "Update" button generates an error message - I think you already know about this one? If you don't already know about this one, I can provide more information, if you require.
2. The selection of lyrics sites in the "Settings" tab does not carry over to the "Fetch Lyric Dialog" window - all the sites are selected by default and if one site is not responding (like Hot Lyrics isn't right now), then this window hangs at the non-responding site. Unselecting the non-responding site in this window doesn't help, because the search has already commenced.
for all your hard work on this plugin - it is very much appreciated ...
A couple of things (bugs?) that I have noticed when I am in the "Marked database" and I use the Find button:-
1. If I find a lyric, pressing the "Update" button generates an error message - I think you already know about this one? If you don't already know about this one, I can provide more information, if you require.
2. The selection of lyrics sites in the "Settings" tab does not carry over to the "Fetch Lyric Dialog" window - all the sites are selected by default and if one site is not responding (like Hot Lyrics isn't right now), then this window hangs at the non-responding site. Unselecting the non-responding site in this window doesn't help, because the search has already commenced.
for all your hard work on this plugin - it is very much appreciated ... - Thread starter
- #18
Yup, there is two known errors in regarding the update button in the latest release. One; there comes a error message when updating a lyric in the marked database. Two; when changing the the name of the artist or the title and updating a known lyric there likewise comes a error message. Both errors have been corrected and the fixes will be present in the next release.
It is actually with purpose that all sites are selected and not just the once selected in the Settings tab. If a site hangs you should still be able to push "Update" (if a lyric has been found) or "Close" (if you want to close the dialog). If haven't seen that the GUI has hung or anything in this dialog. If the GUI hangs when a site is down please report back.
thanks for the comments and reports
When I say it "hangs", I mean that I am not able to edit the title to correct any errors that might be causing the lyrics to be not found. It is correct that I can still click on "Close" - but I would like to be able to modify the song title to see if that improves the success. Sometimes, the difference can be as simple as the use of "and" or "&" in the title.
If all the sites respond and the search completes, but there are no hits, I can then edit the title and try again. If one site doesn't respond, I can't edit the title and try it again ....
- Thread starter
- #20
When I say it "hangs", I mean that I am not able to edit the title to correct any errors that might be causing the lyrics to be not found. It is correct that I can still click on "Close" - but I would like to be able to modify the song title to see if that improves the success. Sometimes, the difference can be as simple as the use of "and" or "&" in the title.
If all the sites respond and the search completes, but there are no hits, I can then edit the title and try again. If one site doesn't respond, I can't edit the title and try it again ....
Okay, I clearly see you point now
I'll make the change so only the selected sites from the setting tab are searched when the fetch dialog opens.