MyFilms Details disables selectedthumb in MyVideos, MyPictures, MyMusic (1 Viewer)

[Dadeo]

Can anyone duplicate this problem?

1. Go to MyFilms DETAILS screen
2. Navigate to MyVideos, My Pictures or My Music

Does the #selectedthumb (large image) display in MyPictures, MyVideos or MyMusic? They don't for me! The icons view and filmstrip work fine but not the #selectedthumb.

The thumbs display fine until I go to the MyFilms Details screen, then they don't. MyFilms seems to be doing something to the #selectedthumb code!

This happens for me in all the skins I have tested (Blue3, Monochrome, Purevision, aMPed) and in both MP 1.0.2 on Vista SP,1 and in MP 1.0 on XP SP3, using MyFilms 4.8.0c. I have tried reinstalling MyFilms with a fresh configuration and the problem persists.

Just wanted to confirm it is not a system problem on my side. I remember seeing this before but didn't know what caused it and it went away when I restarted MP.

There is an old thread similar to this https://forum.team-mediaportal.com/...ymusicgenre-after-exit-myfilms-details-37246/ so maybe it is a bug and MyFilms is disabling selectedthumb (since it won't work in MyFilms Details if you try and use it)

If anyone can check and let me know if they get the same problem I would really appreciate it.

 

[jamiro]

I can confirm this is also happening to me as well.

My Films is a great plugin, but it is a concern if it effects other parts of MP like this.

 

[Guzzi]

Hi Zebons,
do we have any chance to get a bugfix for this?
Thanks, Guzzi

 

[Guzzi]

Hi Zebons, any chance for a fix for that? We always require a reboot after using myfilms to get selectedthumbs in other parts of MP ... A small fix would be very very nice

 

[catavolt]

^ +1! Can confirm the bug, and even worse: when leaving details view, all #selecteditems in other screens show "edititem".

 

[Guzzi]

AW: MyFilms Details disables selectedthumb in MyVideos, MyPictures, MyMusic

Hi Catavolt, Zebons,
I made some more research and finally found, that this error "editem" only occurrs, when both MyFilms AND TV-Series is activated - when removing the TV-Series Plugin, I don't get this error any more. Can you confirm that?
Any developer around with hints how to circumstance that? Because I definately need both those plugins ;-)

Any help is appreciated - maybe a hint, what needs to be done to fix this interaction!

Thanks,

Guzzi

 

[catavolt]

AW: MyFilms Details disables selectedthumb in MyVideos, MyPictures, MyMusic

That´s not totally correct. My films has a property named "select". The skin engine interpretes this wrong for the general property "selecteditem" resulting in the display of "editem" and not the real value for "selecteditem". Therefore I propose to use unique property names as in (nearly) all the other plugins, e.g. "MyFilms.selecteditem", "MyFilms.Title" and so on.

 

[Guzzi]

AW: MyFilms Details disables selectedthumb in MyVideos, MyPictures, MyMusic

Hmmm, I think I understand - so this is the same reason why thumbs are disappearing after use of MyFilms?
So what has to be done wuld be to rename the exported variables of the plugin plus once changing all names in the skin(s), right?

 

[catavolt]

AW: MyFilms Details disables selectedthumb in MyVideos, MyPictures, MyMusic

Correct.

 

[Guzzi]

AW: MyFilms Details disables selectedthumb in MyVideos, MyPictures, MyMusic

Ok, I looked inside the sourcecode, so I assume those two parts are the problematic ones in MesFilmsDetail.cs:

if (MesFilms.conf.StrTxtSelect.Length == 0)
GUIPropertyManager.SetProperty("#select", " ");
else
GUIPropertyManager.SetProperty("#select", MesFilms.conf.StrTxtSelect.Replace(MesFilms.conf.TitleDelim, @"\"));
afficher_init(MesFilms.conf.StrIndex); //Populate DataSet & Convert ItemId passed in initially to Index within DataSet
int TitlePos = (MesFilms.conf.StrTitleSelect.Length > 0) ? MesFilms.conf.StrTitleSelect.Length + 1 : 0; //only display rest of title after selected part common to group
if (!(MesFilms.conf.Stritem1 == null) && !(MesFilms.conf.Stritem1 == "(none)") && !(MesFilms.conf.Stritem1 == ""))


and

GUIPropertyManager.SetProperty("#Picture", listepicture[picture_Index]);

So renaming them to e.g. #MyFilms.Select and #MyFilms.Picture should do the trick, right? (Sorry, I am no programmer...)

I tried to compile the plugin - got some warnings. Actually the error of "editem" disappeared, but I got other errors. I think, the sources are not up2date - Zebons, could you please post the latest sources for the 4.8.0c version? Maybe we can fix this problem somehow....