MyLyrics 1.1 RC [update: outdated RC version] (1 Viewer)

[mackey]

I noticed that few others have been asking (or reported this problem) this feature but I still can't find it. Problem is with special characters on some lyrics and I think it get even a little worse with this version.

Problem can be seen on these screencaptures.

Capture 1 shows how this song includes some weird characters (should be ä and ö characters) on lyric. Capture 2 shows same on lyricswiki...which explains that there is some non supported characters.

Capture 3 shows different song which included ä and ö characters with another set. On capture 4 you can see that these are just fine on lyrics database...altought those are not HTML encoded if you looking HTML source.

Both cases I understand that your plugin can't figure out right characters. What I suggest is that you provide some mass-replace functionality to your settings for database. What I mean is that user could put on options characters or strings to be replaced after fetch from different sources. This way it would be configurable for user to determ replacements correctly. I could for example on this second example just define that 'ä' should be replaced with character 'ä'.

A quite interesting idea! One of these days I will contact you and we might figure something out. Until then you are welcome to download the source at https://mp-plugins.svn.sourceforge.net/svnroot/mp-plugins/trunk/plugins/MyLyrics and do your thing. You will have to get a sourceforge account and get permission by one of the admins (see https://sourceforge.net/projects/mp-plugins/).

While testing I also noticed a bug. You can't update and save lyrics anymore...I get this error (capture 5) when pressing save on lyrics database tab. I think it worked on stable version of RC4 and I was able to manually change these characters...altought I would be manually too big work to do...

I could also help to build that replace functionality if you wish. Sources are on available on SVN I guess?

I'm almost 100% that you only copied the mylyrics.dll to the plugins/windows folder and did't update the lyricsengine.dll in the MP base folder. That is the only thing that could explain the missingmethod exception.

best regards
Soren

 

[Jupek]

I'm almost 100% that you only copied the mylyrics.dll to the plugins/windows folder and did't update the lyricsengine.dll in the MP base folder. That is the only thing that could explain the missingmethod exception.

You were right. My bad.

I'll checking those sources and let you know if I'll figure out something usefully and provide you codes if I'll do something.

 

[Jupek]

I did some changes to sources and updated those to SVN. Please review those and made needed changes if I missed something for your component logic.

I did new tab to setup dialag (find & replace) where user can give string to be replaced with another. Those are saved to configuration as two strings (find and replace) which includes string pairs splitted with , -char...so , -char is not accepted to be replaced. I included new tab (first version) as a picture.

I didn't made any mass replace function to update database so I left it untouched. I just modified actually plugin process code which seemed to use function falled FixLyrics...I just overloaded that and made new one with few extra parameters. So when ever user watching lyrics using skin, those replacements will be done. So basicly if user don't have any replacements available there will be no extra performance hit done.

This seems so far fullfilled my needs on this matter.

 

[sdf]

Hi mackey!
Now synced lyrics are displayed again, but only with Blue3 skin.
I think the others (Indigo, Purevideo) have to change something.
Anyway good job for the .lrc support back!
Only a question: I have my mp3s with synced lyrics embedded with the <LYRICS> tag, these are not recognized by the plugin.
The tag <UNSYNCED LYRICS> is recognized indeed.
Otherwise, if I import a separate .lrc file all works.
Can you tell me which tag for synced lyrics mylyrics searches for?
I think, as a suggestion, that if an mp3 has embedded both a synced and an unsynced lyric, the plugin has to prefer the first.
Anyway, keep going with the good work!
Bye,sdf

 

[stahlwolle]

my mp crashes when using mylyrics...

 

[mackey]

I did some changes to sources and updated those to SVN. Please review those and made needed changes if I missed something for your component logic.

I did new tab to setup dialag (find & replace) where user can give string to be replaced with another. Those are saved to configuration as two strings (find and replace) which includes string pairs splitted with , -char...so , -char is not accepted to be replaced. I included new tab (first version) as a picture.

I didn't made any mass replace function to update database so I left it untouched. I just modified actually plugin process code which seemed to use function falled FixLyrics...I just overloaded that and made new one with few extra parameters. So when ever user watching lyrics using skin, those replacements will be done. So basicly if user don't have any replacements available there will be no extra performance hit done.

This seems so far fullfilled my needs on this matter.

Hi Jupek, thanks a bunch. I've reviewed the changes and they work like a charm. I will properly include the find/replace function in the batch searches.

Hi mackey!
Now synced lyrics are displayed again, but only with Blue3 skin.
I think the others (Indigo, Purevideo) have to change something.
Anyway good job for the .lrc support back!

Yup, all skins will have to put a length tag to the controls which are included in the LRC and editor modes.

In short, the following controls must be updated with the tag <width>920</width>:
id: 200-212
id: 300-312
id: 400-412
id: 500-512
id: 600-612
where 920 is the width in pixels. I believe 920 pixels is a appropriate length for most 16:9 skins, but it differs a bit.

Only a question: I have my mp3s with synced lyrics embedded with the <LYRICS> tag, these are not recognized by the plugin.
The tag <UNSYNCED LYRICS> is recognized indeed.
Otherwise, if I import a separate .lrc file all works.
Can you tell me which tag for synced lyrics mylyrics searches for?
I think, as a suggestion, that if an mp3 has embedded both a synced and an unsynced lyric, the plugin has to prefer the first.
Anyway, keep going with the good work!
Bye,sdf

Actually MyLyrics don't consider neither the <LYRICS> nor the <UNSYNCED LYRICS> tag. However, the MP TagReader might. MyLyrics looks at the intern structure of the Lyrics. If the pattern matches of a lyrics matches the one expected for a LRC file the LRC engine takes over.

I didn't know about the two listed tags. If you want to list an example I could see if the support easily can be implemented in MyLyrics.

my mp crashes when using mylyrics...

I can see from your logs that the mylyrics.xml haven't been copied into your Blue3Wide skin-folder. If you do that the plugin should work just fine.

2008-12-15 15:40:56.046875 [ERROR][MPMain]: SKIN: Missing C:\Programme\Team MediaPortal\MediaPortal\Skin\Blue3wide\MyLyrics.xml

 

[mamachan]

I have this problem:
when i use mylyric, some album thumbs (images) are deleted.
Example: i listen a track song of Alanis Morisette album and the thumbs\album\alanis.......jpj is deleted.
Why?
If i delete mylyric plugin, no problem.

massimo

sorry for my english.

 

[mackey]

I have this problem:
when i use mylyric, some album thumbs (images) are deleted.
Example: i listen a track song of Alanis Morisette album and the thumbs\album\alanis.......jpj is deleted.
Why?
If i delete mylyric plugin, no problem.

massimo

sorry for my english.

Hi massimo,

That sounds really strange! The plugin does not save or delete any images/thumbs, but natural use MP gui functionality to display the album covers to get a "Now Playing" feeling about the lyrics screen. If the deletion takes place it is done by some external MP code and not the plugin itself. I tried with both my computers and multiple skins, but cannot reproduce your report. Which skin are you using? Also attach a copy of the log-files just after the deletion of a thumb has taken place.

cheers
mackey

 

[mamachan]

I have this problem:
when i use mylyric, some album thumbs (images) are deleted.
Example: i listen a track song of Alanis Morisette album and the thumbs\album\alanis.......jpj is deleted.
Why?
If i delete mylyric plugin, no problem.

massimo

sorry for my english.

Hi massimo,

That sounds really strange! The plugin does not save or delete any images/thumbs, but natural use MP gui functionality to display the album covers to get a "Now Playing" feeling about the lyrics screen. If the deletion takes place it is done by some external MP code and not the plugin itself. I tried with both my computers and multiple skins, but cannot reproduce your report. Which skin are you using? Also attach a copy of the log-files just after the deletion of a thumb has taken place.

cheers
mackey

i use Bleazle skin.
Sorry, but for the log-files is impossible at the moment.
Today i vended my LCD, i'm waiting the new plasma
No other monitor in my house
A soon as possible i post log-files.

Thanks
massimo

 

[Mike1978]

is this normal? I go to the lyrics page and then hit "back" on the remote. After this I'm all back in the homescreen instead of my music-list

It has always done that, I did change the old version - looking at a version I have on my laptop I think the follwoing exit call needs to be changed to the highlighted line in MyLyrics.cs...cant be 100% sure on this as would need to see the current code to compare as did it a while ago.

public override void OnAction(Action action)
{
switch (action.wID)
{
case Action.ActionType.ACTION_PREVIOUS_MENU:
{
GUIWindowManager.ShowPreviousWindow();
break;
}

Hopfully mackey can adjust this before final release.

Trevor

Yup, thanks both of you. I'll fix this bug before the next release.

Hi!

Is there a way to fix this by myself until new version is coming? Cause this is really annoying ;-)