MyLyrics 1.1 RC [update: outdated RC version] (1 Viewer)

[mackey]

It has always done that, I did change the old version - looking at a version I have on my laptop I think the follwoing exit call needs to be changed to the highlighted line in MyLyrics.cs...cant be 100% sure on this as would need to see the current code to compare as did it a while ago.

public override void OnAction(Action action)
{
switch (action.wID)
{
case Action.ActionType.ACTION_PREVIOUS_MENU:
{
GUIWindowManager.ShowPreviousWindow();
break;
}

Hopfully mackey can adjust this before final release.

Trevor

Yup, thanks both of you. I'll fix this bug before the next release.

Hi!

Is there a way to fix this by myself until new version is coming? Cause this is really annoying ;-)

Unfortunately no. The fix (which was surprisingly compplicated) is in the code so you will have to get a couple of new dll's before the back-functionality works as intended. There will properly be a new version out towards the end of the week.

 

[mackey]

I have just put together a skin file for Aeon Wide, attached some screen shots and xml for those who may want to check it, still work to do - can't seem to move the spin control when not using LCR file...but it works and allows full functionality.

I do have some odd issues, lot do with the skin specific code in the plug that does alters visability of elements based on skin name, mode, wide/basic or combinations of these....

I can see some of the reasons and I might have missed or misunderstand the reasons but it does cause problems when skinning, particually for new 16.9 skins that have the room to allow for wide and still keep most elements.

A better approach would be to build in conditional visablity in the plugin and allow skin designers to hide/show what that want, would also save you work in the long run.

Just my thoughts

Great plugin and thanks for updating for the current release.

Trevor

Thanks for your thoughts. You are right all along and I have start to considered how the plugin can work more smoothly with all kinds of skins. The thoughts will end up in some sort of redesign but the actual approach is still to be decided.

Also, I have begun creating mylyrics.xml myself for various skins. I just finished the one for Aeon wide where I took off from yours, so also thanks for your effort working on this.

You find the new myLyrics.xml for Aeon wide here.

 

[datja]

Hi Mackey, and thanks for your plugin! The Config crashes when I import lyrics from file tags into the database. I have made a new install of MP and have lost my old lyrics database. So I would like to import the already existing lyrics from the tags before searching for the rest on the net. Somewhere in the middle of the importing process the entire MP config crashes. Could this be due to my having about 10000 lyric tags in 30000 songs? Could this be amended?

 

[mackey]

Hi Mackey, and thanks for your plugin! The Config crashes when I import lyrics from file tags into the database. I have made a new install of MP and have lost my old lyrics database. So I would like to import the already existing lyrics from the tags before searching for the rest on the net. Somewhere in the middle of the importing process the entire MP config crashes. Could this be due to my having about 10000 lyric tags in 30000 songs? Could this be amended?

Hi datja,
There is no exception handling around the import functionality so if some sort of exception occurs during the read. Please attach your MP log-files after a breakdown as there might be some important information on what went wrong. However I might implement some exception handling anyhow to avoid a crash. When I think of it, there could be an issue if your import while listening to one of the tracks in import. I will have a look.

If you are using MyLyrics 1.10 (here About: My Lyrics Plugin 1.10 (updated 22.12.2008) - MediaPortal Forum) and not just 1.1RC (to which this tread is considered) you can easily import lyrics from your lyrics tag. Simple do a complete batch search for all songs in your music database with the option "Always check music tag for lyrics before online search" on the Setting tab enabled. Then all tags are automatically included in the Lyrics database. 1.1RC does not have this option.