[confirm] MyMusic : SMSstyle letter for search ( AllViews) (1 Viewer)

azzuro

Test Group
  • Team MediaPortal
  • May 10, 2007
    9,948
    5,617
    France - IDF
    Home Country
    France France
    MediaPortal Version: 1.3.0 Beta

    Description
    Trying to reproduce "Bug report" from here, about search letter with remote Numpad.
    I have tried same function with ALL DB-music Views.
    ALL views : ShareViews > TOP100 (album is really broken)

    the "BUG" :
    When Press numpad on all view: only one (1) letter show for search
    example : if you want search "CHRIS"
    NUMPAD2 = 3times -> C {C} in skin
    NUMPAD4 = 2times -> H {H} in skin / normally must be {CH}

    the real broken view is ALBUM, only first letter is show
    Not possible to search an album if 1st letter is B / C / E / F ... or Number !

    This bug is only with Numpad, Keyboard letter are no problem.
    only album view can't set a number.

    Base test :
    NUMPAD KEYBOARD (not have remote on workstation)
    MP 1.3 SVN (2012 12 29)

    Steps to Reproduce:
    Go to Mymusic,
    select a view, (all view has same issue)
    (in filelist, click on Numpad for search title/artist/folder,)
    Press Numpad 2 for show A/B/C/2 {C}
    press Numpad 4 for show H -> {C} is erased for show only {H}

    Mantis :
    http://mantis.team-mediaportal.com/view.php?id=4077 : mentions list & icon view
    http://mantis.team-mediaportal.com/view.php?id=3668 : mentions cover flow.
     
    Last edited:

    HomeY

    Test Group
  • Team MediaPortal
  • February 23, 2008
    6,475
    4,645
    48
    ::1
    Home Country
    Netherlands Netherlands
    I can confirm this for both MyMusic & MyVideos. Nice find!
     
    Last edited:

    mbuzina

    Retired Team Member
  • Premium Supporter
  • April 11, 2005
    2,839
    726
    Germany
    Home Country
    Germany Germany
    I thought this Happens only in cover flow? There is an existing issue about that.
     

    HomeY

    Test Group
  • Team MediaPortal
  • February 23, 2008
    6,475
    4,645
    48
    ::1
    Home Country
    Netherlands Netherlands
    3668 mentions list & icon view
    4077 mentions cover flow.

    So might be broken in more views. (For me it was list view)
     

    Deda

    Lead Dev MP1 Videos
  • Premium Supporter
  • March 18, 2009
    2,423
    2,385
    Zagreb
    Home Country
    Croatia Croatia
    Who has VS (visual studio) and current GIT master, let try to replace those 2 source files and check SMS search

    Unified diffs:

    Code:
    mediaportal/WindowPlugins/WindowPluginBase.cs |    2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)
     
    diff --git a/mediaportal/WindowPlugins/WindowPluginBase.cs b/mediaportal/WindowPlugins/WindowPluginBase.cs
    index a1f2636..6d7a19e 100644
    --- a/mediaportal/WindowPlugins/WindowPluginBase.cs
    +++ b/mediaportal/WindowPlugins/WindowPluginBase.cs
    @@ -206,7 +206,7 @@ namespace WindowPlugins
              message.Message == GUIMessage.MessageType.GUI_MSG_CLICKED)
          {
            // Respond to the correct control.  The value is retrived directly from the control by the called handler.
    -        if (message.TargetControlId == btnLayouts.GetID)
    +        if (message.SenderControlId == btnLayouts.GetID)
            {
              // Set the new layout and select the currently selected item in the layout.
              SetLayout((Layout)btnLayouts.SelectedItemValue);

    Code:
    mediaportal/Core/guilib/GUICoverFlow.cs |    6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)
     
    diff --git a/mediaportal/Core/guilib/GUICoverFlow.cs b/mediaportal/Core/guilib/GUICoverFlow.cs
    index 434b9ff..3725095 100644
    --- a/mediaportal/Core/guilib/GUICoverFlow.cs
    +++ b/mediaportal/Core/guilib/GUICoverFlow.cs
    @@ -784,7 +784,7 @@ namespace MediaPortal.GUI.Library
            _currentKey = (char)0;
            _timerKey = DateTime.Now;
          }
    -      if (Key == '#' || Key == '§')
    +      else if (Key == '#' || Key == '§')
          {
            _timerKey = DateTime.Now;
          }
    @@ -2163,8 +2163,8 @@ namespace MediaPortal.GUI.Library
     
        private void ResetSearchString()
        {
    -      _previousKey = (char)0;
    -      _currentKey = (char)0;
    +      //_previousKey = (char)0;
    +      //_currentKey = (char)0;
          _searchString = "";
     
          UpdateProperties();

    This should (hope so) repair coverflow SMS issue and MyPics SMS bug (http://mantis.team-mediaportal.com/view.php?id=4059)
     

    Attachments

    • mediaportal.rar
      16.5 KB
    Last edited:

    Deda

    Lead Dev MP1 Videos
  • Premium Supporter
  • March 18, 2009
    2,423
    2,385
    Zagreb
    Home Country
    Croatia Croatia
    Last edited:

    Wo0zy

    Retired Team Member
  • Premium Supporter
  • April 30, 2008
    394
    134
    Home Country
    United Kingdom United Kingdom
    Would be nice to get one fix or another into 1.3 rc! :).

    This bug has been hanging around for a while now.

    Thanks for picking it up guys.

    @Deda. You the man :).

    Seasons greetings to all.

    Mick.
     

    Users who are viewing this thread

    Top Bottom