No indication of overlapping recording broadcastings (1 Viewer)

[mm1352000]

That's it, I'm convinced that Sebastiii's fix is wrong. It completely breaks conflict detection for anybody that has more than one tuner.

To fix this problem I would revert these commits:
https://github.com/MediaPortal/MediaPortal-1/commit/00d04a7f4877aaf405c066f4077b99b9fb0aa2c4
https://github.com/MediaPortal/MediaPortal-1/commit/0c63c005c06678dc7be9d6040d8d519cb5c78a1e

Then to fix the problem reported here that the above commits were designed to fix, I would simply remove this "break;" line:
https://github.com/MediaPortal/Medi...tabase/TvBusinessLayer/BusinessLayer.cs#L2999

While I was looking at that code, I'd also fix another terrible bug.
Remove isSameTransponder() from the Schedule class in the TVDatabase project and replace the references to it with a call to this function, which should be placed in the TvBusinessLayer:

  /// <summary>
  /// checks if 2 schedules have a common Transponder
  /// depending on tuningdetails of their respective channels
  /// </summary>
  /// <param name="schedule"></param>
  /// <returns>True if a common transponder exists</returns>
  public bool isSameTransponder(Schedule schedule1, Schedule schedule2)
  {
    IList<TuningDetail> tuningDetailList1 = schedule1.ReferencedChannel().ReferringTuningDetail();
    IList<TuningDetail> tuningDetailList2 = schedule2.ReferencedChannel().ReferringTuningDetail();
    foreach (TuningDetail td1 in tuningDetailList1)
    {
      IChannel c1 = GetTuningChannel(td1);
      foreach (TuningDetail td2 in tuningDetailList2)
      {
        if (!c1.IsDifferentTransponder(GetTuningChannel(td2)))
        {
          return true;
        }
      }
    }
    return false;
  }

 

[Sebastiii]

Thanks m8
Like that one line of code can break anything (i mean to have the real fix)
Good to know that you take time to look on it

 

[melmak21]

@Sebastiii
tell me what i have to do. have i to download the 199022_TvBusinessLayer_Conflict.zip-file and to unpack this into the mediaportal-folder or the TV-server-folder? And thats all? Or must this file fixed before by you for MP1.9Final?

 

[Sebastiii]

Good question
1.9 is broken so it seems and then need a rework/revert to make it work based on mm comment

 

[Sebastiii]

I just build dll with mm comment but not the part about terrible bug because i don't know what to do with 'schedule1' and 'schedule2' for :

bool isSameTransponder = (schedule.isSameTransponder(assignedSchedule) && card.supportSubChannels);

 

[regeszter]

Is there a JIRA for this?

 

[HomeY]

Is there a JIRA for this?

Nope, but not needed in this case.
I'll set the thread to BUG, link this thread to the MP1-4501 issue and reopen that issue.

 

[mm1352000]

i don't know what to do with 'schedule1' and 'schedule2' for :
bool isSameTransponder = (schedule.isSameTransponder(assignedSchedule) && card.supportSubChannels);

Change to:

bool isSameTransponder = (isSameTransponder(schedule, assignedSchedule) && card.supportSubChannels);

 

[Sebastiii]

Hi,

I hope it's the correct change lol

 

[melmak21]

@Sebastiii
Thank you! But how do i install these patch?