OnlineVideos 2.5.0.1 [2024/11/17] (10 Viewers)

[offbyone]

Thanks good info! Is there a branch or changeset I can merge to Onlinevideos for MP 1.16 compatibility?

 

[Ministerk]

Thanks good info! Is there a branch or changeset I can merge to Onlinevideos for MP 1.16 compatibility?

@Sebastiii ?
Also there's info in the internal 1.16 Pre release thread

Edit:
Maybe head of master?

 

[Sebastiii]

I will attach the patch here asap that permit to fix the playback for 1.16 (related to madVR change)
Thanks Guys

 

[Sebastiii]

Here we go
It's a global patch where i get some issues :

So :
1- Upgrade Bump version for madVR
2- Remove illegal character when download video and change handle for madVR (not a really good patch but solve downloading trailer with wrong char)
3- MadVR and build (Change the code to have OV working with EVR and madVR)

Thanks

 

[doskabouter]

Couple of remarks for your patch:
- Instead of manually fixing the titles, there is a FileUtils.GetSaveFilename which does the job
- The xmp2 changes are not needed
The rest seems ok (unable to test, so I'll take your word for it to work )

 

[Sebastiii]

Couple of remarks for your patch:
- Instead of manually fixing the titles, there is a FileUtils.GetSaveFilename which does the job
- The xmp2 changes are not needed
The rest seems ok (unable to test, so I'll take your word for it to work )

I remember has trying the method but maybe i did it wrongly because it wasn't working, so i will retry
About the xmp2, you are right, it's only for me OV source are on different hdd. (maybe we can change it to "%ProgramFiles(x86)%" instead ?
Thanks

 

[Sebastiii]

Couple of remarks for your patch:
- Instead of manually fixing the titles, there is a FileUtils.GetSaveFilename which does the job
- The xmp2 changes are not needed
The rest seems ok (unable to test, so I'll take your word for it to work )

I just retry with your method and it works
Thanks.

Reverted previous code and just added line 4 and 5 (so to remove illegal char like " : "

            if (string.IsNullOrEmpty(saveItems.CurrentItem.Title)) saveItems.CurrentItem.Title = saveItems.CurrentItem.VideoInfo.Title;

            // Replace illegal char
            saveItems.CurrentItem.VideoInfo.Title = FileUtils.GetSaveFilename(saveItems.CurrentItem.Title);

            if (!string.IsNullOrEmpty(saveItems.CurrentItem.OverrideFolder))

 

[Sebastiii]

Attached is the patch against latest changes

 

[offbyone]

Committed and Pushed, thx Sebastiii!

@morpheus_xx : You can now merge your changes that are required to work with the upcoming MP2 release. I have already increased the API version of OnlineVideos to 2.3.

Let's get a working OV version out for the new MP1 and MP2 releases before x-mas

 

[morpheus_xx]

Thanks! I will merge the pending stuff this evening