[Approved] Option to disable 'Stop live TV' dialog (1 Viewer)

jonywee

Portal Member
September 7, 2007
21
19
Netherlands Netherlands
Hi,

Here is a patch for the feature request to disable the 'Do you want to stop live TV' dialog. This is the feature request: https://forum.team-mediaportal.com/...option-to-disable-stop-live-tv-dialog.102684/

Details about the patch:
  1. Added the checkbox Ask confirmation when stopping timeshift to the TV Client section in Configuration.exe. Should be self-describing in this context. The default value is true, so it will leave the current behaviour unchanged.

    The General settings tab in the TV Client section does not have much free space, so I found it difficult to find a good spot for the checkbox. I ended up with this: The checkbox is added to the TsReader options group (TsReader is the one using the timeshift buffer). The TV-Server and Group options groups are now placed next to eachother, to create some free space. Not sure if this all makes sense, so feel free to suggest alternatives. This is how it looks with the patch:
    TVClientGeneralSettings.png
  2. Changed the TvPlugin to only ask for confirmation when the above setting is active. When the configuration checkbox is unchecked, live TV will just stop when pressing single stop on the remote.
UPDATE:
Mantis: http://mantis.team-mediaportal.com/view.php?id=4238 (thanks to Holzi)
GIT branch: https://github.com/MediaPortal/MediaPortal-1/tree/FEAT-4238-Option_to_disable_Stop_live_TV_dialog (thanks to Oxan)

UPDATE :
New Branch Updated against master :)
 
Last edited by a moderator:

Holzi

Super Moderator
  • Team MediaPortal
  • April 21, 2010
    7,930
    2,234
    Ba-Wü
    Germany Germany
    Country flag
    Thanks for making this patch! Hopefully it will get the attention of our @Developers and they could create a GIT branch for testing. :)
     
    Last edited:

    Oxan

    Retired Team Member
  • Premium Supporter
  • August 29, 2009
    1,730
    1,124
    Netherlands Netherlands
    Great! The dialog has been annoying me as well, so let's see if we can get this into MediaPortal.

    I've created a git branch with the patch, FEAT_Optional_stop_live_TV_dialog. However, I'm not really sure what the process for getting it merged to MP1 currently is. I suppose I should create a Mantis issue now?
     

    momeijer

    Portal Member
    February 16, 2011
    33
    10
    Netherlands Netherlands
    Thanks for your effort jonywee!

    I made the feature request and after examining the latest answers I tried to do something. Spend some hours searching the code with 'search & replace' until realizing it would be better practicing 'hello world' coding tutorials. ;-)

    I hope this function will end up in one of the future MP versions. To my knowledge there is a lot of TV-Server - timeshifting - tswriter - <possible stuff> - tsreader technology behind this. Maybe MP developers and testers are too protective? ;-) In a way the dialog could be replaced with something like "Do you have any clue what you are doing? You are throwing away timeshift files. You can pause, rewind, forward movies, series, music, we offer all exact moments of your irrational and not-understood stops in our memory buffers and databases. But this? We need to ask your confirmation again because we understand that the wife, cat or dog could sit on or drop the remote control and you will miss the timeshifted world ..<fill in>.. series or worse.... (..fill in..)

    The opportunity to make mistakes without technology nagging about it. Can I at least have the illusion that we have any control over it?

    In theory it's a nice and welcome functionality. But I prefer a choice in foolishness instead of daily confrontation with STOP ....Are You sure?(Y/N)?

    Thanks! ;-)

    Michael
     

    Users Who Are Viewing This Thread (Users: 0, Guests: 1)

    OP Similar threads Forum Replies Date
    H 1.24.0 MP 1.24 high CPU utilization when 'Keep MediaPortal always on top' option enabled Bugreports 4
    horned_reaper [solved] FanartHandler: Duplication options Fanart Handler 0
    raffe [TV] Option for adding IPTV channels without checking Improvement Suggestions 0
    doskabouter [Question] Optional installation of subcomponents in MPE1 Developer Discussions 1
    Neoculture "Recently Added" option My TVSeries 8
    N What do the series recording options mean, and why is MP2 recording random programs? General 3
    HTPCSourcer [Finished] [MP2-793] 'Restart MP2' as additional option in shutdown menu Archive 6
    N Option to "Filter" Images by folder name Feature Requests 8
    J Option to rename the programs during advance scheduling Feature Requests 0
    Rob Hexenmeister Shutdown options General Support 0
    M [solved] Can't get TV option on installation Installation, configuration support 10
    G Splash screen option pack does not download. StreamedMP 8
    O [Question] Advice Wanted on Developing a Client Application for a Disabled Family Member MPExtended 7
    brena MCE Remote Disable Volume Mapping Input / Output interfaces 0
    cbr954rr How to disable a pre-configured plugin? General 2
    Steve.Rayner61 Online Videos - Automatic Updates fails 'Automatic update disabled. Check your internet connection' OnlineVideos 10
    M How do you disable USB drives from being detected by MP? General Support 0
    W Blu-ray chapter popups when watching from "Menu" - any way to disable them? watch/edit Videos 1
    toricred Using TMM, How to Stop Importer From Going to The Movie Database for Data General 1
    mickb [solved] Mediaportal Stops working General Support 5
    D [solved] Movie artwork download stopped working Submit: Bug Reports 9
    M MP 2.2.3 Unable to play .ts recordings and MediaPortal stops working for TV viewing General 31
    ajs [solved] 4982: Why this error hard stop when Mediaportal start? MediaPortal 1 3
    rsbrux IR has stopped working Remotes 4
    2BitSculptor MP 1.23.. music stops playing General Support 6
    Similar threads

























    Top Bottom