[Approved] - Option to disable 'Stop live TV' dialog

Discussion in 'Submit: code patches (MediaPortal/TV-Server/etc.)' started by jonywee, February 10, 2013.

  1. jonywee

    jonywee Portal Member

    Joined:
    September 7, 2007
    Messages:
    21
    Likes Received:
    19
    Ratings:
    +19 / 0
    Home Country:
    Netherlands Netherlands
    Hi,



    Here is a patch for the feature request to disable the 'Do you want to stop live TV' dialog. This is the feature request: https://forum.team-mediaportal.com/...option-to-disable-stop-live-tv-dialog.102684/

    Details about the patch:
    1. Added the checkbox Ask confirmation when stopping timeshift to the TV Client section in Configuration.exe. Should be self-describing in this context. The default value is true, so it will leave the current behaviour unchanged.

      The General settings tab in the TV Client section does not have much free space, so I found it difficult to find a good spot for the checkbox. I ended up with this: The checkbox is added to the TsReader options group (TsReader is the one using the timeshift buffer). The TV-Server and Group options groups are now placed next to eachother, to create some free space. Not sure if this all makes sense, so feel free to suggest alternatives. This is how it looks with the patch:
      TVClientGeneralSettings.png
    2. Changed the TvPlugin to only ask for confirmation when the above setting is active. When the configuration checkbox is unchecked, live TV will just stop when pressing single stop on the remote.
    UPDATE:
    Mantis: http://mantis.team-mediaportal.com/view.php?id=4238 (thanks to Holzi)
    GIT branch: https://github.com/MediaPortal/MediaPortal-1/tree/FEAT-4238-Option_to_disable_Stop_live_TV_dialog (thanks to Oxan)

    UPDATE :
    New Branch Updated against master :)
     
    Last edited by a moderator: April 7, 2013
    • Like Like x 16
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. Holzi
    • Team MediaPortal

    Holzi Super Moderator

    Joined:
    April 21, 2010
    Messages:
    7,928
    Likes Received:
    1,591
    Gender:
    Male
    Location:
    Ba-Wü
    Ratings:
    +2,228 / 8
    Home Country:
    Germany Germany
    Show System Specs
    Thanks for making this patch! Hopefully it will get the attention of our @Developers and they could create a GIT branch for testing. :)
     
    Last edited: February 10, 2013
    • Like Like x 1
  4. Oxan
    • Premium Supporter

    Oxan Retired Team Member

    Joined:
    August 29, 2009
    Messages:
    1,730
    Likes Received:
    1,024
    Gender:
    Male
    Ratings:
    +1,115 / 2
    Home Country:
    Netherlands Netherlands
    Great! The dialog has been annoying me as well, so let's see if we can get this into MediaPortal.

    I've created a git branch with the patch, FEAT_Optional_stop_live_TV_dialog. However, I'm not really sure what the process for getting it merged to MP1 currently is. I suppose I should create a Mantis issue now?
     
    • Like Like x 2
  5. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,296
    Likes Received:
    6,248
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,269 / 9
    Home Country:
    France France
    Show System Specs
    Yep Mantis and set to 1.3.1 i think :)
     
  6. powermarcel10
    • Premium Supporter

    powermarcel10 Retired Team Member

    Joined:
    November 30, 2010
    Messages:
    2,839
    Likes Received:
    789
    Gender:
    Male
    Occupation:
    Callcenter Agent
    Location:
    Groningen
    Ratings:
    +1,028 / 4
    Home Country:
    Netherlands Netherlands
    Show System Specs
  7. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,296
    Likes Received:
    6,248
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,269 / 9
    Home Country:
    France France
    Show System Specs
    at this stage, only big issue can be committed :) but we hope it will done right after final.
     
    • Like Like x 3
  8. momeijer

    momeijer Portal Member

    Joined:
    February 16, 2011
    Messages:
    33
    Likes Received:
    10
    Ratings:
    +10 / 0
    Home Country:
    Netherlands Netherlands
    Show System Specs
    Thanks for your effort jonywee!

    I made the feature request and after examining the latest answers I tried to do something. Spend some hours searching the code with 'search & replace' until realizing it would be better practicing 'hello world' coding tutorials. ;-)

    I hope this function will end up in one of the future MP versions. To my knowledge there is a lot of TV-Server - timeshifting - tswriter - <possible stuff> - tsreader technology behind this. Maybe MP developers and testers are too protective? ;-) In a way the dialog could be replaced with something like "Do you have any clue what you are doing? You are throwing away timeshift files. You can pause, rewind, forward movies, series, music, we offer all exact moments of your irrational and not-understood stops in our memory buffers and databases. But this? We need to ask your confirmation again because we understand that the wife, cat or dog could sit on or drop the remote control and you will miss the timeshifted world ..<fill in>.. series or worse.... (..fill in..)

    The opportunity to make mistakes without technology nagging about it. Can I at least have the illusion that we have any control over it?

    In theory it's a nice and welcome functionality. But I prefer a choice in foolishness instead of daily confrontation with STOP ....Are You sure?(Y/N)?

    Thanks! ;-)

    Michael
     
    • Like Like x 1
  9. Quarter
    • Super User

    Quarter Super User

    Joined:
    June 21, 2010
    Messages:
    722
    Likes Received:
    110
    Gender:
    Male
    Location:
    Queenstown
    Ratings:
    +141 / 2
    Home Country:
    New Zealand New Zealand
    Show System Specs
    Double stop and you don't see the dialog, To be honest this is really not needed.
     
  10. powermarcel10
    • Premium Supporter

    powermarcel10 Retired Team Member

    Joined:
    November 30, 2010
    Messages:
    2,839
    Likes Received:
    789
    Gender:
    Male
    Occupation:
    Callcenter Agent
    Location:
    Groningen
    Ratings:
    +1,028 / 4
    Home Country:
    Netherlands Netherlands
    Show System Specs
    Well, there are a lot of requests for this so why not.. And pressing only one time is always better than pressing 2 times.. ;)
     
    • Like Like x 1
  11. Holzi
    • Team MediaPortal

    Holzi Super Moderator

    Joined:
    April 21, 2010
    Messages:
    7,928
    Likes Received:
    1,591
    Gender:
    Male
    Location:
    Ba-Wü
    Ratings:
    +2,228 / 8
    Home Country:
    Germany Germany
    Show System Specs
    • Like Like x 2
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!