[Approved] Options for basic+normal home, only normal home and only basic home (1 Viewer)

[disaster123]

AW: Options for basic+normal home, only normal home and only basic home

Marvman
sorry no c# skills on my side so i wasn't to implement an ENUM... but i thought the same.

 

[Marvman]

Forget the private ENUM you use it in more than one class.

enum Mode
{
HOME, BASIC, BOTH
}

HOME is per default 0 so you should use it as id

further infos you'll get here

 

[disaster123]

AW: Options for basic+normal home, only normal home and only basic home

Sorry i know what an enum is and how to use but i don't know how / where to implement in MP so that it can be used by different classes. I didn't want to implement the ENUM in every file i've modified.

 

[DieBagger]

just use it outside of the class definition or in its own file...

 

[Marvman]

You can create a separate file in core/guilib or create the public enum in GUIWindowManager.cs

I prefer the first.

 

[disaster123]

AW: Options for basic+normal home, only normal home and only basic home

OK will post a better patch in 3 weeks - i'm on holidays now.

 

[arion_p]

The patch has been applied (somewhat modified) to SVN 26329.
for contributing to MediaPortal.

 

[OnkelChris]

AW: Options for basic+normal home, only normal home and only basic home

arion_p:
just wanted to mention, that unfortunately the (modified) patch has a little bad behaviour... if you choose "only basichome", start MP and the first button is "back", then you get the normal homescreen.
i remember, that with the patch provided by disaster123 it's working correct.

 

[disaster123]

AW: Options for basic+normal home, only normal home and only basic home

OnkelChris
Do you also see strange TsReader Errors while watching tv in your error.log (i have that but not shure which patch caused that).

 

[arion_p]

Re: AW: Options for basic+normal home, only normal home and only basic home

@arion_p:
just wanted to mention, that unfortunately the (modified) patch has a little bad behaviour... if you choose "only basichome", start MP and the first button is "back", then you get the normal homescreen.
i remember, that with the patch provided by disaster123 it's working correct.

I can confirm the issue. Are you sure it did not occur with the original patch? I don't see anything in the code relating to that.