[Approved] Patch to fix GUIMultiImage (1 Viewer)

[Harley]

Hi pilehave,

it seems this patch causes some more issues and problems with multiimages.
Can you please contact cul8er and Pretoriano because the broken things.

Is this patch realy importand and who is realy need it ? If it is not so importand or only for one guy, we should think over to rewert the stuff, to get back full working solutions in the skins.

In fact, i have not see any stuff that need that funktion. Can you please do a short explain for what Plugin it is needed and who is realy use this funktion. So we can better decide, if we need it or not.


Greetings Harley

 

[catavolt]

^+1

 

[pilehave]

The attached patch should correct the problem while keeping the new features.

Please test it out.

:sorry:

 

[cul8er]

Hi,

Thank you for this fix pilehave. Manfred created a new core.dll file that I have tested (thank you very much for this). I have tested it and now multiimage works as before when it comes to the animation/visibility problem that I reported earlier to you pilehave. Thank you to everyone that helped fixing this.

Best Regards
cul8er

 

[-Manfred-]

Thanks for fixing this and also thanks to verifying this. Added to SVN 23657.

And to pilehave: try to double check these patches. Needed to adjust this (double definition of variable values, extra lines etc.). Skinners are demanding people and don't like bugs at all

 

[pilehave]

I am a skinner myself so I get your point.

(wee, 1000 posts)

 

[tourettes]

Skinners are demanding people and don't like bugs at all

And don't forget me

 

[joz]

Thanks guys for spending some time fixing this bugger

 

[pilehave]

Well, there must be a bug in the version that was made out of my original patch, since

GUIPropertyManager.SetProperty(property, value);

only works one time. If you try and set it or change it it just blanks the screen. There were quite a lot of changes in the latest patch I supplied before it was added to SVN, and I can see that bavarian have made even more changes. To be honest, I cannot tell where the problem is, since it differs so much from the version I originally supplied.

 

[pilehave]

The attached patch should fix my problem. Looks like _isAllocated was never reset + _newPath was always set to _texturePath.
Setting _isAllocated and commenting out the _newPath = _texturePath seems to do the work.

Could someone else (bavarian?) take a look at my fix and tell if its inproper?:

Index: GUIMultiImage.cs
===================================================================
--- GUIMultiImage.cs	(revision 23852)
+++ GUIMultiImage.cs	(working copy)
@@ -198,7 +198,7 @@
             _newPath = "";
           }
           _cachedPath = _newPath;
-
+          _isAllocated = false;
         }
         if (_cachedPath == null)
         {
@@ -292,14 +292,14 @@
         }
         if (_registeredForEvent == false)
         {
-          GUIPropertyManager.OnPropertyChanged += GUIPropertyManager_OnPropertyChanged; 
+          GUIPropertyManager.OnPropertyChanged += GUIPropertyManager_OnPropertyChanged;
           _registeredForEvent = true;
         }
         _currentImage = 0;
         _Info = 0;
         _directoryLoaded = false;
         _isAllocated = false;
-        _newPath = _texturePath;
+        //_newPath = _texturePath;
         FreeResources();
         base.AllocResources();
       }