Reply to thread

Message

<blockquote data-quote="FreakyJ" data-source="post: 1158877" data-attributes="member: 106003">In fact it does: [CODE=C#]public static Stream ExtractImage(MediaSource source, long position, int? maxWidth, int? maxHeight, string borders, string format)&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (!source.Exists)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Log.Warn(&quot;ExtractImage: Source {0} (resolved to path {1}) doesn't exists&quot;, source.GetDebugName(), source.GetPath());&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; WCFUtil.SetResponseCode(System.Net.HttpStatusCode.NotFound);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return Stream.Null;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (!source.SupportsDirectAccess)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Log.Warn(&quot;ExtractImage: Extracting images from remote sources isn't supported yet&quot;, source.MediaType, source.Id);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; WCFUtil.SetResponseCode(System.Net.HttpStatusCode.NotImplemented);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return Stream.Null;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; // get temporary filename&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; string filename = String.Format(&quot;extract_{0}_{1}.jpg&quot;, source.GetUniqueIdentifier(), position);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; string tempFile = cache.GetPath(filename);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; // maybe it exists in cache, return that then&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (cache.Contains(filename))&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; // if source is newer, cached image needs to be recreated&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (source.GetFileInfo().LastModifiedTime &gt; cache.GetLastModifiedTime(tempFile))&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; cache.Invalidate(filename);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; else&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return StreamPostprocessedImage(new ImageMediaSource(tempFile), maxWidth, maxHeight, borders, format);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; // We need to impersonate to access the network drive and check if the thumbnail already exists. However, because&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; // impersonation is lost when starting a process, we can't start ffmpeg from in here. We need to check whether the&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; // file is accessible from outside the impersonation context again, and start the ffmpeg process as a different user&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; // if that is the case.&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; string fullPath;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; using (var context = source.CreateNetworkContext())&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; fullPath = context.RewritePath(source.GetPath());&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; // stream a pre-existing thumbnail, if possible&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (source.MediaType == WebMediaType.Recording &amp;&amp; Path.GetExtension(fullPath).ToLower() == &quot;.ts&quot;)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; var thumbnailFileInfo = new FileInfo(Path.ChangeExtension(fullPath, &quot;.jpg&quot;));&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (thumbnailFileInfo.Exists &amp;&amp; thumbnailFileInfo.Length &gt; 0)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return StreamPostprocessedImage(new ImageMediaSource(thumbnailFileInfo.FullName), maxWidth, maxHeight, borders, format);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; // finally, extract the image with ffmpeg if everything else has failed&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; bool extractResult = ExecuteFFMpegExtraction(source, fullPath, position, tempFile);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (!extractResult)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; WCFUtil.SetResponseCode(System.Net.HttpStatusCode.InternalServerError);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return Stream.Null;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return StreamPostprocessedImage(new ImageMediaSource(tempFile), maxWidth, maxHeight, borders, format);&nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; private static bool ExecuteFFMpegExtraction(MediaSource source, string path, long position, string tempFile)&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; var info = new ProcessStartInfo();&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; info.Arguments = String.Format(&quot;-ss {0} -i \&quot;{1}\&quot; -vframes 1 -vf \&quot;yadif,scale=ih*dar:ih\&quot; -f image2 \&quot;{2}\&quot;&quot;, position, path, tempFile);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; info.FileName = Configuration.StreamingProfiles.FFMpegPath;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; info.CreateNoWindow = true;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; info.UseShellExecute = false;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; info.RedirectStandardError = Log.IsEnabled(LogLevel.Trace);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; info.RedirectStandardOutput = Log.IsEnabled(LogLevel.Trace);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; TranscoderProcess proc = new TranscoderProcess();&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; proc.StartInfo = info;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (source.NeedsImpersonation)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; proc.StartAsUser(Configuration.Services.NetworkImpersonation.Domain, Configuration.Services.NetworkImpersonation.Username, Configuration.Services.NetworkImpersonation.GetPassword());&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; else&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; proc.Start();&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (Log.IsEnabled(LogLevel.Trace))&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Log.Trace(&quot;ExtractImage: executing path={0} arguments={1}&quot;, info.FileName, info.Arguments);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; StreamCopy.AsyncStreamRead(proc.StandardError, l =&gt; Log.Trace(&quot;ExtractImage: stderr: {0}&quot;, l));&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; StreamCopy.AsyncStreamRead(proc.StandardOutput, l =&gt; Log.Trace(&quot;ExtractImage: stdout: {0}&quot;, l));&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; proc.WaitForExit();&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (!File.Exists(tempFile))&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Log.Warn(&quot;Failed to extract image from {0} with {1} {2}&quot;, source.GetDebugName(), info.FileName, info.Arguments);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return false;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return true;&nbsp; &nbsp; &nbsp; &nbsp; }[/CODE]</blockquote>

[QUOTE="FreakyJ, post: 1158877, member: 106003"] In fact it does: [CODE=C#]public static Stream ExtractImage(MediaSource source, long position, int? maxWidth, int? maxHeight, string borders, string format) { if (!source.Exists) { Log.Warn("ExtractImage: Source {0} (resolved to path {1}) doesn't exists", source.GetDebugName(), source.GetPath()); WCFUtil.SetResponseCode(System.Net.HttpStatusCode.NotFound); return Stream.Null; } if (!source.SupportsDirectAccess) { Log.Warn("ExtractImage: Extracting images from remote sources isn't supported yet", source.MediaType, source.Id); WCFUtil.SetResponseCode(System.Net.HttpStatusCode.NotImplemented); return Stream.Null; } // get temporary filename string filename = String.Format("extract_{0}_{1}.jpg", source.GetUniqueIdentifier(), position); string tempFile = cache.GetPath(filename); // maybe it exists in cache, return that then if (cache.Contains(filename)) { // if source is newer, cached image needs to be recreated if (source.GetFileInfo().LastModifiedTime > cache.GetLastModifiedTime(tempFile)) { cache.Invalidate(filename); } else { return StreamPostprocessedImage(new ImageMediaSource(tempFile), maxWidth, maxHeight, borders, format); } } // We need to impersonate to access the network drive and check if the thumbnail already exists. However, because // impersonation is lost when starting a process, we can't start ffmpeg from in here. We need to check whether the // file is accessible from outside the impersonation context again, and start the ffmpeg process as a different user // if that is the case. string fullPath; using (var context = source.CreateNetworkContext()) { fullPath = context.RewritePath(source.GetPath()); // stream a pre-existing thumbnail, if possible if (source.MediaType == WebMediaType.Recording && Path.GetExtension(fullPath).ToLower() == ".ts") { var thumbnailFileInfo = new FileInfo(Path.ChangeExtension(fullPath, ".jpg")); if (thumbnailFileInfo.Exists && thumbnailFileInfo.Length > 0) return StreamPostprocessedImage(new ImageMediaSource(thumbnailFileInfo.FullName), maxWidth, maxHeight, borders, format); } } // finally, extract the image with ffmpeg if everything else has failed bool extractResult = ExecuteFFMpegExtraction(source, fullPath, position, tempFile); if (!extractResult) { WCFUtil.SetResponseCode(System.Net.HttpStatusCode.InternalServerError); return Stream.Null; } return StreamPostprocessedImage(new ImageMediaSource(tempFile), maxWidth, maxHeight, borders, format); } private static bool ExecuteFFMpegExtraction(MediaSource source, string path, long position, string tempFile) { var info = new ProcessStartInfo(); info.Arguments = String.Format("-ss {0} -i \"{1}\" -vframes 1 -vf \"yadif,scale=ih*dar:ih\" -f image2 \"{2}\"", position, path, tempFile); info.FileName = Configuration.StreamingProfiles.FFMpegPath; info.CreateNoWindow = true; info.UseShellExecute = false; info.RedirectStandardError = Log.IsEnabled(LogLevel.Trace); info.RedirectStandardOutput = Log.IsEnabled(LogLevel.Trace); TranscoderProcess proc = new TranscoderProcess(); proc.StartInfo = info; if (source.NeedsImpersonation) proc.StartAsUser(Configuration.Services.NetworkImpersonation.Domain, Configuration.Services.NetworkImpersonation.Username, Configuration.Services.NetworkImpersonation.GetPassword()); else proc.Start(); if (Log.IsEnabled(LogLevel.Trace)) { Log.Trace("ExtractImage: executing path={0} arguments={1}", info.FileName, info.Arguments); StreamCopy.AsyncStreamRead(proc.StandardError, l => Log.Trace("ExtractImage: stderr: {0}", l)); StreamCopy.AsyncStreamRead(proc.StandardOutput, l => Log.Trace("ExtractImage: stdout: {0}", l)); } proc.WaitForExit(); if (!File.Exists(tempFile)) { Log.Warn("Failed to extract image from {0} with {1} {2}", source.GetDebugName(), info.FileName, info.Arguments); return false; } return true; }[/CODE] [/QUOTE]

Verification