Reply to thread

Message

<blockquote data-quote="FreakyJ" data-source="post: 1160276" data-attributes="member: 106003">Hmm, you use VideoAspect.Metadata instead of VideoAspect.ASPECT_ID now. Any reason for that?Another change is that you use GetAttributeValue to get the values. Is there a reason for that? I mean it was basically a Dictionary before and it was less writing to just access the dictionary.I mean:item.Aspects[MediaAspect.ASPECT_ID].GetAttributeValue(MediaAspect.ATTR_RECORDINGTIME)).Yearvs:item[MediaAspect.Metadata].GetAttributeValue(MediaAspect.ATTR_RECORDINGTIME)).YearI don't really understand the reason of these changes. Sorry for that. I just would like to understand that <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite1" alt=":)" title="Smile&nbsp; &nbsp; :)" loading="lazy" data-shortname=":)" />Also this:var ImdbId = movieAspects[MovieAspect.ATTR_IMDB_ID];vs:var ImdbId = MediaItemAspect.GetExternalAttribute(item.Aspects, ExternalIdentifierAspect.SOURCE_IMDB, ExternalIdentifierAspect.TYPE_MOVIE);Any reason for the change? I gues probably the MIA rework, but there must be some fundamental differences?Otherwise you run a resharper code cleanup to remove all the unused references^^But the changes to MP2Ext are pretty straight forward, right? Because I moved most Media Library related things to a base class which get accessed over and over again.I hope you don't have too much compile errors left <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite8" alt=":D" title="Big Grin&nbsp; &nbsp; :D" loading="lazy" data-shortname=":D" /></blockquote>

[QUOTE="FreakyJ, post: 1160276, member: 106003"] Hmm, you use VideoAspect.Metadata instead of VideoAspect.ASPECT_ID now. Any reason for that? Another change is that you use GetAttributeValue to get the values. Is there a reason for that? I mean it was basically a Dictionary before and it was less writing to just access the dictionary. I mean: item.Aspects[MediaAspect.ASPECT_ID].GetAttributeValue(MediaAspect.ATTR_RECORDINGTIME)).Year vs: item[MediaAspect.Metadata].GetAttributeValue(MediaAspect.ATTR_RECORDINGTIME)).Year I don't really understand the reason of these changes. Sorry for that. I just would like to understand that :) Also this: var ImdbId = movieAspects[MovieAspect.ATTR_IMDB_ID]; vs: var ImdbId = MediaItemAspect.GetExternalAttribute(item.Aspects, ExternalIdentifierAspect.SOURCE_IMDB, ExternalIdentifierAspect.TYPE_MOVIE); Any reason for the change? I gues probably the MIA rework, but there must be some fundamental differences? Otherwise you run a resharper code cleanup to remove all the unused references^^ But the changes to MP2Ext are pretty straight forward, right? Because I moved most Media Library related things to a base class which get accessed over and over again. I hope you don't have too much compile errors left :D [/QUOTE]

Verification