[Plugin] WOL-PowerManager (4 Viewers)
- Thread starter seppi2204
- Start date
Belgium
Hi all,
As I'm a bit curious, I finally take a bit of my time to check how work this plugin. Thank you to share the code, it's very useful to understand the plugin!
I compiled the plugin by myself to add some information into the log to understand why I've got DNS error messages and why sometimes MP stay blocked if the server can't be reached.
I found 2 problems in the code :
1) The "UseIPInsteadDNS" settings is only used when the plugin check periodically the state of the server. When UseIPInsteadDNS is On, the ping is done only with IP adress.
When the plugin call the ping from other routine, it doesn't make any difference if UseIPInsteadDNS is on or not and use only DNS server name and also call a routine to check if the ip of this DNS has changed. That's why we received DNS errors.
2) In the wait routine, there's a bug when the plugin check the delay into the while loop. It check only the seconds! If the while loop is started at eg : 55sec it never reached the default 20sec because it substract nowtime with 55sec and we get a negative number. That's what block MP in my case (and sometimes not! depending when you try entering the window). The while loop never ended.
I made correction into the code to solve these problems. Hereby you'll find a corrected plugin dll based on last available version on google.code project. If someone want to test this version, just make a backup copy of the original one and place this corrected one into the right folder. This forum doesn't like .dll file, so the file is on a zip.
@seppi2204 : I also attach the corrected source file to show you in details what I've changed. All my modification are commented, just make a file compare to see where I made some changes. I hope that it's not a problem for you if I post a corrected dll. It's open source project
If it is a problem, just tell me and I'll remove it and other guys will wait your next release.
As I'm a bit curious, I finally take a bit of my time to check how work this plugin. Thank you to share the code, it's very useful to understand the plugin!
I compiled the plugin by myself to add some information into the log to understand why I've got DNS error messages and why sometimes MP stay blocked if the server can't be reached.
I found 2 problems in the code :
1) The "UseIPInsteadDNS" settings is only used when the plugin check periodically the state of the server. When UseIPInsteadDNS is On, the ping is done only with IP adress.
When the plugin call the ping from other routine, it doesn't make any difference if UseIPInsteadDNS is on or not and use only DNS server name and also call a routine to check if the ip of this DNS has changed. That's why we received DNS errors.
2) In the wait routine, there's a bug when the plugin check the delay into the while loop. It check only the seconds! If the while loop is started at eg : 55sec it never reached the default 20sec because it substract nowtime with 55sec and we get a negative number. That's what block MP in my case (and sometimes not! depending when you try entering the window). The while loop never ended.
I made correction into the code to solve these problems. Hereby you'll find a corrected plugin dll based on last available version on google.code project. If someone want to test this version, just make a backup copy of the original one and place this corrected one into the right folder. This forum doesn't like .dll file, so the file is on a zip.
@seppi2204 : I also attach the corrected source file to show you in details what I've changed. All my modification are commented, just make a file compare to see where I made some changes. I hope that it's not a problem for you if I post a corrected dll. It's open source project
If it is a problem, just tell me and I'll remove it and other guys will wait your next release.
Last edited by a moderator:
- Moderator
- #63
Hi m8,
You are really welcome to fix issues
I didn't use this plugins but hope that solve issue for other
Thanks to share your debugging / finding / explanation etc. and the source diff and dll
Seb.
You are really welcome to fix issues
I didn't use this plugins but hope that solve issue for other
Thanks to share your debugging / finding / explanation etc. and the source diff and dll
Seb.
What means "m8" in coded language? ;-)
- Thread starter
- #66
Hi TiboTV,
thank you for making these fixes. It's great to get help from the community. I couldn't find time to have a look at the code in the last days.
I made a new Package with your changes and I will release it as soon as the other users will confirm that the bug has been gone.
Here you can find the installer package https://code.google.com/p/wol-powermanager/downloads/detail?name=WOLPowerManager.mpe1&can=2&q=
thank you for making these fixes. It's great to get help from the community. I couldn't find time to have a look at the code in the last days.
I made a new Package with your changes and I will release it as soon as the other users will confirm that the bug has been gone.
Here you can find the installer package https://code.google.com/p/wol-powermanager/downloads/detail?name=WOLPowerManager.mpe1&can=2&q=
- Thread starter
- #68
Hey schwarzrz,
I didn't had a look at the code of this plugin for a long time. I also assume that it will not work with MePo 1.9 without doing some changes. But as from now the WOL-feature is integrated in MePo, which i guess makes this plugin deprecated.
Have a look at:
http://wiki.team-mediaportal.com/1_...1.7.x/Config_Tool_Changes/Wake_On_Lan_feature
I didn't had a look at the code of this plugin for a long time. I also assume that it will not work with MePo 1.9 without doing some changes. But as from now the WOL-feature is integrated in MePo, which i guess makes this plugin deprecated.
Have a look at:
http://wiki.team-mediaportal.com/1_...1.7.x/Config_Tool_Changes/Wake_On_Lan_feature
Hi, i disagree. I would be great to get this plugin work in 1.9 because i have all my films/series on a seperate server and i would like to wake this server up only if needed.
My TV-Server shuts down (goes asleep) if i am watching movies. If I switch back to TV, it would be great if the server gets a WOL-Command to wake up, as your plugin supposed to do.
I would really appreciate if the plugin would work with 1.9
Thanks in advance at seppi2004 if you make this effort.
(At the moment it works in 1.9 with the "old parameters" but no changes can be done / updated / saved as I described in me latest post)
Last edited: