Possible issue with reading ID3v1 tags (1 Viewer)

[mackey]

Hi!

In my work on the MyLyrics plugin Gaukaren pointed me in the direction that the tag reader has some issues with reading ID3v1 tags. And indeed it seems like it.

The MP tagreader returns additional [\0]'s - which it the code for a SPACE - on strings so they fill out 30 characters. There is no problem with ID3v2 tags.

Example ID3v2 tags
Tag.Artist = "Figurines"
Tag.Title = "Divided by the Shore"

Example ID3v1 tags
Tag.Artist = "Figurines\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0 \0"
Tag.Title = "Divided by the Shore\0\0\0\0\0\0\0\0\0\0"

This example is my example. Other users - or rather so I see from their log-files - have files with only one SPACE added in the end of the strings.

Accordingly no lyric can be found for music files only using the ID3v1 tag. I could remove all occurences of [\0] (or spaces) but it would natural be better to remove the spaces direcly in the tag reader. That is, if it is a fault... I know that the reader has been tested thoroughly. thanks

 

[hwahrmann]

Makey, i'll have a look at it next week.
need to finish some urgent daily work first

 

[hwahrmann]

just comitted the fix to SVN.
Please let me know, if it works for you now

 

[mackey]

just comitted the fix to SVN.
Please let me know, if it works for you now

It does. Thanks for the quick fix.

 

[idioteque]

I just tested the SVN patch but is stills does not fix my problem

SVN:
25/02/2007 [20:44:15] Bavarian myWeather new Overlay for weather informations

Using my lyrics:

MyLyrics Start: 0 : 000.0: MyLyrics opens
MyLyrics Information: 0 : 000.0: findLyric(Damien Rice , 9 Crimes )
MyLyrics Information: 0 : 000.4: LyricsOnDemand(Damien Rice , 9 Crimes )
MyLyrics Information: 0 : 000.4: Start searchLyricWiki(Damien Rice , 9 Crimes )
MyLyrics Information: 0 : 000.5: Lyrics007(Damien Rice , 9 Crimes )
MyLyrics Information: 0 : 000.5: SeekLyrics(Damien Rice , 9 Crimes )
MyLyrics Information: 0 : 007.2: Search terminates: No lyric found...

 

[hwahrmann]

sorry, different thread.
Id3v1 tags are now processed correctly.

this is now something with the mylircs plugin itself.

 

[idioteque]

mm ok thx for the advice, I put in a bug report with my lyrics too

thx for the quick support hwahrmann

 

[mackey]

Hi. I received one mp3-file from idioteque and debugged MyLyrics, and it seems like there still is a small issue with the tagreader. The content of the tag is attached. The mp3 has both a id3v1 and id3v2 tag, which both are okay. I have opened them with Tag&Rename. let me know if you want the file for testing.

http://img480.imageshack.us/my.php?image=taguo9.jpg

 

[hwahrmann]

yes, please, i would like to have the file for testing.

 

[mackey]

yes, please, i would like to have the file for testing.

Here you are: http://files-upload.com/files/119040/01-9Crimes.mp3.html