[fixed] Radio - wrong sort order (1 Viewer)

[jameson_uk]

That patch did work but buy was it slow.....

This will work much better. I have too many local changes and testing stuff in TV Server to make a clean binary.

Could people please test that this is fine and does not cause any issues when looking at groups and also when changing sorts etc.

 

[Seidelin]

But do we need any sorting code at all?
I don't think we do. We only have one group of channels shown at a time, and if we don't sort them, they are shown as in Radio guide.

The attached patch works in my testing even after changing order on server and whatever else I could think of. Ignore the first change in patch, that is the solution for 0003537: Radio autoplay on enter - wrong behaviour when already running - MediaPortal Bugtracker

 

[jameson_uk]

But do we need any sorting code at all?

Yes... try deleting a radio station near the start of the list and then adding it again. Then without sorting I am fairly sure this will appear at the end of your list rather than where you place it in group.

How did you remove the sorting? Sorting is always done by OnSort when you open up the page or change sort option. So if you change the ordering to name, type or bitrate (these sorts are fairly useless IMHO but that is another story...) and then back to channel it needs to know how to sort.

Without coding the comparer you are not guaranteed as to what order the data will be shown in

 

[Seidelin]

You are right. My fix doesn't work in those cases.

 

[Seidelin]

But do we need any sorting code at all?

Yes... try deleting a radio station near the start of the list and then adding it again. Then without sorting I am fairly sure this will appear at the end of your list rather than where you place it in group.

How did you remove the sorting? Sorting is always done by OnSort when you open up the page or change sort option. So if you change the ordering to name, type or bitrate (these sorts are fairly useless IMHO but that is another story...) and then back to channel it needs to know how to sort.

Without coding the comparer you are not guaranteed as to what order the data will be shown in

I tried your patch. That doesn't work when changing sort schemes.

I tried:
1. changing sort group from favorites to all channels.
2. Change sort from channels to Genre
3. Observe channel order changes.
4. Change sort from Genre to Channels
5. Observe: Still sorted as before (3.)

In fact I think your code is just as bad as mine

 

[jameson_uk]

I tried your patch. That doesn't work when changing sort schemes.

I tried:
1. changing sort group from favorites to all channels.
2. Change sort from channels to Genre
3. Observe channel order changes.
4. Change sort from Genre to Channels
5. Observe: Still sorted as before (3.)

In fact I think your code is just as bad as mine

My code is indeed normally bad but I can not replicate what you are saying. When I change sort it does re-sort.

Can you double check this was with v2 of the patch (binary attached). If so could you post the details of your radiogroupmap and radiogroup tables from the database?

 

[Seidelin]

I have two groups. Your binary works fine for sorting "Favorites" (4 channels).
It doesn't work for "All Channels". That's weird.

 

[jameson_uk]

I have two groups. Your binary works fine for sorting "Favorites" (4 channels).
It doesn't work for "All Channels". That's weird.

That might be a different issue.... I have seen mp add the same sort order (something like 9999) to everything. Can you please attach the data from groupmap tables?

 

[jameson_uk]

bump

 

[Seidelin]

That might be a different issue.... I have seen mp add the same sort order (something like 9999) to everything. Can you please attach the data from groupmap tables?

How do I do that? SQL has never been my thing.