Reply to thread

Message

<blockquote data-quote="rekenaar" data-source="post: 212384" data-attributes="member: 27829">Since I am using the slideshow feature on a daily basis, I would really like to have this bug fixed.I never before looked at c# code, but since I have java programming experience, I decided to try and look at the code. Downloaded VC# Express 2008.Downloaded other requirements.Downloaded source.Inserted a few log statements and I now have a fix for this bug. Can one of the developers PLEASE PLEASE look at this and help me get it in SVN.Under WindowPlugins, GUIPictures, GUISlideShow.cs:LoadSettings() is somehow only called after StartSlideShow(). That is why all variables have the right values the second time - it is called, but too late for the first run.If we can call it at the start of the slideshow, it works perfectly:[CODE]&nbsp; &nbsp; public void StartSlideShow()&nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; LoadSettings();[/CODE]and[CODE]&nbsp; &nbsp; public void StartSlideShow(string path)&nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; LoadSettings();[/CODE]This was confirmed by building the project and only replacing the WindowPlugins.dll file in my MP installation.Please help me.Secondly, by looking at the code, I noticed that the button R.Slideshow is for Recursive Slideshow and NOT Random Slideshow as I thought&nbsp; <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite10" alt=":oops:" title="Oops!&nbsp; &nbsp; :oops:" loading="lazy" data-shortname=":oops:" /> . I guess most of you knew that, but I am posting just in case someone else who did not know it, reads this.Thank you.</blockquote>

[QUOTE="rekenaar, post: 212384, member: 27829"] Since I am using the slideshow feature on a daily basis, I would really like to have this bug fixed. I never before looked at c# code, but since I have java programming experience, I decided to try and look at the code. Downloaded VC# Express 2008. Downloaded other requirements. Downloaded source. Inserted a few log statements and I now have a fix for this bug. Can one of the developers PLEASE PLEASE look at this and help me get it in SVN. Under WindowPlugins, GUIPictures, GUISlideShow.cs: LoadSettings() is somehow only called after StartSlideShow(). That is why all variables have the right values the second time - it is called, but too late for the first run. If we can call it at the start of the slideshow, it works perfectly: [CODE] public void StartSlideShow() { LoadSettings();[/CODE] and [CODE] public void StartSlideShow(string path) { LoadSettings();[/CODE] This was confirmed by building the project and only replacing the WindowPlugins.dll file in my MP installation. Please help me. Secondly, by looking at the code, I noticed that the button R.Slideshow is for Recursive Slideshow and NOT Random Slideshow as I thought :ooops: . I guess most of you knew that, but I am posting just in case someone else who did not know it, reads this. Thank you. [/QUOTE]

Verification