Reply to thread

Message

<blockquote data-quote="Guzzi" data-source="post: 939433" data-attributes="member: 55213">Hmmm, actually, looking into MyFilms code, all is &quot;intended&quot; right:[CODE]&nbsp; &nbsp; &nbsp; &nbsp; if (ended || (stopped &amp;&amp; playTimePercentage &gt;= 80))&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (MovieWatched != null &amp;&amp; MyFilms.conf.AllowTraktSync)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; MovieWatched(movie);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; LogMyFilms.Debug(&quot;UpdateOnPlayEnd(): Fired 'MovieWatched' event with movie = '&quot; + movie.Title + &quot;'&quot;);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; }[/CODE]So the MovieWatched event should only be fired if either the film ended or was stopped after more than 80% runtime.I looked into trakt code, there the myfilms handler correctly only launches the rating dialog when MovieWatched is received, not e.g. for MovieStopped.So it looks, like there might be a problem with runtime calculation of multi part movies - might be caused by changes in VDB.Will have to look into it...</blockquote>

[QUOTE="Guzzi, post: 939433, member: 55213"] Hmmm, actually, looking into MyFilms code, all is "intended" right: [CODE] if (ended || (stopped && playTimePercentage >= 80)) { if (MovieWatched != null && MyFilms.conf.AllowTraktSync) { MovieWatched(movie); LogMyFilms.Debug("UpdateOnPlayEnd(): Fired 'MovieWatched' event with movie = '" + movie.Title + "'"); } } [/CODE] So the MovieWatched event should only be fired if either the film ended or was stopped after more than 80% runtime. I looked into trakt code, there the myfilms handler correctly only launches the rating dialog when MovieWatched is received, not e.g. for MovieStopped. So it looks, like there might be a problem with runtime calculation of multi part movies - might be caused by changes in VDB. Will have to look into it... [/QUOTE]

Verification