Germany
- Thread starter
- #11
Mantis entry 0004263 created and git branch renamed (FEAT-4263-Rework_TV_Radio_Configuration)
Michael
Michael
Rework of TV and Radio configuration (1 Viewer)
- Thread starter michael_t
- Start date
Not yet tested, as I am currently testing stuff from tourettes. However, it looks great and needs to be tested and check so it can be merged to 1.4.0.
The great thing about the train model is that this can be merged as soon as it is definitely tested and bug-free. It is a clear enhancement, and of benefit to everyone!
The great thing about the train model is that this can be merged as soon as it is definitely tested and bug-free. It is a clear enhancement, and of benefit to everyone!
Tested. Basically this is working fine, so I have scheduled it for 1.4.0.
The only thing I see is that in the plugins screen, if I right-click on the radio plugin, I can still open some config options. Since these are now all within the TV/Radio section, this menu option and the resulting dialog should be removed.
@michael_t - great work! Is there anything else that needs doing, or is this (and the 4218 mantis) all done?
If there is nothing else, then hopefully you can get the extra dialog removed, we can test it again and get it merged to master!!!
The only thing I see is that in the plugins screen, if I right-click on the radio plugin, I can still open some config options. Since these are now all within the TV/Radio section, this menu option and the resulting dialog should be removed.
@michael_t - great work! Is there anything else that needs doing, or is this (and the 4218 mantis) all done?
If there is nothing else, then hopefully you can get the extra dialog removed, we can test it again and get it merged to master!!!
- Thread starter
- #15
The config option in the plugin section has been removed, but maybe you forgot to replace the original tvplugin.dll or reinstalled it again unwillingly?
Michael
Last edited:
I just merged the latest version of the branch to master, along with a couple of other fixes, and built MP fresh. I definitely installed the updated TvPlugin.dll, so I am not sure where this is coming from but I definitely have a 'configuration' option when I right-click on 'radio' in plugins.
Edit: which specific commit takes care of this? I will check that it is included in my build.
Last edited:
Doh. I'm an idiot.
Reinstalled the TV plugin and all is fine! Best to check though
So, is there anything else to be done? If not, then this is ready to merge IMO.
Mark
Reinstalled the TV plugin and all is fine! Best to check though
So, is there anything else to be done? If not, then this is ready to merge IMO.
Mark
- Thread starter
- #18
Did you get your host scanning issue fixed? EDIT: Just noticed you PM.Doh. I'm an idiot.
Reinstalled the TV plugin and all is fine! Best to check though
So, is there anything else to be done? If not, then this is ready to merge IMO.
Mark
Should I try to implement another host scanning method (based on pings) or is it ok that the MP server and the MP client have to be in the same workgroup (using shares etc.)?
Michael
Last edited:
Did you get your host scanning issue fixed?Doh. I'm an idiot.
Reinstalled the TV plugin and all is fine! Best to check though
So, is there anything else to be done? If not, then this is ready to merge IMO.
Mark
Michael
Yes, it was a network config issue on my side. Computers in different workgroups. Once I sorted the network, all is fine. Tested on server and two clients.
- Thread starter
- #20
I just uploaded the newest release which implements a timeout to the network scan (otherwise it could take very long on a network with many hosts). From my point of view the change is ready to be tested and merged. I will do documentation then.
Michael