[Approved] Show Comskip Markers in Timeline (4 Viewers)

[mattjcurry]

I went ahead and took your suggestion and just worked my changes into the tvprogress control. The end result is the same.

I tried to make the markers more generic by changing the names of the parameters:

<markertexture>osd_progress_mid_orange.png</markertexture>
<labelmarkerstarts>#TV.Record.jumppoints</labelmarkerstarts>
<labelmarkerends>#TV.Record.chapters</labelmarkerends>

Let me know what you guys think.

 

[mattjcurry]

On a second note, I do think that there is room for performance improvements on the tvprogress control.

There does not seem to me to be a reason to calcululate the size and position of the background image, the left image, or right image on each call to render. It would be better to determine the position once and then just call .Render().

What do you think? I had refactored it in one of my local copies, but I am afraid to put it in the branch because the code changes are so drastic that it will be difficult to merge in changes from the master branch.

Matt

 

[DieBagger]

If I were you I would leave the performance changes for now and create a second patch for them... They are welcome o.c., but the larger the changeset, the harder it will be to get them approved...

 

[mattjcurry]

I agree with you. Thanks for re-affirming what I was thinking.

So, where do I go from here? Is there anyone that is willing to help me test?

 

[mattjcurry]

Today I finished removing the class and the alias for the GUITVComskipProgress class.

I think this bad boy is ready for some heavy testing. I tested it without defining the new xml elements to be sure that there was not catastrophic failure, and everything seemed normal.

Should I try to post something on the wiki?

 

[mattjcurry]

I tried to change this wiki page:
http://wiki.team-mediaportal.com/1_...ns/Skin_Architecture/Skin_Controls/Tvprogress

I can see the changes, but I am not sure if they have to be approved or not. I figured that getting the functionality documented is a step in the right direction of getting approved.

 

[jameson_uk]

New features will get added to 1.3 and this is one I would like to see!

we will look at user submitted code soon but these things never happen quickly

 

[DieBagger]

I tried to change this wiki page:
http://wiki.team-mediaportal.com/1_...ns/Skin_Architecture/Skin_Controls/Tvprogress

I can see the changes, but I am not sure if they have to be approved or not. I figured that getting the functionality documented is a step in the right direction of getting approved.

A good way of getting more people testing is to post binaries... Not everyone can compile the sourcecode themself.

 

[Holzi]

Maybe you also can post in the Area51 section. Or is this thread for team member developers only?

 

[mattjcurry]

I will post binaries tonight rebased to 1.2.2.

I cannot post in the area 51 as I am not an MP dev If you know anyone who wants to post it on my behalf, then let me know and I would love to get it in there.