[Approved] Show Comskip Markers in Timeline (4 Viewers)

[mattjcurry]

I updated the first post with the latest binaries and skin files. Please let me know how it works out for you.

Thanks.

 

[mattjcurry]

Just wondering if anyone had a chance to test my binaries. If so, please share your feedback.

 

[heaso1]

Matt,

This is an excellent extension of the comkip functionality. At last there is a visual indication within the GUI that:

• Comskip has actually run and done it's thing and;
• That MP is actually loading and ad skipping correctly.

It works as advertised on my system with pre-recorded TV (comskip set to run "post record").
I tested with the 1.2.2 DefaultWide skin and the latest 1.3.0 skin, which is still under development.

 

[kimnach]

Just wondering if anyone had a chance to test my binaries. If so, please share your feedback.

matt, i tried the binaries yesterday with the default wide skin. (note, i use Purevision HD but thought it best to see how it works before trying to modify the PVHD files). i copied the binaries and the xml files, and started mp 1.2.2. the timeline would not display when the cursor was dragged to the bottom of the screen and would only briefly flash onscreen when i skipped with the keyboard. what i did see of the timeline was monochromatic--no commercial gaps.

 

[mattjcurry]

I will try to test and see if I can reproduce. I have not tried installing any skins yet. I was going to do a fresh build against 1.2.3 anyhow.

I did a test against 1.2.1 and with a fresh install without my patches with the default wide skin when I drag the mouse to the bottom of the screen, I do not get the OSD showing up. It only shows up when I hit Y, or try to fast forward and rewind, so I do not think my changes altered that behavior (Perhaps it is a feature of the skin you were using before).

When I fast forward using F6 on my keyboard, and I have a recorded TV show that has chapters defined (you can check by right clicking and seeing if there is an option for chapters), it shows the OSD and the markers and the OSD stays on screen as long as I am fast forwarding. If us use the arrows for skip forward and skip back, then you are right, the OSD shows for a second then goes away. This is by design of the skin.

Shortcuts are listed here:
http://wiki.team-mediaportal.com/1_MEDIAPORTAL_1/20_Reference/Keyboard_Shortcuts/2_TV

Thank you for testing, and please let me know if you think I missed something. However, I think it is most likely that Default Wide works a little differently than what you are used to.

 

[mattjcurry]

Posted Binaries to 1.2.3 to first post.

 

[Crabstick]

Just found this thread. I'm going to test this right now I'm using Frames skin, so I'll try to make the changes you suggest.

Just while you are at it, I have a proposal: the one and only problem I sometimes have with comskip is the false-positives it may detect. When that happens, I miss parts or an ending of the show when it incorrectly skips the program. I'd like to have an option to temporarily disable the comskip feature from within MP. Either from the playback context menu or TV-configuration screen. Now the only option is to delete the whole comskip data and start watching the recording again (without skipping). This is not ideal.

Would it be hard to implement that control in the UI?

 

[Crabstick]

Replaced the binaries to MP folder (first took backups), edited the skin file in Frames (added those 3 lines to common.progressbar.tv.xml) and works like charm! Thanks!

 

[hafblade]

Yeah this looks great. Have to test this.

 

[vuego]

Good idea Crabstick, or perhaps add a button to "Undo last comskip jump and ignore comskip data". That way you won't have to manually rewind to the last false comskip jump.